Skip to content

RFC clone: dir iterator refactoring with tests

Ævar Arnfjörð Bjarmason git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest5 patches 4 repliesIn review
  2. v1 RFC7 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5clone: test for our behavior on odd objects/* contentt/t5604-clone-reference.sh+142 -03 replies
2/5dir-iterator: add flags parameter to dir_iterator_begindir-iterator.c dir-iterator.h refs/files-backend.c+58 -120 replies
3/5clone: copy hidden paths at local clonebuiltin/clone.c t/t5604-clone-reference.sh+10 -10 replies
4/5clone: extract function from copy_or_link_directorybuiltin/clone.c+19 -80 replies
5/5clone: use dir-iterator to avoid explicit dir traversalbuiltin/clone.c+22 -220 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchMatheus TavaresÆvar Arnfjörð BjarmasonDaniel Ferreira
SeriesHelped-by Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Co-authored-by Original-patch-by Original-patch-by Original-patch-by
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [RFC PATCH v3 0/5] clone: dir iterator refactoring with tests

There's still active review going on for the "v2"[1], in particular Duy's comments coming in as I write this. This doesn't address any of that.

What it does do is have a better version of my patch to add tests for the current behavior. It now doesn't reply the on SHA1 prereq anymore, and we can test the dotfiles without needing the SYMLINK prereq.

I also moved it to the front of the series just to document/make sure that we start by asserting testing functionality. I ran a full test suite run for each of these patches and they all pass.

The only other change is getting rid of an unused "struct stat st" variable which errored out under DEVELOPER=1.

1. https://public-inbox.org/git/[email protected]/

Matheus Tavares (4):
dir-iterator: add flags parameter to dir_iterator_begin
clone: copy hidden paths at local clone
clone: extract function from copy_or_link_directory
clone: use dir-iterator to avoid explicit dir traversal

Ævar Arnfjörð Bjarmason (1):
clone: test for our behavior on odd objects/* content

 builtin/clone.c            |  69 ++++++++++-------
 dir-iterator.c             |  28 ++++++-
 dir-iterator.h             |  40 ++++++++--
 refs/files-backend.c       |   2 +-
 t/t5604-clone-reference.sh | 151 +++++++++++++++++++++++++++++++++++++
 5 files changed, 249 insertions(+), 41 deletions(-)
Signature · 1 line
2.21.0.rc2.261.ga7da99ff1b