s390x/tcg: Vector Instruction Support Part 1
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest32 patches 7 repliesApplied
- v232 patches 22 repliesSuperseded
- v133 patches 60 repliesSuperseded
Changes in v3 from the cover letter
- "s390x/tcg: Utilities for vector instruction helpers" -- inline helpers in header file
- "s390x/tcg: Implement VECTOR LOAD MULTIPLE" -- optimize loading of last element
- "s390x/tcg: Implement VECTOR PACK *"
-- make the static funtion arrays const
- "s390x/tcg: Implement VECTOR REPLICATE"
-- use "tcg_gen_gvec_dup_mem"
- "s390x/tcg: Provide probe_write helper"
-- Add check for CONFIG_USER_ONLY
-- Optimize calculation of length
- Added r-b's
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/32 | s390x/tcg: Define vector instruction formatstarget/ target/ | +63 | 0 replies | |
| 2/32 | s390x/tcg: Check vector register instructions at central pointtarget/ target/ | +19 | 0 replies | |
| 3/32 | s390x/tcg: Utilities for vector instruction helperstarget/ | +101 | 2 replies | |
| 4/32 | s390x/tcg: Implement VECTOR GATHER ELEMENTtarget/ target/ target/ | +143 | 0 replies | |
| 5/32 | s390x/tcg: Implement VECTOR GENERATE BYTE MASKtarget/ target/ target/ | +42 | 0 replies | |
| 6/32 | s390x/tcg: Implement VECTOR GENERATE MASKtarget/ target/ | +49 | 0 replies | |
| 7/32 | s390x/tcg: Implement VECTOR LOADtarget/ target/ | +27 | 0 replies | |
| 8/32 | s390x/tcg: Implement VECTOR LOAD AND REPLICATEtarget/ target/ | +21 | 0 replies | |
| 9/32 | s390x/tcg: Implement VECTOR LOAD ELEMENTtarget/ target/ | +23 | 0 replies | |
| 10/32 | s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATEtarget/ target/ | +22 | 0 replies | |
| 11/32 | s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENTtarget/ target/ | +65 | 0 replies | |
| 12/32 | s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZEROtarget/ target/ | +48 | 0 replies | |
| 13/32 | s390x/tcg: Implement VECTOR LOAD MULTIPLEtarget/ target/ | +42 | 0 replies | |
| 14/32 | s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARYtarget/ target/ target/ +2 more | +75 | 0 replies | |
| 15/32 | s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GRtarget/ target/ | +43 | 0 replies | |
| 16/32 | s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINTtarget/ target/ | +9 | 0 replies | |
| 17/32 | s390x/tcg: Implement VECTOR LOAD WITH LENGTHtarget/ target/ target/ | +22 | 0 replies | |
| 18/32 | s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)target/ target/ | +46 | 0 replies | |
| 19/32 | s390x/tcg: Implement VECTOR PACK *target/ target/ target/ +1 more | +215 | 0 replies | |
| 20/32 | s390x/tcg: Implement VECTOR PERMUTEtarget/ target/ target/ +1 more | +34 | 0 replies | |
| 21/32 | s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATEtarget/ target/ | +18 | 0 replies | |
| 22/32 | s390x/tcg: Implement VECTOR REPLICATEtarget/ target/ | +18 | 0 replies | |
| 23/32 | s390x/tcg: Implement VECTOR REPLICATE IMMEDIATEtarget/ target/ | +16 | 0 replies | |
| 24/32 | s390x/tcg: Implement VECTOR SCATTER ELEMENTtarget/ target/ | +25 | 0 replies | |
| 25/32 | s390x/tcg: Implement VECTOR SELECTtarget/ target/ | +43 | 0 replies | |
| 26/32 | s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORDtarget/ target/ | +35 | 0 replies | |
| 27/32 | s390x/tcg: Provide probe_write_access helpertarget/ target/ target/ | +28 | 4 replies | |
| 28/32 | s390x/tcg: Implement VECTOR STOREtarget/ target/ | +19 | 0 replies | |
| 29/32 | s390x/tcg: Implement VECTOR STORE ELEMENTtarget/ target/ | +23 | 0 replies | |
| 30/32 | s390x/tcg: Implement VECTOR STORE MULTIPLEtarget/ target/ | +32 | 0 replies | |
| 31/32 | s390x/tcg: Implement VECTOR STORE WITH LENGTHtarget/ target/ target/ +1 more | +40 | 0 replies | |
| 32/32 | s390x/tcg: Implement VECTOR UNPACK *target/ target/ | +46 | 0 replies |
Reviews trailers per patch
All 32 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Thomas Huth |
|---|---|---|
| 1/32 | R-b | |
| 2/32 | R-b | |
| 3/32 | R-b | R-b |
| 4/32 | R-b | |
| 5/32 | R-b | |
| 6/32 | R-b | |
| 7/32 | R-b | |
| 8/32 | R-b | |
| 9/32 | R-b | |
| 10/32 | R-b | |
| 11/32 | R-b | |
| 12/32 | R-b | |
| 13/32 | R-b | |
| 14/32 | R-b | |
| 15/32 | R-b | |
| 16/32 | R-b | |
| 17/32 | R-b | |
| 18/32 | R-b | |
| 19/32 | R-b | |
| 20/32 | R-b | |
| 21/32 | R-b | |
| 22/32 | R-b | |
| 23/32 | R-b | |
| 24/32 | R-b | |
| 25/32 | R-b | |
| 26/32 | R-b | |
| 27/32 | R-b | |
| 28/32 | R-b | |
| 29/32 | R-b | |
| 30/32 | R-b | |
| 31/32 | R-b | |
| 32/32 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1
This is the first part of vector instruction support for s390x. Parts will be sent and reviewed piece by piece.
Part 1: Vector Support Instructions
Part 2: Vector Integer Instructions
Part 3: Vector String Instructions
Part 4: Vector Floating-Point Instructions
The current state can be found at (kept updated):
https://github.com/davidhildenbrand/qemu/tree/vx
It is based on
https://github.com/cohuck/qemu/tree/s390-next
With the current state I can boot Linux kernel + user space compiled with SIMD support. This allows to boot distributions compiled exclusively for z13, requiring SIMD support. Also, I have a growing set of tests for kvm-unit-tests and tests/tcg which I cross-test on a real s390x system.
In this part, the basic infrastructure and all Vector Support Instructions introduced with the "Vector Facility" are added. The Vector Extension Facilities are not considered for now.
We make use of the existing gvec expansion + ool (out-of-line) support. This will be heavily used especially for part 2 (Integer Instructions) where we can actually reuse quite some existing gvec expansions.
v2 -> v3:
- "s390x/tcg: Utilities for vector instruction helpers" -- inline helpers in header file
- "s390x/tcg: Implement VECTOR LOAD MULTIPLE" -- optimize loading of last element
- "s390x/tcg: Implement VECTOR PACK *"
-- make the static funtion arrays const
- "s390x/tcg: Implement VECTOR REPLICATE"
-- use "tcg_gen_gvec_dup_mem"
- "s390x/tcg: Provide probe_write helper"
-- Add check for CONFIG_USER_ONLY
-- Optimize calculation of length
- Added r-b's
v1 -> v2:
- Basically address all wonderful review comments from Richard (too many to name them all)
- Probe write access to get rid of FIXMEs
- Heavily rework "s390x/tcg: Implement VECTOR PACK *"
-- Process cc and !cc separately.
-- Helper for VPK
- Don't use a temporary vector register (for now)
- Drop load_vec_element() and store_vec_element()
- Use ES_* instead of MO_*, will come in handy when we use ES_128 later
- .... many many other minor things
David Hildenbrand (32):
s390x/tcg: Define vector instruction formats s390x/tcg: Check vector register instructions at central point s390x/tcg: Utilities for vector instruction helpers s390x/tcg: Implement VECTOR GATHER ELEMENT s390x/tcg: Implement VECTOR GENERATE BYTE MASK s390x/tcg: Implement VECTOR GENERATE MASK
s390x/tcg: Implement VECTOR LOAD
s390x/tcg: Implement VECTOR LOAD AND REPLICATE s390x/tcg: Implement VECTOR LOAD ELEMENT
s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO s390x/tcg: Implement VECTOR LOAD MULTIPLE
s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT s390x/tcg: Implement VECTOR LOAD WITH LENGTH s390x/tcg: Implement VECTOR MERGE (HIGH|LOW) s390x/tcg: Implement VECTOR PACK *
s390x/tcg: Implement VECTOR PERMUTE
s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE s390x/tcg: Implement VECTOR REPLICATE
s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE s390x/tcg: Implement VECTOR SCATTER ELEMENT s390x/tcg: Implement VECTOR SELECT
s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD s390x/tcg: Provide probe_write_access helper s390x/tcg: Implement VECTOR STORE
s390x/tcg: Implement VECTOR STORE ELEMENT
s390x/tcg: Implement VECTOR STORE MULTIPLE s390x/tcg: Implement VECTOR STORE WITH LENGTH s390x/tcg: Implement VECTOR UNPACK *
target/s390x/Makefile.objs | 1 + target/s390x/cpu.h | 7 + target/s390x/helper.h | 21 + target/s390x/insn-data.def | 82 +++ target/s390x/insn-format.def | 25 + target/s390x/internal.h | 2 + target/s390x/mem_helper.c | 25 + target/s390x/translate.c | 61 ++- target/s390x/translate_vx.inc.c | 935 ++++++++++++++++++++++++++++++++ target/s390x/vec.h | 101 ++++ target/s390x/vec_helper.c | 193 +++++++ 11 files changed, 1452 insertions(+), 1 deletion(-) create mode 100644 target/s390x/translate_vx.inc.c create mode 100644 target/s390x/vec.h create mode 100644 target/s390x/vec_helper.c
Signature · 1 line
2.17.2