Skip to content

brcmfmac: recover PCIe devices from firmware crashes

Rafał Miłecki linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4brcmfmac: support repeated brcmf_fw_alloc_request() callsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c+1 -02 replies
2/4brcmfmac: get RAM info right before downloading PCIe firmwaredrivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+11 -21 reply
3/4brcmfmac: add a function designated for handling firmware failsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +1 more+15 -31 reply
4/4brcmfmac: reset PCIe bus on a firmware crashdrivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h +1 more+59 -01 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchArend van Spriel
1/4R-b
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] brcmfmac: recover PCIe devices from firmware crashes

From: Rafał Miłecki <[email protected]>

So far PCIe firmware halts / crashes were resulting in massive timeouts and running out of resources (e.g. slots). There wasn't even a clear message indicating the problem source.

This patches improves it by:
1) Printing an error
2) Reloading a firmware

After that user can setup interface(s) & use a wireless card again. It should be much more convenient than reloading a module manually thanks to:
1) Automation
2) Not affecting other (working) wireless cards

Rafał Miłecki (4):
brcmfmac: support multiple brcmf_fw_alloc_request() calls
brcmfmac: get RAM info right before downloading PCIe firmware
brcmfmac: add function designated for handling firmware failures
brcmfmac: reset PCIe bus on firmware crash

 .../broadcom/brcm80211/brcmfmac/bus.h         | 12 ++++++
 .../broadcom/brcm80211/brcmfmac/chip.c        |  6 ++-
 .../broadcom/brcm80211/brcmfmac/chip.h        |  1 +
 .../broadcom/brcm80211/brcmfmac/core.c        | 22 ++++++++++
 .../broadcom/brcm80211/brcmfmac/core.h        |  2 +
 .../broadcom/brcm80211/brcmfmac/firmware.c    |  1 +
 .../broadcom/brcm80211/brcmfmac/pcie.c        | 43 ++++++++++++++++++-
 .../broadcom/brcm80211/brcmfmac/sdio.c        |  4 +-
 8 files changed, 86 insertions(+), 5 deletions(-)
Signature · 1 line
2.20.1