Skip to content

net: Fail route add with unsupported nexthop attribute

David Ahern netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ipv4: Return error for RTA_VIA attributenet/ipv4/fib_frontend.c+4 -00 replies
2/3ipv6: Return error for RTA_VIA attributenet/ipv6/route.c+4 -00 replies
3/3mpls: Return error for RTA_GATEWAY attributenet/mpls/af_mpls.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] net: Fail route add with unsupported nexthop attribute

From: David Ahern <[email protected]>

RTA_VIA was added for MPLS as a way of specifying a gateway from a different address family. IPv4 and IPv6 do not currently support RTA_VIA so using it leads to routes that are not what the user intended. Catch and fail - returning a proper error message.

MPLS on the other hand does not support RTA_GATEWAY since it does not make sense to have a nexthop from the MPLS address family. Similarly, catch and fail - returning a proper error message.

David Ahern (3):
ipv4: Return error for RTA_VIA attribute
ipv6: Return error for RTA_VIA attribute
mpls: Return error for RTA_GATEWAY attribute

 net/ipv4/fib_frontend.c | 4 ++++
 net/ipv6/route.c        | 4 ++++
 net/mpls/af_mpls.c      | 3 +++
 3 files changed, 11 insertions(+)
Signature · 1 line
2.11.0