Skip to content

RFC tests/tcg: Vector instruction tests for target/s390x

David Hildenbrand qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 1 replyIn review
  2. v1 RFC2 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/tcg: target/s390x: Test VECTOR GATHER ELEMENTtests/tcg/s390x/Makefile.target tests/tcg/s390x/helper.h tests/tcg/s390x/signal-helper.inc.c +1 more+149 -01 reply
2/2tests/tcg: target/s390x: Test VECTOR LOAD GR FROM VR ELEMENTtests/tcg/s390x/Makefile.target tests/tcg/s390x/helper.h tests/tcg/s390x/vlgv.c+44 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH RFCv2 0/2] tests/tcg: Vector instruction tests for target/s390x

As I currently work on vector instruction support for s390x/tcg, for now I wrote my tests for kvm-unit-tests, but tests/tcg seems to be a better fit. The only tricky part is testing interrupt handling, but that also seems to be possible using some signal hackery.

This is only one test to discuss if the approach make sense. These patches only work when applied on top of:
https://github.com/davidhildenbrand/qemu/tree/vx

Before I go ahead and implement more tests, let's clarify if this is the way to go first.

RFC -> RFCv2:
- Dropped "tests/tcg: Allow targets to set the optimization level" -- Handle it directly from the Makefile
- Add a test for VECTOR GATHER ELEMENT
- Rework signal handling to work with more than one signal occurrence. Also simplify setting the signal handlers a bit.

David Hildenbrand (2):
tests/tcg: target/s390x: Test VECTOR GATHER ELEMENT tests/tcg: target/s390x: Test VECTOR LOAD GR FROM VR ELEMENT

 tests/tcg/s390x/Makefile.target     |  7 +++
 tests/tcg/s390x/helper.h            | 28 +++++++++++
 tests/tcg/s390x/signal-helper.inc.c | 46 ++++++++++++++++++
 tests/tcg/s390x/vge.c               | 75 +++++++++++++++++++++++++++++
 tests/tcg/s390x/vlgv.c              | 37 ++++++++++++++
 5 files changed, 193 insertions(+)
 create mode 100644 tests/tcg/s390x/helper.h
 create mode 100644 tests/tcg/s390x/signal-helper.inc.c
 create mode 100644 tests/tcg/s390x/vge.c
 create mode 100644 tests/tcg/s390x/vlgv.c
Signature · 1 line
2.17.2