Skip to content

softirq: Per vector masking v3

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest37 patches 6 repliesIn review

Changes since v2 from the cover letter · 21 lines

* Fix unused function warning (reported by Kbuild test robot)
- locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING

* Added Reviewed-by tags from davem

* Reorder changes introducing u64 to the proper patches (reported by Linus)

* Fix lock usage mask iteration by avoid shifting beyond 63 (reported by Linus)
- locking/lockdep: Introduce lock usage mask iterator

* Fix mark_lock() verbosity by handling all usages in the ask
- locking/lockdep: Report all usages on mark_lock() verbosity mode

* Add SPDX licence identifier on softirq_vector.h (reported by Sebastian)

* Fix several build errors on s390 (reported by Kbuild test robot)
- arch/softirq: Rename softirq_pending fields to softirq_data
- softirq: Introduce disabled softirq vectors bits
- softirq: Check enabled vectors before processing

* Initialize softirq enabled field on all other archs than x86
- parisc: Init softirq enabled field
- powerpc: Init softirq enabled field
- softirq: Init softirq enabled field for default irq_stat definition

* Fix spin_[un]lock_bh_mask() on UP, also some build errors against uninlined spinlocks (reported by Kbuild test robot)
- locking: Introduce spin_[un]lock_bh_mask()

* Socket lock may also execute on HRTIMER_SOFTIRQ, include it on the mask (reported by Sebastian)
- net: Make softirq vector masking finegrained on release_sock()

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/37locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKINGkernel/locking/lockdep.c+6 -40 replies
2/37locking/lockdep: Use expanded masks on find_usage_*() functionskernel/locking/lockdep.c+15 -150 replies
3/37locking/lockdep: Introduce struct lock_usagekernel/locking/lockdep.c kernel/locking/lockdep_internals.h+79 -490 replies
4/37locking/lockdep: Convert usage_mask to u64include/linux/lockdep.h kernel/locking/lockdep.c+13 -130 replies
5/37locking/lockdep: Introduce lock usage mask iteratorkernel/locking/lockdep.c+17 -00 replies
6/37locking/lockdep: Test all incompatible scenario at once in check_irq_usage()kernel/locking/lockdep.c+126 -670 replies
7/37locking/lockdep: Prepare valid_state() to handle plain maskskernel/locking/lockdep.c+34 -50 replies
8/37locking/lockdep: Prepare check_usage_*() to handle plain maskskernel/locking/lockdep.c+24 -60 replies
9/37locking/lockdep: Prepare state_verbose() to handle all softirqskernel/locking/lockdep.c+4 -80 replies
10/37locking/lockdep: Make mark_lock() fastpath to work with multiple usage at oncekernel/locking/lockdep.c+2 -20 replies
11/37locking/lockdep: Save stack trace for each softirq vector involvedinclude/linux/lockdep.h kernel/locking/lockdep.c+15 -20 replies
12/37locking/lockdep: Report all usages on mark_lock() verbosity modekernel/locking/lockdep.c+5 -10 replies
13/37softirq: Macrofy softirq vectorsinclude/linux/interrupt.h include/linux/softirq_vector.h+16 -130 replies
14/37locking/lockdep: Define per vector softirq lock usage stateskernel/locking/lockdep_internals.h kernel/locking/lockdep_states.h+42 -51 reply
15/37softirq: Pass softirq vector number to lockdep on vector executioninclude/linux/irqflags.h kernel/softirq.c lib/locking-selftest.c+12 -120 replies
16/37x86: Revert "x86/irq: Demote irq_cpustat_t::__softirq_pending to u16"arch/x86/include/asm/hardirq.h+1 -10 replies
17/37arch/softirq: Rename softirq_pending fields to softirq_dataarch/arm/include/asm/hardirq.h arch/arm64/include/asm/hardirq.h arch/h8300/kernel/asm-offsets.c +15 more+25 -250 replies
18/37softirq: Normalize softirq_pending naming schemearch/s390/include/asm/hardirq.h include/linux/interrupt.h kernel/softirq.c+16 -160 replies
19/37softirq: Convert softirq_pending_*() to set/clear mask schemearch/s390/include/asm/hardirq.h include/linux/interrupt.h kernel/softirq.c+7 -60 replies
20/37softirq: Introduce disabled softirq vectors bitsarch/s390/include/asm/hardirq.h include/linux/interrupt.h+57 -71 reply
21/37softirq: Rename _local_bh_enable() to local_bh_enable_no_softirq()arch/s390/lib/delay.c drivers/s390/char/sclp.c drivers/s390/cio/cio.c +2 more+10 -100 replies
22/37softirq: Move vectors bits to bottom_half.hinclude/linux/bottom_half.h include/linux/interrupt.h+24 -210 replies
23/37x86: Init softirq enabled fieldarch/x86/kernel/irq.c include/linux/bottom_half.h+6 -10 replies
24/37parisc: Init softirq enabled fieldarch/parisc/kernel/irq.c+5 -10 replies
25/37powerpc: Init softirq enabled fieldarch/powerpc/kernel/irq.c+4 -10 replies
26/37softirq: Init softirq enabled field for default irq_stat definitionkernel/softirq.c+3 -10 replies
27/37softirq: Check enabled vectors before processinginclude/linux/interrupt.h kernel/softirq.c+16 -100 replies
28/37softirq: Remove stale commentkernel/softirq.c+0 -40 replies
29/37softirq: Uninline !CONFIG_TRACE_IRQFLAGS __local_bh_disable_ip()include/linux/bottom_half.h kernel/softirq.c+6 -140 replies
30/37softirq: Prepare for mixing all/per-vector maskingkernel/softirq.c+22 -110 replies
31/37softirq: Support per vector maskinginclude/linux/bottom_half.h kernel/softirq.c+80 -120 replies
32/37locking/lockdep: Remove redundant softirqs on checkkernel/locking/lockdep.c kernel/locking/lockdep_internals.h kernel/locking/lockdep_proc.c+1 -70 replies
33/37locking/lockdep: Update check_flags() according to new layoutkernel/locking/lockdep.c+1 -60 replies
34/37locking/lockdep: Branch the new vec-finegrained softirq masking to lockdepkernel/locking/lockdep.c+11 -10 replies
35/37softirq: Allow to soft interrupt vector-specific masked contextskernel/softirq.c+5 -50 replies
36/37locking: Introduce spin_[un]lock_bh_mask()include/linux/spinlock.h include/linux/spinlock_api_smp.h include/linux/spinlock_api_up.h +1 more+74 -00 replies
37/37net: Make softirq vector masking finegrained on release_sock()net/core/sock.c+6 -20 replies

Reviews trailers per patch

31 of 37 patches have a Reviewed-by or Acked-by.

PatchDavid S. MillerLinus Torvalds
1/37
2/37R-b
3/37R-b
4/37R-b
5/37Inspired-by
6/37R-b
7/37R-b
8/37R-b
9/37R-b
10/37R-b
11/37R-b
12/37
13/37R-b
14/37R-b
15/37R-b
16/37R-b
17/37R-b
18/37R-b
19/37R-b
20/37R-b
21/37R-b
22/37R-b
23/37R-b
24/37
25/37
26/37
27/37R-b
28/37R-b
29/37R-b
30/37R-b
31/37R-b
32/37R-b
33/37R-b
34/37R-b
35/37R-b
36/37R-b
37/37R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/37] softirq: Per vector masking v3

So this set should hopefully address all reviews from the v2, and fix all reports from the extremely useful (as always) Kbuild testing bot. It also completes support for all archs.

Unfortunately the already huge pile is ever growing. I should be able to offload 2 or 3 of those patches but the rest really belong together.

Changes since v2:

* Fix unused function warning (reported by Kbuild test robot)
- locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING

* Added Reviewed-by tags from davem

* Reorder changes introducing u64 to the proper patches (reported by Linus)

* Fix lock usage mask iteration by avoid shifting beyond 63 (reported by Linus)
- locking/lockdep: Introduce lock usage mask iterator

* Fix mark_lock() verbosity by handling all usages in the ask
- locking/lockdep: Report all usages on mark_lock() verbosity mode

* Add SPDX licence identifier on softirq_vector.h (reported by Sebastian)

* Fix several build errors on s390 (reported by Kbuild test robot)
- arch/softirq: Rename softirq_pending fields to softirq_data
- softirq: Introduce disabled softirq vectors bits
- softirq: Check enabled vectors before processing

* Initialize softirq enabled field on all other archs than x86
- parisc: Init softirq enabled field
- powerpc: Init softirq enabled field
- softirq: Init softirq enabled field for default irq_stat definition

* Fix spin_[un]lock_bh_mask() on UP, also some build errors against uninlined spinlocks (reported by Kbuild test robot)
- locking: Introduce spin_[un]lock_bh_mask()

* Socket lock may also execute on HRTIMER_SOFTIRQ, include it on the mask (reported by Sebastian)
- net: Make softirq vector masking finegrained on release_sock()

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
softirq/soft-interruptible-v2

HEAD: 63c89028058f5920d4b5a9d38452fa4623469583

Thanks,
Frederic
---

Frederic Weisbecker (37):
locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING locking/lockdep: Use expanded masks on find_usage_*() functions locking/lockdep: Introduce struct lock_usage
locking/lockdep: Convert usage_mask to u64
locking/lockdep: Introduce lock usage mask iterator
locking/lockdep: Test all incompatible scenario at once in check_irq_usage() locking/lockdep: Prepare valid_state() to handle plain masks locking/lockdep: Prepare check_usage_*() to handle plain masks locking/lockdep: Prepare state_verbose() to handle all softirqs locking/lockdep: Make mark_lock() fastpath to work with multiple usage at once locking/lockdep: Save stack trace for each softirq vector involved locking/lockdep: Report all usages on mark_lock() verbosity mode
softirq: Macrofy softirq vectors
locking/lockdep: Define per vector softirq lock usage states
softirq: Pass softirq vector number to lockdep on vector execution
x86: Revert "x86/irq: Demote irq_cpustat_t::__softirq_pending to u16" arch/softirq: Rename softirq_pending fields to softirq_data
softirq: Normalize softirq_pending naming scheme
softirq: Convert softirq_pending_*() to set/clear mask scheme
softirq: Introduce disabled softirq vectors bits
softirq: Rename _local_bh_enable() to local_bh_enable_no_softirq()
softirq: Move vectors bits to bottom_half.h
x86: Init softirq enabled field
parisc: Init softirq enabled field
powerpc: Init softirq enabled field
softirq: Init softirq enabled field for default irq_stat definition
softirq: Check enabled vectors before processing
softirq: Remove stale comment
softirq: Uninline !CONFIG_TRACE_IRQFLAGS __local_bh_disable_ip()
softirq: Prepare for mixing all/per-vector masking
softirq: Support per vector masking
locking/lockdep: Remove redundant softirqs on check
locking/lockdep: Update check_flags() according to new layout locking/lockdep: Branch the new vec-finegrained softirq masking to lockdep
softirq: Allow to soft interrupt vector-specific masked contexts
locking: Introduce spin_[un]lock_bh_mask()
net: Make softirq vector masking finegrained on release_sock()

 arch/arm/include/asm/hardirq.h      |   2 +-
 arch/arm64/include/asm/hardirq.h    |   2 +-
 arch/h8300/kernel/asm-offsets.c     |   2 +-
 arch/ia64/include/asm/hardirq.h     |   2 +-
 arch/ia64/include/asm/processor.h   |   2 +-
 arch/m68k/include/asm/hardirq.h     |   2 +-
 arch/m68k/kernel/asm-offsets.c      |   2 +-
 arch/parisc/include/asm/hardirq.h   |   2 +-
 arch/parisc/kernel/irq.c            |   6 +-
 arch/powerpc/include/asm/hardirq.h  |   2 +-
 arch/powerpc/kernel/irq.c           |   5 +-
 arch/s390/include/asm/hardirq.h     |  11 +-
 arch/s390/include/asm/lowcore.h     |   2 +-
 arch/s390/lib/delay.c               |   2 +-
 arch/sh/include/asm/hardirq.h       |   2 +-
 arch/sparc/include/asm/cpudata_64.h |   2 +-
 arch/sparc/include/asm/hardirq_64.h |   4 +-
 arch/um/include/asm/hardirq.h       |   2 +-
 arch/x86/include/asm/hardirq.h      |   2 +-
 arch/x86/kernel/irq.c               |   5 +-
 drivers/s390/char/sclp.c            |   2 +-
 drivers/s390/cio/cio.c              |   2 +-
 include/asm-generic/hardirq.h       |   2 +-
 include/linux/bottom_half.h         |  41 +++-
 include/linux/interrupt.h           |  87 ++++---
 include/linux/irqflags.h            |  12 +-
 include/linux/lockdep.h             |   5 +-
 include/linux/softirq_vector.h      |  12 +
 include/linux/spinlock.h            |  14 ++
 include/linux/spinlock_api_smp.h    |  28 +++
 include/linux/spinlock_api_up.h     |  13 +
 kernel/locking/lockdep.c            | 475 ++++++++++++++++++++++++------------
 kernel/locking/lockdep_internals.h  |  50 +++-
 kernel/locking/lockdep_proc.c       |   2 +-
 kernel/locking/lockdep_states.h     |   4 +-
 kernel/locking/spinlock.c           |  19 ++
 kernel/softirq.c                    | 163 +++++++++----
 lib/locking-selftest.c              |   4 +-
 net/core/sock.c                     |   8 +-
 39 files changed, 715 insertions(+), 289 deletions(-)