softirq: Per vector masking v3
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest37 patches 6 repliesIn review
Changes since v2 from the cover letter · 21 lines
* Fix unused function warning (reported by Kbuild test robot)
- locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING
* Added Reviewed-by tags from davem
* Reorder changes introducing u64 to the proper patches (reported by Linus)
* Fix lock usage mask iteration by avoid shifting beyond 63 (reported by Linus)
- locking/lockdep: Introduce lock usage mask iterator
* Fix mark_lock() verbosity by handling all usages in the ask
- locking/lockdep: Report all usages on mark_lock() verbosity mode
* Add SPDX licence identifier on softirq_vector.h (reported by Sebastian)
* Fix several build errors on s390 (reported by Kbuild test robot)
- arch/softirq: Rename softirq_pending fields to softirq_data
- softirq: Introduce disabled softirq vectors bits
- softirq: Check enabled vectors before processing
* Initialize softirq enabled field on all other archs than x86
- parisc: Init softirq enabled field
- powerpc: Init softirq enabled field
- softirq: Init softirq enabled field for default irq_stat definition
* Fix spin_[un]lock_bh_mask() on UP, also some build errors against uninlined spinlocks (reported by Kbuild test robot)
- locking: Introduce spin_[un]lock_bh_mask()
* Socket lock may also execute on HRTIMER_SOFTIRQ, include it on the mask (reported by Sebastian)
- net: Make softirq vector masking finegrained on release_sock()
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/37 | locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKINGkernel/ | +6 | 0 replies | |
| 2/37 | locking/lockdep: Use expanded masks on find_usage_*() functionskernel/ | +15 | 0 replies | |
| 3/37 | locking/lockdep: Introduce struct lock_usagekernel/ kernel/ | +79 | 0 replies | |
| 4/37 | locking/lockdep: Convert usage_mask to u64include/ kernel/ | +13 | 0 replies | |
| 5/37 | locking/lockdep: Introduce lock usage mask iteratorkernel/ | +17 | 0 replies | |
| 6/37 | locking/lockdep: Test all incompatible scenario at once in check_irq_usage()kernel/ | +126 | 0 replies | |
| 7/37 | locking/lockdep: Prepare valid_state() to handle plain maskskernel/ | +34 | 0 replies | |
| 8/37 | locking/lockdep: Prepare check_usage_*() to handle plain maskskernel/ | +24 | 0 replies | |
| 9/37 | locking/lockdep: Prepare state_verbose() to handle all softirqskernel/ | +4 | 0 replies | |
| 10/37 | locking/lockdep: Make mark_lock() fastpath to work with multiple usage at oncekernel/ | +2 | 0 replies | |
| 11/37 | locking/lockdep: Save stack trace for each softirq vector involvedinclude/ kernel/ | +15 | 0 replies | |
| 12/37 | locking/lockdep: Report all usages on mark_lock() verbosity modekernel/ | +5 | 0 replies | |
| 13/37 | softirq: Macrofy softirq vectorsinclude/ include/ | +16 | 0 replies | |
| 14/37 | locking/lockdep: Define per vector softirq lock usage stateskernel/ kernel/ | +42 | 1 reply | |
| 15/37 | softirq: Pass softirq vector number to lockdep on vector executioninclude/ kernel/ lib/ | +12 | 0 replies | |
| 16/37 | x86: Revert "x86/irq: Demote irq_cpustat_t::__softirq_pending to u16"arch/ | +1 | 0 replies | |
| 17/37 | arch/softirq: Rename softirq_pending fields to softirq_dataarch/ arch/ arch/ +15 more | +25 | 0 replies | |
| 18/37 | softirq: Normalize softirq_pending naming schemearch/ include/ kernel/ | +16 | 0 replies | |
| 19/37 | softirq: Convert softirq_pending_*() to set/clear mask schemearch/ include/ kernel/ | +7 | 0 replies | |
| 20/37 | softirq: Introduce disabled softirq vectors bitsarch/ include/ | +57 | 1 reply | |
| 21/37 | softirq: Rename _local_bh_enable() to local_bh_enable_no_softirq()arch/ drivers/ drivers/ +2 more | +10 | 0 replies | |
| 22/37 | softirq: Move vectors bits to bottom_half.hinclude/ include/ | +24 | 0 replies | |
| 23/37 | x86: Init softirq enabled fieldarch/ include/ | +6 | 0 replies | |
| 24/37 | parisc: Init softirq enabled fieldarch/ | +5 | 0 replies | |
| 25/37 | powerpc: Init softirq enabled fieldarch/ | +4 | 0 replies | |
| 26/37 | softirq: Init softirq enabled field for default irq_stat definitionkernel/ | +3 | 0 replies | |
| 27/37 | softirq: Check enabled vectors before processinginclude/ kernel/ | +16 | 0 replies | |
| 28/37 | softirq: Remove stale commentkernel/ | +0 | 0 replies | |
| 29/37 | softirq: Uninline !CONFIG_TRACE_IRQFLAGS __local_bh_disable_ip()include/ kernel/ | +6 | 0 replies | |
| 30/37 | softirq: Prepare for mixing all/per-vector maskingkernel/ | +22 | 0 replies | |
| 31/37 | softirq: Support per vector maskinginclude/ kernel/ | +80 | 0 replies | |
| 32/37 | locking/lockdep: Remove redundant softirqs on checkkernel/ kernel/ kernel/ | +1 | 0 replies | |
| 33/37 | locking/lockdep: Update check_flags() according to new layoutkernel/ | +1 | 0 replies | |
| 34/37 | locking/lockdep: Branch the new vec-finegrained softirq masking to lockdepkernel/ | +11 | 0 replies | |
| 35/37 | softirq: Allow to soft interrupt vector-specific masked contextskernel/ | +5 | 0 replies | |
| 36/37 | locking: Introduce spin_[un]lock_bh_mask()include/ include/ include/ +1 more | +74 | 0 replies | |
| 37/37 | net: Make softirq vector masking finegrained on release_sock()net/ | +6 | 0 replies |
Reviews trailers per patch
31 of 37 patches have a Reviewed-by or Acked-by.
| Patch | David S. Miller | Linus Torvalds |
|---|---|---|
| 1/37 | ||
| 2/37 | R-b | |
| 3/37 | R-b | |
| 4/37 | R-b | |
| 5/37 | Inspired-by | |
| 6/37 | R-b | |
| 7/37 | R-b | |
| 8/37 | R-b | |
| 9/37 | R-b | |
| 10/37 | R-b | |
| 11/37 | R-b | |
| 12/37 | ||
| 13/37 | R-b | |
| 14/37 | R-b | |
| 15/37 | R-b | |
| 16/37 | R-b | |
| 17/37 | R-b | |
| 18/37 | R-b | |
| 19/37 | R-b | |
| 20/37 | R-b | |
| 21/37 | R-b | |
| 22/37 | R-b | |
| 23/37 | R-b | |
| 24/37 | ||
| 25/37 | ||
| 26/37 | ||
| 27/37 | R-b | |
| 28/37 | R-b | |
| 29/37 | R-b | |
| 30/37 | R-b | |
| 31/37 | R-b | |
| 32/37 | R-b | |
| 33/37 | R-b | |
| 34/37 | R-b | |
| 35/37 | R-b | |
| 36/37 | R-b | |
| 37/37 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/37] softirq: Per vector masking v3
So this set should hopefully address all reviews from the v2, and fix all reports from the extremely useful (as always) Kbuild testing bot. It also completes support for all archs.
Unfortunately the already huge pile is ever growing. I should be able to offload 2 or 3 of those patches but the rest really belong together.
Changes since v2:
* Fix unused function warning (reported by Kbuild test robot)
- locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING
* Added Reviewed-by tags from davem
* Reorder changes introducing u64 to the proper patches (reported by Linus)
* Fix lock usage mask iteration by avoid shifting beyond 63 (reported by Linus)
- locking/lockdep: Introduce lock usage mask iterator
* Fix mark_lock() verbosity by handling all usages in the ask
- locking/lockdep: Report all usages on mark_lock() verbosity mode
* Add SPDX licence identifier on softirq_vector.h (reported by Sebastian)
* Fix several build errors on s390 (reported by Kbuild test robot)
- arch/softirq: Rename softirq_pending fields to softirq_data
- softirq: Introduce disabled softirq vectors bits
- softirq: Check enabled vectors before processing
* Initialize softirq enabled field on all other archs than x86
- parisc: Init softirq enabled field
- powerpc: Init softirq enabled field
- softirq: Init softirq enabled field for default irq_stat definition
* Fix spin_[un]lock_bh_mask() on UP, also some build errors against uninlined spinlocks (reported by Kbuild test robot)
- locking: Introduce spin_[un]lock_bh_mask()
* Socket lock may also execute on HRTIMER_SOFTIRQ, include it on the mask (reported by Sebastian)
- net: Make softirq vector masking finegrained on release_sock()
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
softirq/soft-interruptible-v2
HEAD: 63c89028058f5920d4b5a9d38452fa4623469583
Thanks,
Frederic
---
Frederic Weisbecker (37):
locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING locking/lockdep: Use expanded masks on find_usage_*() functions locking/lockdep: Introduce struct lock_usage
locking/lockdep: Convert usage_mask to u64
locking/lockdep: Introduce lock usage mask iterator
locking/lockdep: Test all incompatible scenario at once in check_irq_usage() locking/lockdep: Prepare valid_state() to handle plain masks locking/lockdep: Prepare check_usage_*() to handle plain masks locking/lockdep: Prepare state_verbose() to handle all softirqs locking/lockdep: Make mark_lock() fastpath to work with multiple usage at once locking/lockdep: Save stack trace for each softirq vector involved locking/lockdep: Report all usages on mark_lock() verbosity mode
softirq: Macrofy softirq vectors
locking/lockdep: Define per vector softirq lock usage states
softirq: Pass softirq vector number to lockdep on vector execution
x86: Revert "x86/irq: Demote irq_cpustat_t::__softirq_pending to u16" arch/softirq: Rename softirq_pending fields to softirq_data
softirq: Normalize softirq_pending naming scheme
softirq: Convert softirq_pending_*() to set/clear mask scheme
softirq: Introduce disabled softirq vectors bits
softirq: Rename _local_bh_enable() to local_bh_enable_no_softirq()
softirq: Move vectors bits to bottom_half.h
x86: Init softirq enabled field
parisc: Init softirq enabled field
powerpc: Init softirq enabled field
softirq: Init softirq enabled field for default irq_stat definition
softirq: Check enabled vectors before processing
softirq: Remove stale comment
softirq: Uninline !CONFIG_TRACE_IRQFLAGS __local_bh_disable_ip()
softirq: Prepare for mixing all/per-vector masking
softirq: Support per vector masking
locking/lockdep: Remove redundant softirqs on check
locking/lockdep: Update check_flags() according to new layout locking/lockdep: Branch the new vec-finegrained softirq masking to lockdep
softirq: Allow to soft interrupt vector-specific masked contexts
locking: Introduce spin_[un]lock_bh_mask()
net: Make softirq vector masking finegrained on release_sock()
arch/arm/include/asm/hardirq.h | 2 +- arch/arm64/include/asm/hardirq.h | 2 +- arch/h8300/kernel/asm-offsets.c | 2 +- arch/ia64/include/asm/hardirq.h | 2 +- arch/ia64/include/asm/processor.h | 2 +- arch/m68k/include/asm/hardirq.h | 2 +- arch/m68k/kernel/asm-offsets.c | 2 +- arch/parisc/include/asm/hardirq.h | 2 +- arch/parisc/kernel/irq.c | 6 +- arch/powerpc/include/asm/hardirq.h | 2 +- arch/powerpc/kernel/irq.c | 5 +- arch/s390/include/asm/hardirq.h | 11 +- arch/s390/include/asm/lowcore.h | 2 +- arch/s390/lib/delay.c | 2 +- arch/sh/include/asm/hardirq.h | 2 +- arch/sparc/include/asm/cpudata_64.h | 2 +- arch/sparc/include/asm/hardirq_64.h | 4 +- arch/um/include/asm/hardirq.h | 2 +- arch/x86/include/asm/hardirq.h | 2 +- arch/x86/kernel/irq.c | 5 +- drivers/s390/char/sclp.c | 2 +- drivers/s390/cio/cio.c | 2 +- include/asm-generic/hardirq.h | 2 +- include/linux/bottom_half.h | 41 +++- include/linux/interrupt.h | 87 ++++--- include/linux/irqflags.h | 12 +- include/linux/lockdep.h | 5 +- include/linux/softirq_vector.h | 12 + include/linux/spinlock.h | 14 ++ include/linux/spinlock_api_smp.h | 28 +++ include/linux/spinlock_api_up.h | 13 + kernel/locking/lockdep.c | 475 ++++++++++++++++++++++++------------ kernel/locking/lockdep_internals.h | 50 +++- kernel/locking/lockdep_proc.c | 2 +- kernel/locking/lockdep_states.h | 4 +- kernel/locking/spinlock.c | 19 ++ kernel/softirq.c | 163 +++++++++---- lib/locking-selftest.c | 4 +- net/core/sock.c | 8 +- 39 files changed, 715 insertions(+), 289 deletions(-)