Skip to content

enc28j60: messaging clean up and ACPI improvements

Andy Shevchenko netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/213 patches 1 replyIn review
  2. v2 posting 1/213 patches 4 repliesSuperseded
  3. v17 patches 2 repliesSuperseded

Since v2 from the cover letter

- cover letter is added

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13enc28j60: Use device_get_mac_address()drivers/net/ethernet/microchip/enc28j60.c+3 -40 replies
2/13enc28j60: Remove duplicate messagingdrivers/net/ethernet/microchip/enc28j60.c+0 -200 replies
3/13enc28j60: Replace dev_*(&netdev->dev, ...) with netdev_*()drivers/net/ethernet/microchip/enc28j60.c+18 -240 replies
4/13enc28j60: Drop driver name duplication from messagesdrivers/net/ethernet/microchip/enc28j60.c+6 -70 replies
5/13enc28j60: Switch to use module_spi_driver() macrodrivers/net/ethernet/microchip/enc28j60.c+2 -190 replies
6/13enc28j60: Use ether_addr_copy() in enc28j60_set_mac_address()drivers/net/ethernet/microchip/enc28j60.c+1 -10 replies
7/13enc28j60: Switch to dev_<level> from pr_<level>drivers/net/ethernet/microchip/enc28j60.c+17 -120 replies
8/13enc28j60: Convert HW related printk() to dev_printk()drivers/net/ethernet/microchip/enc28j60.c+141 -1190 replies
9/13enc28j60: Convert printk() to netdev_printk()drivers/net/ethernet/microchip/enc28j60.c+27 -240 replies
10/13enc28j60: Remove linux/init.hdrivers/net/ethernet/microchip/enc28j60.c+0 -10 replies
11/13enc28j60: Amend comments by fixing typos, adding periods, etcdrivers/net/ethernet/microchip/enc28j60.c+16 -150 replies
12/13enc28j60: Fix indentation splatsdrivers/net/ethernet/microchip/enc28j60.c+21 -370 replies
13/13enc28j60: Convert to use SPDX identifierdrivers/net/ethernet/microchip/enc28j60.c+1 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] enc28j60: messaging clean up and ACPI improvements

Most of the patches in the series dedicated to update messaging to use modern APIs, such as netdev, with a benefit to distinguish devices, if more than one installed on the system.

Besides that, patch 1 targeting ACPI enabled systems when MAC address provided there via properties.

And few clean ups are included, such as:
- switching to module_spi_driver()
- converting to use ether_addr_copy() API
- converting to use SPDX

Since v2:
- cover letter is added

Andy Shevchenko (13):
enc28j60: Use device_get_mac_address()
enc28j60: Remove duplicate messaging
enc28j60: Replace dev_*(&netdev->dev, ...) with netdev_*()
enc28j60: Drop driver name duplication from messages
enc28j60: Switch to use module_spi_driver() macro
enc28j60: Use ether_addr_copy() in enc28j60_set_mac_address()
enc28j60: Switch to dev_<level> from pr_<level>
enc28j60: Convert HW related printk() to dev_printk()
enc28j60: Convert printk() to netdev_printk()
enc28j60: Remove linux/init.h
enc28j60: Amend comments by fixing typos, adding periods, etc
enc28j60: Fix indentation splats
enc28j60: Convert to use SPDX identifier

 drivers/net/ethernet/microchip/enc28j60.c | 541 ++++++++++------------
 1 file changed, 253 insertions(+), 288 deletions(-)
Signature · 1 line
2.20.1