Skip to content

net: call for phys_port_name into devlink directly if possible

Jiri Pirko netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 3 repliesIn review
  2. v312 patches 2 repliesSuperseded
  3. v212 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12nfp: register devlink port before netdevdrivers/net/ethernet/netronome/nfp/nfp_net_main.c+17 -150 replies
2/12net: replace ndo_get_devlink with ndo_get_devlink_portdrivers/net/ethernet/netronome/nfp/nfp_app.h drivers/net/ethernet/netronome/nfp/nfp_devlink.c drivers/net/ethernet/netronome/nfp/nfp_net_common.c +3 more+23 -130 replies
3/12net: devlink: introduce devlink_compat_phys_port_name_get()include/net/devlink.h net/core/dev.c net/core/devlink.c+43 -50 replies
4/12mlxsw: Implement ndo_get_devlink_portdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/minimal.c +2 more+48 -00 replies
5/12mlxsw: Remove ndo_get_phys_port_name implementationdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/minimal.c +2 more+0 -450 replies
6/12net: devlink: remove unused devlink_port_get_phys_port_name() functioninclude/net/devlink.h net/core/devlink.c+0 -90 replies
7/12bnxt: implement ndo_get_devlink_portdrivers/net/ethernet/broadcom/bnxt/bnxt.c+9 -10 replies
8/12bnxt: remove ndo_get_phys_port_name implementationdrivers/net/ethernet/broadcom/bnxt/bnxt.c+0 -180 replies
9/12dsa: implement ndo_get_devlink_portnet/dsa/slave.c+8 -01 reply
10/12dsa: do not support ndo_get_phys_port_name for non-legacy portsnet/dsa/slave.c+7 -01 reply
11/12nfp: do not handle nn->port defined case in nfp_net_get_phys_port_name()drivers/net/ethernet/netronome/nfp/nfp_net_common.c+4 -10 replies
12/12net: devlink: add warning for ndo_get_phys_port_name set when not needednet/core/devlink.c+18 -00 replies

Reviews trailers per patch

8 of 12 patches have a Reviewed-by or Acked-by.

PatchJakub KicinskiMichal KubecekFlorian Fainelli
1/12R-b
2/12R-b R-b R-b
3/12R-b
4/12
5/12R-b
6/12
7/12
8/12
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [patch net-next v4 00/12] net: call for phys_port_name into devlink directly if possible

From: Jiri Pirko <[email protected]>

phys_port_name may be assembled by a helper in devlink. It is currently the case only for mlxsw driver. Benefit from the get_devlink_port ndo and call into devlink directly from dev_get_phys_port_name(). That saves the trip to the driver, simplifies the code and makes it similar to recently introduced ethtool-devlink compat helpers.

Move bnxt, partly nfp and dsa to let devlink core generate the name too.

Jiri Pirko (12):
nfp: register devlink port before netdev
net: replace ndo_get_devlink with ndo_get_devlink_port
net: devlink: introduce devlink_compat_phys_port_name_get()
mlxsw: Implement ndo_get_devlink_port
mlxsw: Remove ndo_get_phys_port_name implementation
net: devlink: remove unused devlink_port_get_phys_port_name() function
bnxt: implement ndo_get_devlink_port
bnxt: remove ndo_get_phys_port_name implementation
dsa: implement ndo_get_devlink_port
dsa: do not support ndo_get_phys_port_name for non-legacy ports
nfp: do not handle nn->port defined case in
nfp_net_get_phys_port_name()
net: devlink: add warning for ndo_get_phys_port_name set when not
needed

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 26 ++++--------
 drivers/net/ethernet/mellanox/mlxsw/core.c    | 10 +++--
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 ++-
 drivers/net/ethernet/mellanox/mlxsw/minimal.c | 22 +++++-----
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 22 +++++-----
 .../net/ethernet/mellanox/mlxsw/switchx2.c    | 22 +++++-----
 drivers/net/ethernet/netronome/nfp/nfp_app.h  |  2 +-
 .../net/ethernet/netronome/nfp/nfp_devlink.c  | 10 ++---
 .../ethernet/netronome/nfp/nfp_net_common.c   |  7 +++-
 .../net/ethernet/netronome/nfp/nfp_net_main.c | 32 ++++++++-------
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  2 +-
 include/linux/netdevice.h                     |  6 +--
 include/net/devlink.h                         | 25 +++++++++--
 net/core/dev.c                                | 11 +++--
 net/core/devlink.c                            | 41 +++++++++++++++++--
 net/dsa/slave.c                               | 15 +++++++
 16 files changed, 164 insertions(+), 94 deletions(-)
Signature · 1 line
2.17.2