net: call for phys_port_name into devlink directly if possible
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest12 patches 3 repliesIn review
- v312 patches 2 repliesSuperseded
- v212 patches 13 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 5 patches | 8 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | nfp: register devlink port before netdevdrivers/ | +17 | 0 replies | |
| 2/12 | net: replace ndo_get_devlink with ndo_get_devlink_portdrivers/ drivers/ drivers/ +3 more | +23 | 0 replies | |
| 3/12 | net: devlink: introduce devlink_compat_phys_port_name_get()include/ net/ net/ | +43 | 0 replies | |
| 4/12 | mlxsw: Implement ndo_get_devlink_portdrivers/ drivers/ drivers/ +2 more | +48 | 0 replies | |
| 5/12 | mlxsw: Remove ndo_get_phys_port_name implementationdrivers/ drivers/ drivers/ +2 more | +0 | 0 replies | |
| 6/12 | net: devlink: remove unused devlink_port_get_phys_port_name() functioninclude/ net/ | +0 | 0 replies | |
| 7/12 | bnxt: implement ndo_get_devlink_portdrivers/ | +9 | 0 replies | |
| 8/12 | bnxt: remove ndo_get_phys_port_name implementationdrivers/ | +0 | 0 replies | |
| 9/12 | dsa: implement ndo_get_devlink_portnet/ | +8 | 1 reply | |
| 10/12 | dsa: do not support ndo_get_phys_port_name for non-legacy portsnet/ | +7 | 1 reply | |
| 11/12 | nfp: do not handle nn->port defined case in nfp_net_get_phys_port_name()drivers/ | +4 | 0 replies | |
| 12/12 | net: devlink: add warning for ndo_get_phys_port_name set when not needednet/ | +18 | 0 replies |
Reviews trailers per patch
8 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Jakub Kicinski | Michal Kubecek | Florian Fainelli |
|---|---|---|---|
| 1/12 | R-b | ||
| 2/12 | R-b | R-b | R-b |
| 3/12 | R-b | ||
| 4/12 | |||
| 5/12 | R-b | ||
| 6/12 | |||
| 7/12 | |||
| 8/12 | |||
| 9/12 | R-b | ||
| 10/12 | R-b | ||
| 11/12 | R-b | ||
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [patch net-next v4 00/12] net: call for phys_port_name into devlink directly if possible
From: Jiri Pirko <[email protected]>
phys_port_name may be assembled by a helper in devlink. It is currently the case only for mlxsw driver. Benefit from the get_devlink_port ndo and call into devlink directly from dev_get_phys_port_name(). That saves the trip to the driver, simplifies the code and makes it similar to recently introduced ethtool-devlink compat helpers.
Move bnxt, partly nfp and dsa to let devlink core generate the name too.
Jiri Pirko (12):
nfp: register devlink port before netdev
net: replace ndo_get_devlink with ndo_get_devlink_port
net: devlink: introduce devlink_compat_phys_port_name_get()
mlxsw: Implement ndo_get_devlink_port
mlxsw: Remove ndo_get_phys_port_name implementation
net: devlink: remove unused devlink_port_get_phys_port_name() function
bnxt: implement ndo_get_devlink_port
bnxt: remove ndo_get_phys_port_name implementation
dsa: implement ndo_get_devlink_port
dsa: do not support ndo_get_phys_port_name for non-legacy ports
nfp: do not handle nn->port defined case in
nfp_net_get_phys_port_name()
net: devlink: add warning for ndo_get_phys_port_name set when not
needed
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 ++++-------- drivers/net/ethernet/mellanox/mlxsw/core.c | 10 +++-- drivers/net/ethernet/mellanox/mlxsw/core.h | 5 ++- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 22 +++++----- .../net/ethernet/mellanox/mlxsw/spectrum.c | 22 +++++----- .../net/ethernet/mellanox/mlxsw/switchx2.c | 22 +++++----- drivers/net/ethernet/netronome/nfp/nfp_app.h | 2 +- .../net/ethernet/netronome/nfp/nfp_devlink.c | 10 ++--- .../ethernet/netronome/nfp/nfp_net_common.c | 7 +++- .../net/ethernet/netronome/nfp/nfp_net_main.c | 32 ++++++++------- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 2 +- include/linux/netdevice.h | 6 +-- include/net/devlink.h | 25 +++++++++-- net/core/dev.c | 11 +++-- net/core/devlink.c | 41 +++++++++++++++++-- net/dsa/slave.c | 15 +++++++ 16 files changed, 164 insertions(+), 94 deletions(-)
Signature · 1 line
2.17.2