Skip to content

RFC net: expose switch ID via devlink

Jiri Pirko netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: devlink: convert devlink_port_attrs bools to bitsinclude/net/devlink.h+2 -21 reply
2/8net: devlink: extend port attrs for switch IDdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/netronome/nfp/nfp_devlink.c include/net/devlink.h +3 more+40 -142 replies
3/8net: devlink: introduce devlink_compat_switch_id_get() helperinclude/net/devlink.h net/core/dev.c net/core/devlink.c+40 -22 replies
4/8mlxsw: Pass switch ID through devlink_port_attrs_set()drivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c +1 more+12 -50 replies
5/8mlxsw: Remove ndo_get_port_parent_id implementationdrivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/switchx2.c+0 -262 replies
6/8nfp: pass switch ID through devlink_port_attrs_set()drivers/net/ethernet/netronome/nfp/nfp_devlink.c+5 -10 replies
7/8nfp: register devlink port before netdevdrivers/net/ethernet/netronome/nfp/nfp_net_main.c+13 -140 replies
8/8nfp: remove ndo_get_port_parent_id implementationdrivers/net/ethernet/netronome/nfp/nfp_net_common.c drivers/net/ethernet/netronome/nfp/nfp_net_repr.c drivers/net/ethernet/netronome/nfp/nfp_port.c+0 -181 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/8R-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch net-next RFC 0/8] net: expose switch ID via devlink

From: Jiri Pirko <[email protected]>

To provide visibility of the ports, as discussed this week, this patchset exposes switch ID for devlink ports, which are part of a switch. The rest of the ports if any (in case of sr-iov for example) do not set switch ID.

Note that I send this as RFC because I don't have the NFP bits correct. The switch ID should be only set for the eswitch ports (representors). Jakub, could you please help with this?

As a follow-up I also plan to add devlink_port_attrs_set to all users of ndo_get_port_parent_id and ndo_get_phys_port_name and remove these ndos completely. But that also depends on Jakub's patchset which introduces PF and VF port flavours.

Jiri Pirko (8):
net: devlink: convert devlink_port_attrs bools to bits
net: devlink: extend port attrs for switch ID
net: devlink: introduce devlink_compat_switch_id_get() helper
mlxsw: Pass switch ID through devlink_port_attrs_set()
mlxsw: Remove ndo_get_port_parent_id implementation
nfp: pass switch ID through devlink_port_attrs_set()
nfp: register devlink port before netdev
nfp: remove ndo_get_port_parent_id implementation

 drivers/net/ethernet/mellanox/mlxsw/core.c         |  7 ++-
 drivers/net/ethernet/mellanox/mlxsw/core.h         |  4 +-
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c     | 17 ++-----
 drivers/net/ethernet/mellanox/mlxsw/switchx2.c     | 16 +------
 drivers/net/ethernet/netronome/nfp/nfp_devlink.c   |  6 ++-
 .../net/ethernet/netronome/nfp/nfp_net_common.c    |  1 -
 drivers/net/ethernet/netronome/nfp/nfp_net_main.c  | 27 ++++++-----
 drivers/net/ethernet/netronome/nfp/nfp_net_repr.c  |  1 -
 drivers/net/ethernet/netronome/nfp/nfp_port.c      | 16 -------
 include/net/devlink.h                              | 23 +++++++--
 include/uapi/linux/devlink.h                       |  2 +
 net/core/dev.c                                     |  8 +++-
 net/core/devlink.c                                 | 54 +++++++++++++++++++---
 net/dsa/dsa2.c                                     |  6 +--
 14 files changed, 109 insertions(+), 79 deletions(-)
Signature · 1 line
2.14.5