Skip to content

Add xo calibration support for wifi rf clock

Govind Singh ath10k linux-devicetree linux-wireless 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

Added "qcom," prefix in xo cal prop.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt: bindings: add dt entry for XO calibration supportDocumentation/devicetree/bindings/net/wireless/qcom,ath10k.txt+1 -03 replies
2/2ath10k: Add xo calibration support for wifi rf clockdrivers/net/wireless/ath/ath10k/qmi.c drivers/net/wireless/ath/ath10k/snoc.c drivers/net/wireless/ath/ath10k/snoc.h+25 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Add xo calibration support for wifi rf clock

PMIC XO is the clock source for wifi rf clock in integrated wifi chipset ex: WCN3990. Due to board layout errors XO frequency drifts can cause wifi rf clock inaccuracy.
XO calibration test tree in Factory Test Mode is used to find the best frequency offset(for example +/-2KHz )by programming XO trim register. This ensure system clock stays within required 20 ppm WLAN rf clock.

Retrieve the xo trim offset via system firmware (e.g., device tree), especially in the case where the device doesn't have a useful EEPROM on which to store the calibrated XO offset (e.g., for integrated Wifi). Calibrated XO offset is sent to fw, which compensate the clock drift by programing the XO trim register.

Testing:
Tested on QCS404 platform(WCN3990 HW) Tested FW: WLAN.HL.3.1-00959-QCAHLSWMTPLZ-1

change since v2:
Added "qcom," prefix in xo cal prop.

change since v1:
Added return check for case where xo cal dt is not populated.

Govind Singh (2):
dt: bindings: add dt entry for XO calibration support
ath10k: Add xo calibration support for wifi rf clock

 .../devicetree/bindings/net/wireless/qcom,ath10k.txt |  1 +
 drivers/net/wireless/ath/ath10k/qmi.c                | 12 ++++++++++++
 drivers/net/wireless/ath/ath10k/snoc.c               | 11 +++++++++++
 drivers/net/wireless/ath/ath10k/snoc.h               |  2 ++
 4 files changed, 26 insertions(+)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project