Skip to content

Use helper functions in test script

Rohit Ashiwal git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 15 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3test functions: add function `test_file_not_empty`t/test-lib-functions.sh+9 -03 replies
2/3t3600: modernize stylet/t3600-rm.sh+107 -1002 replies
3/3t3600: use helpers to replace test -d/f/e/s <path>t/t3600-rm.sh+75 -759 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [GSoC][PATCH v3 0/3] Use helper functions in test script

This patch ultimately aims to replace test -(d|f|e|s) calls in t3600-rm.sh Previously we were using these to verify the presence of diretory/file, but we already have helper functions, viz, test_path_is_dir, test_path_is_file, test_path_is_missing and test_file_not_empty with better functionality

Helper functions are better as they provide better error messages and improve readability. They are friendly to someone new to code.

Rohit Ashiwal (3):
test functions: add function test_file_not_empty
t3600: modernize style
t3600: use helpers to replace test -d/f/e/s <path>

 t/t3600-rm.sh           | 349 ++++++++++++++++++++--------------------
 t/test-lib-functions.sh |   9 ++
 2 files changed, 187 insertions(+), 171 deletions(-)
Signature · 1 line
Rohit