Skip to content

qemu-binfmt-conf.sh

Unai Martinez-Corral qemu-devel 1 version In review

Get series with b4
b4 am 20190306031221.GA53@03612eec87fc

Versions newest first

  1. v3 Latest10 patches 14 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10qemu-binfmt-conf.sh: enforce safe style consistencyscripts/qemu-binfmt-conf.sh+7 -71 reply
2/10qemu-binfmt-conf.sh: make opts -p and -c booleanscripts/qemu-binfmt-conf.sh+7 -91 reply
3/10qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENTscripts/qemu-binfmt-conf.sh+11 -72 replies
4/10qemu-binfmt-conf.sh: remove 'qemu' prefix from cli optionsscripts/qemu-binfmt-conf.sh+7 -71 reply
5/10qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIXscripts/qemu-binfmt-conf.sh+3 -42 replies
6/10qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS>scripts/qemu-binfmt-conf.sh+57 -352 replies
7/10qemu-binfmt-conf.sh: add option --reset <ARCHS>scripts/qemu-binfmt-conf.sh+33 -32 replies
8/10qemu-binfmt-conf.sh: refactor usage()scripts/qemu-binfmt-conf.sh+17 -171 reply
9/10qemu-binfmt-conf.sh: update usage()scripts/qemu-binfmt-conf.sh+33 -281 reply
10/10qemu-binfmt-conf.sh: support QEMU_TARGETSscripts/qemu-binfmt-conf.sh+14 -121 reply

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchLaurent Vivier
1/10R-b
2/10R-b
3/10
4/10R-b
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh

Hi,

This series reworks qemu-binfmt-conf.sh:

* Argument <CPU> from option '--systemd' is generalized to <TARGETS>, and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. Valid separators are space, tab, newline and comma. Keywords 'ALL' and 'NONE' are supported.
* Option '--reset ARCHS' is added, which allows to remove an already registered target interpreter or a list of them. Valid separator is comma. Keyword 'ALL' is supported. The implementation is functional but partial. Please, see the corresponding commit.
* Support to set options through environment variables is added: QEMU_PATH, QEMU_SUFFIX, QEMU_PERSISTENT, QEMU_CREDENTIAL and QEMU_TARGETS.

The following changes are not backward compatible:

* Option '--persistent' no longer requires/accepts an argument.
* Option '--credential' no longer requires/accepts an argument.
* Option '--systemd' no longer requires/accepts an argument.
* Option '--qemu-path' is renamed to '--path'.
* Option '--qemu-suffix' is renamed to '--suffix'.

The functionality of all of them is untouched. Changes are related to syntax only.

The main differences compared to version 2 are:

* Suggestions by Eric Blake regarding syntax and style consistency have been addressed.
* Changes are split in multiple patches, instead of a single one.
* Option names and support of environament variables is more consistent.

Based on:

* [PATCH v2] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)
* [PATCH] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)

Regards

Unai Martinez-Corral (10):
qemu-binfmt-conf.sh: enforce safe style consistency qemu-binfmt-conf.sh: make opts -p and -c boolean qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS> qemu-binfmt-conf.sh: add option --reset <ARCHS> qemu-binfmt-conf.sh: refactor usage() qemu-binfmt-conf.sh: update usage() qemu-binfmt-conf.sh: support QEMU_TARGETS

 scripts/qemu-binfmt-conf.sh | 190
 1 file changed, 125 insertions(+), 65 deletions(-)