qemu-binfmt-conf.sh
Get series with b4
b4 am 20200309191200.GA60@669c1c222ef4Versions newest first · linked by author and title
- v10 Latest10 patches 9 repliesIn review
- v99 patches 0 repliesSuperseded
- v8 posting 2/29 patches 3 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 posting 1/2 | 9 patches | 0 replies | Superseded | |
| v5 posting 2/2 | 0 of 10 patches | 1 reply | Superseded | |
| v5 posting 1/2 | 9 patches | 0 replies | Superseded | |
| v4 | 10 patches | 13 replies | Superseded | |
| v3 | 1 of 10 patches | 0 replies | Superseded |
v8 from the cover letter
* Fix typos and address review comments
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | qemu-binfmt-conf.sh: enforce style consistencyscripts/ | +17 | 3 replies | |
| 2/10 | qemu-binfmt-conf.sh: enforce safe testsscripts/ | +5 | 4 replies | |
| 3/10 | qemu-binfmt-conf.sh: make opts -p and -c booleanscripts/ | +7 | 0 replies | |
| 4/10 | qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENTscripts/ | +11 | 2 replies | |
| 5/10 | qemu-binfmt-conf.sh: use the same presentation format as for qemu-*scripts/ | +32 | 0 replies | |
| 6/10 | qemu-binfmt-conf.sh: remove 'qemu' prefix from cli optionsscripts/ | +6 | 0 replies | |
| 7/10 | qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIXscripts/ | +4 | 0 replies | |
| 8/10 | qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS]scripts/ | +46 | 0 replies | |
| 9/10 | qemu-binfmt-conf.sh: add option --clearscripts/ | +34 | 0 replies | |
| 10/10 | qemu-binfmt-conf.sh: add --testscripts/ | +14 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Vivier | Eric Blake |
|---|---|---|
| 1/10 | R-b | R-b |
| 2/10 | R-b | R-b |
| 3/10 | R-b | |
| 4/10 | R-b | |
| 5/10 | R-b | |
| 6/10 | R-b | |
| 7/10 | R-b | |
| 8/10 | R-b | |
| 9/10 | R-b | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 0/10] qemu-binfmt-conf.sh
Hi,
This series reworks qemu-binfmt-conf.sh:
* Argument <CPU> from option '--systemd' is generalized to <TARGETS>, and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them.
* Option '-r|--clear' is added, which allows to remove an already registered target interpreter or a list of them. The implementation is functional but partial. Please, see the corresponding commit.
* Option '-t|--test' is added, which allows to execute the CHECK according to the provided arguments, but no interpreter is configured.
* Support to set options through environment variables: QEMU_TARGETS, QEMU_PATH, QEMU_SUFFIX, QEMU_PERSISTENT, QEMU_CREDENTIAL, QEMU_CLEAR and QEMU_TEST.
The following changes are not backward compatible:
* Option '--persistent' no longer requires/accepts an argument.
* Option '--credential' no longer requires/accepts an argument.
* Option '--systemd' no longer requires/accepts an argument.
* Option '--qemu-path' is renamed to '--path'.
* Option '--qemu-suffix' is renamed to '--suffix'.
The functionality of all of them is untouched. Changes are related to syntax only.
v10
* Split style related commit
v9
* Make style coherent with the dominant pattern
v8:
* Fix typos and address review comments
v7:
* Check that a interpreter exists before trying to remove it.
v6:
* Don't need to use "find".
* Put the ";;" at the same position.
* Set BINFMT_CLEAR to ':', to allow --test to work with --clear.
* Do not show DEBIANDIR and SYSTEMDDIR in the Env-variable column.
Based on:
* [PATCH v5 0/10] qemu-binfmt-conf.sh
* should have been [PATCH v5 0/9] qemu-binfmt-conf.sh
* [PATCH v4 0/10] qemu-binfmt-conf.sh
* [PATCH v3 0/10] qemu-binfmt-conf.sh
* [PATCH v2] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)
* [PATCH] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)
* scripts/qemu-binfmt-conf.sh: allow clearing of entries
Regards
Unai Martinez-Corral (10):
qemu-binfmt-conf.sh: enforce style consistency qemu-binfmt-conf.sh: enforce safe tests qemu-binfmt-conf.sh: make opts -p and -c boolean qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT qemu-binfmt-conf.sh: use the same presentation format as for qemu-* qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS qemu-binfmt-conf.sh: add option --clear qemu-binfmt-conf.sh: add --test
scripts/qemu-binfmt-conf.sh | 221
1 file changed, 138 insertions(+), 83 deletions(-i)