Skip to content

ppc: add POWER9 support to the PowerNV platform

Cédric Le Goater qemu-devel 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 17 repliesApplied
  2. v127 patches 27 repliesApplied

Changes in v2 from the cover letter

- introduced Pnv8Psi (XICS) and Pnv9Psi (XIVE) models
- wrote a commit log for the changes in the LPC register ranges
- added a 'dt_isa_nodename' to the chip
- added new attributes to define XSCOM operations per CPU family and a PSI IRQ number in the OCC class model
- added a new attribute to define XSCOM operations per CPU family in the CPU core class model

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/15ppc/pnv: add a PSI bridge class modelhw/ppc/pnv.c hw/ppc/pnv_psi.c include/hw/ppc/pnv.h +1 more+87 -291 reply
2/15ppc/pnv: add a PSI bridge model for POWER9hw/ppc/pnv.c hw/ppc/pnv_psi.c include/hw/ppc/pnv.h +2 more+384 -21 reply
3/15ppc/pnv: lpc: fix OPB address rangeshw/ppc/pnv_lpc.c+4 -31 reply
4/15ppc/pnv: add a LPC Controller class modelhw/ppc/pnv.c hw/ppc/pnv_lpc.c include/hw/ppc/pnv_lpc.h+77 -251 reply
5/15ppc/pnv: add a 'dt_isa_nodename' to the chiphw/ppc/pnv.c include/hw/ppc/pnv.h+7 -133 replies
6/15ppc/pnv: add a LPC Controller model for POWER9hw/ppc/pnv.c hw/ppc/pnv_lpc.c include/hw/ppc/pnv.h +1 more+234 -11 reply
7/15ppc/pnv: add SerIRQ routing registershw/ppc/pnv_lpc.c include/hw/ppc/pnv_lpc.h+16 -01 reply
8/15ppc/pnv: add a OCC model classhw/ppc/pnv.c hw/ppc/pnv_occ.c include/hw/ppc/pnv_occ.h+54 -181 reply
9/15ppc/pnv: add a OCC model for POWER9hw/ppc/pnv.c hw/ppc/pnv_occ.c include/hw/ppc/pnv.h +2 more+91 -01 reply
10/15ppc/pnv: extend XSCOM core support for POWER9hw/ppc/pnv_core.c include/hw/ppc/pnv_core.h+89 -131 reply
11/15ppc/pnv: POWER9 XSCOM quad supporthw/ppc/pnv.c hw/ppc/pnv_core.c include/hw/ppc/pnv.h +2 more+146 -51 reply
12/15ppc/pnv: activate XSCOM tests for POWER9tests/pnv-xscom-test.c+0 -21 reply
13/15ppc/pnv: add more dummy XSCOM addresseshw/ppc/pnv_xscom.c+27 -61 reply
14/15ppc/pnv: add a "ibm, opal/power-mgt" device tree node on POWER9hw/ppc/pnv.c+15 -01 reply
15/15target/ppc: add HV support for POWER9target/ppc/translate_init.inc.c+2 -11 reply

Reviews trailers per patch

2 of 15 patches have a Reviewed-by or Acked-by.

PatchDavid Gibson
1/15
2/15
3/15
4/15R-b
5/15
6/15
7/15
8/15R-b
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/15] ppc: add POWER9 support to the PowerNV platform

Hello,

Here is the second round of the patchset adding support for the POWER9 processor to the PowerNV machine. It includes POWER9 models for the PSI host bridge, the LPC controller, and a minimalist OCC, some extensions of the CPU core model to support POWER9 XSCOM addresses and a new PnvQuad model controlling the power management state of group of four cores on a POWER9 processor.

It should bring the POWER9 PowerNV platform to the same level as POWER8, that is without PHBs.

A new skiboot image is not provided yet because I would like first to have a tagged version of skiboot including the recent changes removing support for DD1. Will come later.

Hopefully, this is good enough for QEMU 4.0.

Thanks,

C.

Changes in v2 :

- introduced Pnv8Psi (XICS) and Pnv9Psi (XIVE) models
- wrote a commit log for the changes in the LPC register ranges
- added a 'dt_isa_nodename' to the chip
- added new attributes to define XSCOM operations per CPU family and a PSI IRQ number in the OCC class model
- added a new attribute to define XSCOM operations per CPU family in the CPU core class model

Changes in v1 (since PnvXive was last sent) :

- fixed compilation on clang (forward declarations)

- simplified the hardwiring of the Physical CAM line. removed the 'hw-cam' property.
- removed 'hwaddr offset' from the get_tctx() XiveRouter handler. It was a misunderstanding of the PC_THREAD_EN_REGx registers.
- changed the CPU machine_data presenter type to 'Object *' to accept XiveTCTX
- introduced a new dt_populate() operation to the chip model
- introduced a new pic_print_info() operation to the chip model
- removed 'chip_id' from PnvXive.
- removed 'nr_irqs' and 'nr_ends' from PnvXive. Values are now calculated from the VST settings done by FW.
- removed 'type' field from the XiveVstInfo struct describing the VSTs
- simplified pnv_xive_get_ic() grabbing a remote IC
- introduced a pnv_xive_vst_size() helper computing the size of a VST table, direct or indirect. Used to computed the number of virtual structures entries provisioned by FW.
- reworked pnv_xive_vst_addr_*() helpers. Fixed a bug when multiple pages are in use.
- took into account the word_number when doing stores of the virtual structures.
- the IPI and the END sub memory regions of the VC BAR are now resized and mapped when the EDT is configured, depending on how the VC region was segmented.
- the XiveSource and the XiveENDSource memory regions are now resized and mapped when the VST are configured, depending on how much virtual structures entries were provisioned by FW.
- removed PC_GCONF_CHIPID_OVR handling. Was for debug according to HW designers. xive->chip->chip_id is now used as the block id when needed.
- reworked pic_print_info() to use the number of virtual structures entries provisioned by FW.

What has not changed (since PnvXive was sent) :

- GETFIELD/SETFIELD macros. It would break the compatibility with skiboot in the register definitions. Still needs some thinking to find a common ground. P10 material for QEMU and skiboot probably.
- The HW interface of XIVE is still bound to the register array. P10 support will determine which is the best approach.

Cédric Le Goater (15):
ppc/pnv: add a PSI bridge class model
ppc/pnv: add a PSI bridge model for POWER9
ppc/pnv: lpc: fix OPB address ranges
ppc/pnv: add a LPC Controller class model
ppc/pnv: add a 'dt_isa_nodename' to the chip ppc/pnv: add a LPC Controller model for POWER9 ppc/pnv: add SerIRQ routing registers
ppc/pnv: add a OCC model class
ppc/pnv: add a OCC model for POWER9
ppc/pnv: extend XSCOM core support for POWER9 ppc/pnv: POWER9 XSCOM quad support
ppc/pnv: activate XSCOM tests for POWER9
ppc/pnv: add more dummy XSCOM addresses
ppc/pnv: add a "ibm,opal/power-mgt" device tree node on POWER9 target/ppc: add HV support for POWER9

 include/hw/ppc/pnv.h            |  19 +-
 include/hw/ppc/pnv_core.h       |  12 +
 include/hw/ppc/pnv_lpc.h        |  26 ++
 include/hw/ppc/pnv_occ.h        |  17 ++
 include/hw/ppc/pnv_psi.h        |  59 ++++-
 include/hw/ppc/pnv_xscom.h      |  18 +-
 hw/ppc/pnv.c                    | 134 +++++++++--
 hw/ppc/pnv_core.c               | 187 ++++++++++++++-
 hw/ppc/pnv_lpc.c                | 306 +++++++++++++++++++++---
 hw/ppc/pnv_occ.c                | 127 ++++++++--
 hw/ppc/pnv_psi.c                | 404 ++++++++++++++++++++++++++++++--
 hw/ppc/pnv_xscom.c              |  33 ++-
 target/ppc/translate_init.inc.c |   3 +-
 tests/pnv-xscom-test.c          |   2 -
 14 files changed, 1231 insertions(+), 116 deletions(-)
Signature · 1 line
2.20.1