RFC hw/block: better reporting on pflash backing file mismatch
Get series with b4
b4 am [email protected]Versions newest first
- v6 RFC Latest4 patches 7 repliesIn review
Changes in v6 from the cover letter
* Split padding into its own patch.
* Delete "It should be padded to a multiple of the flash block size." comment. Happy to put it back if you can enlighten me about its purpose.
* Improve both commit messages.
* New fixup patches to pflash_cfi02.c.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | hw/block: better reporting on pflash backing file mismatchhw/ | +22 | 2 replies | |
| 2/4 | hw/block: Pad undersized read-only images with 0xFFhw/ | +18 | 5 replies | |
| 3/4 | fixup! hw/block: better reporting on pflash backing file mismatchhw/ | +22 | 0 replies | |
| 4/4 | fixup! hw/block: Pad undersized read-only images with 0xFFhw/ | +17 | 0 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Laszlo Ersek |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch
This is Alex's "[PATCH v5] hw/block: better reporting on pflash backing file mismatch" with the padding split off into its own patch, and both resulting patches applied to pflash_cfi02.c. I downgraded it to RFC for two reasons:
1. I think the padding patches should not be applied. I'll reply to PATCH 2 to explain why.
2. I left the update of pflash_cfi02.c as separate fixup patches, so we can easily ignore them while we discuss 1.
v6:
* Split padding into its own patch.
* Delete "It should be padded to a multiple of the flash block size." comment. Happy to put it back if you can enlighten me about its purpose.
* Improve both commit messages.
* New fixup patches to pflash_cfi02.c.
Alex Bennée (2):
hw/block: better reporting on pflash backing file mismatch hw/block: Pad undersized read-only images with 0xFF
Markus Armbruster (2):
fixup! hw/block: better reporting on pflash backing file mismatch fixup! hw/block: Pad undersized read-only images with 0xFF
hw/block/pflash_cfi01.c | 41 ++++++++++++++++++++++++++++++++++------- hw/block/pflash_cfi02.c | 40 ++++++++++++++++++++++++++++++++++------ 2 files changed, 68 insertions(+), 13 deletions(-)
Signature · 1 line
2.17.2