Skip to content

file-posix: Make auto-read-only dynamic

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 12 repliesIn review
  2. v18 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Added test for and fixed snapshot=on,read-only=on regression [Berto]
- Added test for and fixed commit regression [Peter]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10tests/virtio-blk-test: Disable auto-read-onlytests/virtio-blk-test.c+1 -11 reply
2/10qemu-iotests: commit to backing file with auto-read-onlytests/qemu-iotests/232 tests/qemu-iotests/232.out+51 -01 reply
3/10block: Avoid useless local_errblock.c+1 -32 replies
4/10block: Make permission changes in reopen less wrongblock.c+24 -110 replies
5/10file-posix: Fix bdrv_open_flags() for snapshot=onblock.c tests/qemu-iotests/051 tests/qemu-iotests/051.out +1 more+25 -70 replies
6/10file-posix: Factor out raw_reconfigure_getfd()block/file-posix.c+62 -450 replies
7/10file-posix: Store BDRVRawState.reopen_state during reopenblock/file-posix.c+10 -00 replies
8/10file-posix: Lock new fd in raw_reopen_prepare()block/file-posix.c+16 -110 replies
9/10file-posix: Prepare permission code for fd switchingblock/file-posix.c+85 -110 replies
10/10file-posix: Make auto-read-only dynamicblock/file-posix.c tests/qemu-iotests/232.out+23 -257 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/10R-b
2/10R-b
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/10] file-posix: Make auto-read-only dynamic

We introduced the auto-read-only option to fix the problem that block jobs that reopen a backing file read-write don't work any more when all nodes are created individually with -blockdev. The reason is that bs->file of these backing files doesn't inherit the read-only option from the format layer node any more if it's created separately.

The way auto-read-only was designed to fix this is that it just always opens the file node read-write if it can, so reopening the format layer node is enough to make the backing file writable when necessary.

This works in principle, but not when libvirt uses sVirt: Then QEMU doesn't even have the permissions to open the image file read-write until libvirt performs an operation where write access is needed.

This series changes auto-read-only so that it works dynamically and automatically reopens the file read-only or read-write depending on the permissions that users attached to the node requested.

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1685989

v2:
- Added test for and fixed snapshot=on,read-only=on regression [Berto]
- Added test for and fixed commit regression [Peter]

Kevin Wolf (10):
tests/virtio-blk-test: Disable auto-read-only
qemu-iotests: commit to backing file with auto-read-only
block: Avoid useless local_err
block: Make permission changes in reopen less wrong
file-posix: Fix bdrv_open_flags() for snapshot=on
file-posix: Factor out raw_reconfigure_getfd()
file-posix: Store BDRVRawState.reopen_state during reopen
file-posix: Lock new fd in raw_reopen_prepare()
file-posix: Prepare permission code for fd switching
file-posix: Make auto-read-only dynamic

 block.c                       |  46 ++++---
 block/file-posix.c            | 248 ++++++++++++++++++++++++----------
 tests/virtio-blk-test.c       |   2 +-
 tests/qemu-iotests/051        |   7 +
 tests/qemu-iotests/051.out    |   9 ++
 tests/qemu-iotests/051.pc.out |   9 ++
 tests/qemu-iotests/232        |  31 +++++
 tests/qemu-iotests/232.out    |  32 ++++-
 8 files changed, 284 insertions(+), 100 deletions(-)
Signature · 1 line
2.20.1