Skip to content

block: enable multi-page bvec for passthrough IO

Ming Lei linux-block xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 2 repliesIn review
  2. v210 patches 2 repliesSuperseded
  3. v16 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- fix build warning on patch 1 and 7, only the two patches are changed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10block: pass page to xen_biovec_phys_mergeableblock/blk.h drivers/xen/biomerge.c include/xen/xen.h+7 -40 replies
2/10block: avoid to break XEN by multi-page bvecblock/bio.c+2 -00 replies
3/10block: don't merge adjacent bvecs to one segment in bio blk_queue_splitblock/blk-merge.c+0 -170 replies
4/10block: cleanup bio_add_pc_pageblock/bio.c+7 -70 replies
5/10block: check if page is mergeable in one helperblock/bio.c+24 -140 replies
6/10block: put the same page when adding it to bioblock/bio.c include/linux/bio.h+19 -120 replies
7/10block: enable multi-page bvec for passthrough IOblock/bio.c+31 -290 replies
8/10block: remove argument of 'request_queue' from __blk_bvec_map_sgblock/blk-merge.c+3 -30 replies
9/10block: reuse __blk_bvec_map_sg() for mapping page sized bvecblock/blk-merge.c+9 -110 replies
10/10block: don't check if adjacent bvecs in one bio can be mergeableblock/blk-merge.c+42 -270 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigBoris Ostrovsky
1/10R-b R-b
2/10
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/10] block: enable multi-page bvec for passthrough IO

Hi,

Now the whole IO stack is capable of handling multi-page bvec, and it has been enabled in the normal FS IO path. However, it isn't done for passthrough IO.

Without enabling multi-bvec for passthough IO, we won't go ahead for optimizing related IO paths, such as bvec merging, bio_add_pc_page simplification.

This patch enables multi-page bvec for passthrough IO. Turns out bio_add_pc_page() is simpliefied a lot, especially the physical segment number of passthrough bio is always same with bio.bi_vcnt. Also the bvec merging inside bio is killed.

blktests(block/029) is added for covering passthough IO path, and this patchset does pass the new block/029 test.

V3:
- fix build warning on patch 1 and 7, only the two patches are changed

V2:
- add new patch of 'block: avoid to break XEN by multi-page bvec'
- add one new patch to cleanup bio_add_pc_page()
- add another two new patches for cleanup of mapping bvec to sg
- most of others are patch style changes

Ming Lei (10):
block: pass page to xen_biovec_phys_mergeable
block: avoid to break XEN by multi-page bvec
block: don't merge adjacent bvecs to one segment in bio
blk_queue_split
block: cleanup bio_add_pc_page
block: check if page is mergeable in one helper
block: put the same page when adding it to bio
block: enable multi-page bvec for passthrough IO
block: remove argument of 'request_queue' from __blk_bvec_map_sg
block: reuse __blk_bvec_map_sg() for mapping page sized bvec
block: don't check if adjacent bvecs in one bio can be mergeable

 block/bio.c            | 134 ++++++++++++++++++++++++++++---------------------
 block/blk-merge.c      | 106 +++++++++++++++++++-------------------
 block/blk.h            |   2 +-
 drivers/xen/biomerge.c |   5 +-
 include/linux/bio.h    |   3 ++
 include/xen/xen.h      |   4 +-
 6 files changed, 137 insertions(+), 117 deletions(-)
Signature · 1 line
2.9.5