Skip to content

sound/hda/hdac_stream: Avoid NULL pointer dereference

Mariusz Ceier alsa-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1sound/hda/hdac_stream: Avoid NULL pointer dereferencesound/hda/hdac_stream.c+4 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] sound/hda/hdac_stream: Avoid NULL pointer dereference

Seems like commit 9b6f7e7a296e17990aae298c809b001e99ddd151 introduced NULL pointer dereference for ca0132 codec.
When ca0132 loads firmware, snd_hdac_stream_start is called with azx_dev->substream being NULL.

This patch calls snd_hdac_get_stream_stripe_ctl only when azx_dev->substream is not NULL. Even if I'm not sure if this is correct, since it might be that ca0132 codec does something wrong, with this change NULL pointer dereference doesn't happen and ca0132 works again on my system with Recon3Di.

Mariusz Ceier (1):
sound/hda/hdac_stream: Avoid NULL pointer dereference

 sound/hda/hdac_stream.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.21.0