auxdisplay: Introduce charlcd_free()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 9 repliesIn review
- v14 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | auxdisplay: hd44780: Fix memory leak on ->remove()drivers/ | +2 | 1 reply | |
| 2/5 | auxdisplay: charlcd: Move to_priv() to charlcd namespacedrivers/ | +13 | 2 replies | |
| 3/5 | auxdisplay: charlcd: Introduce charlcd_free() helperdrivers/ include/ | +7 | 1 reply | |
| 4/5 | auxdisplay: panel: Convert to use charlcd_free()drivers/ | +2 | 1 reply | |
| 5/5 | auxdisplay: hd44780: Convert to use charlcd_free()drivers/ | +2 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Geert Uytterhoeven |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] auxdisplay: Introduce charlcd_free()
I have found a memory leak in hd44780 and it becomes that we have no counterpart to charlcd_alloc() that developers can easily miss.
So, this series fixes a leak and introduces the charlcd_free().
In v2:
- add new patch to convert to_priv() to charlcd_to_priv()
- address Geert's comment what should be freed
Cc Geert Uytterhoeven <[email protected]>
Andy Shevchenko (5):
auxdisplay: hd44780: Fix memory leak on ->remove()
auxdisplay: charlcd: Move to_priv() to charlcd namespace
auxdisplay: charlcd: Introduce charlcd_free() helper
auxdisplay: panel: Convert to use charlcd_free()
auxdisplay: hd44780: Convert to use charlcd_free()
drivers/auxdisplay/charlcd.c | 32 +++++++++++++++++++------------- drivers/auxdisplay/hd44780.c | 4 +++- drivers/auxdisplay/panel.c | 4 ++-- include/misc/charlcd.h | 1 + 4 files changed, 25 insertions(+), 16 deletions(-)
Signature · 1 line
2.20.1