Skip to content

auxdisplay: Introduce charlcd_free()

Andy Shevchenko lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 9 repliesIn review
  2. v14 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5auxdisplay: hd44780: Fix memory leak on ->remove()drivers/auxdisplay/hd44780.c+2 -01 reply
2/5auxdisplay: charlcd: Move to_priv() to charlcd namespacedrivers/auxdisplay/charlcd.c+13 -132 replies
3/5auxdisplay: charlcd: Introduce charlcd_free() helperdrivers/auxdisplay/charlcd.c include/misc/charlcd.h+7 -01 reply
4/5auxdisplay: panel: Convert to use charlcd_free()drivers/auxdisplay/panel.c+2 -21 reply
5/5auxdisplay: hd44780: Convert to use charlcd_free()drivers/auxdisplay/hd44780.c+2 -21 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchGeert Uytterhoeven
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] auxdisplay: Introduce charlcd_free()

I have found a memory leak in hd44780 and it becomes that we have no counterpart to charlcd_alloc() that developers can easily miss.

So, this series fixes a leak and introduces the charlcd_free().

In v2:
- add new patch to convert to_priv() to charlcd_to_priv()
- address Geert's comment what should be freed

Cc Geert Uytterhoeven <[email protected]>

Andy Shevchenko (5):
auxdisplay: hd44780: Fix memory leak on ->remove()
auxdisplay: charlcd: Move to_priv() to charlcd namespace
auxdisplay: charlcd: Introduce charlcd_free() helper
auxdisplay: panel: Convert to use charlcd_free()
auxdisplay: hd44780: Convert to use charlcd_free()

 drivers/auxdisplay/charlcd.c | 32 +++++++++++++++++++-------------
 drivers/auxdisplay/hd44780.c |  4 +++-
 drivers/auxdisplay/panel.c   |  4 ++--
 include/misc/charlcd.h       |  1 +
 4 files changed, 25 insertions(+), 16 deletions(-)
Signature · 1 line
2.20.1