Skip to content

Various modifications and fixes toward KS 1.0

Yordan Karadzhov linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12kernel-shark: Fix a spelling typo in KsMainWindow classkernel-shark/src/KsMainWindow.cpp kernel-shark/src/KsMainWindow.hpp+8 -80 replies
2/12kernel-shark: Fix a typo in an error message from libkshark-configiokernel-shark/src/libkshark-configio.c+1 -10 replies
3/12kernel-shark: Make KsSession::importFromFile return status flagkernel-shark/src/KsSession.cpp kernel-shark/src/KsSession.hpp+11 -50 replies
4/12kernel-shark: Error message if the opening of the session file failskernel-shark/src/KsMainWindow.cpp+10 -11 reply
5/12kernel-shark: Disables automatic quotation for errors in KsMainWindowkernel-shark/src/KsMainWindow.cpp+1 -10 replies
6/12kernel-shark: Load Last Session from command linekernel-shark/src/kernelshark.cpp+8 -13 replies
7/12kernel-shark: Add destructor for KsGLWidgetkernel-shark/src/KsGLWidget.cpp kernel-shark/src/KsGLWidget.hpp+8 -00 replies
8/12kernel-shark: Fix memory leak in KsPlotget::getTaskColorTable()kernel-shark/src/KsPlotTools.cpp+2 -00 replies
9/12kernel-shark: Avoid the unnecessary calls of KsGLWidget::loadColors()kernel-shark/src/KsGLWidget.cpp+0 -20 replies
10/12kernel-shark: Avoid 0/0 spliter ratio in KsSessionkernel-shark/src/KsSession.cpp+5 -10 replies
11/12kernel-shark: In model, handle the case when all bins are emptykernel-shark/src/libkshark-model.c+5 -41 reply
12/12kernel-shark: In collections, handle the case when the data is smallkernel-shark/src/libkshark-collection.c+12 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] Various modifications and fixes toward KS 1.0

Most of the modifications are minor except patch [PATCH 08/12] which fixes a major memory leak.

Yordan Karadzhov (12):
kernel-shark: Fix a spelling typo in KsMainWindow class
kernel-shark: Fix a typo in an error message from libkshark-configio
kernel-shark: Make KsSession::importFromFile return status flag
kernel-shark: Error message if the opening of the session file fails
kernel-shark: Disables automatic quotation for errors in KsMainWindow
kernel-shark: Load Last Session from command line
kernel-shark: Add destructor for KsGLWidget
kernel-shark: Fix memory leak in KsPlotget::getTaskColorTable()
kernel-shark: Avoid the unnecessary calls of KsGLWidget::loadColors()
kernel-shark: Avoid 0/0 spliter ratio in KsSession
kernel-shark: In model, handle the case when all bins are empty
kernel-shark: In collections, handle the case when the data is small

 kernel-shark/src/KsGLWidget.cpp         |  8 ++++++--
 kernel-shark/src/KsGLWidget.hpp         |  2 ++
 kernel-shark/src/KsMainWindow.cpp       | 25 +++++++++++++++++--------
 kernel-shark/src/KsMainWindow.hpp       |  4 ++--
 kernel-shark/src/KsPlotTools.cpp        |  2 ++
 kernel-shark/src/KsSession.cpp          | 20 +++++++++++++++-----
 kernel-shark/src/KsSession.hpp          |  2 +-
 kernel-shark/src/kernelshark.cpp        |  9 ++++++++-
 kernel-shark/src/libkshark-collection.c | 20 ++++++++++++--------
 kernel-shark/src/libkshark-configio.c   |  2 +-
 kernel-shark/src/libkshark-model.c      |  9 +++++----
 11 files changed, 71 insertions(+), 32 deletions(-)
Signature · 1 line
2.19.1