Skip to content

MTD defconfigs/Kconfigs/Makefiles heavy cleanup

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20190317193458.GQ8732@bill-the-cat

Versions newest first

  1. v4 Latest1 of 25 patches 0 repliesNew

1 of 25 patches is in this archive. The cover letter announces 25.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
12/25mtd: ensure MTD and NOR drivers are compiled with ENV_IS_IN_FLASH+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [U-Boot] [PATCH v4 00/25] MTD defconfigs/Kconfigs/Makefiles heavy cleanup
Quoted 60 lines · Miquel Raynal

Jagan,

Miquel Raynal <[email protected]> wrote on Wed, 6 Mar 2019 10:21:44 +0100:

Quoted 46 lines

Hi Jagan,

Miquel Raynal <[email protected]> wrote on Wed, 20 Feb 2019 08:08:58 +0100:

Quoted 41 lines

Hi Vignesh,

Vignesh R <[email protected]> wrote on Wed, 20 Feb 2019 10:50:18 +0530:

Quoted 36 lines

Hi Jagan,

Quoted 21 lines · Miquel Raynal

Hello,

During my last project about SPI-NAND support in U-Boot, I discovered when modifying Makefiles a confusing organization where:
* Sub-directories/files are compiled from the root Makefile
* Commands are at the root of everything

I sent a fist series a few weeks ago to move Makefile entries in their respective directories (which needed to be reworked). Since then, I have been working on clarifying all this for the MTD subsystem and here are the main points of such re-organization:
* Rename CONFIG_MTD into CONFIG_DM_MTD to reserve CONFIG_MTD to what is called today CONFIG_MTD_DEVICE.
* Fix build dependencies in defconfigs, like: "UBI and NAND depend on MTD".
* Fix the Kconfig files to reflect these dependencies (as defconfigs have been updated, nothing should break).
* Simplify the Makefiles: compiling the drivers/mtd/nand/raw/ sub-directory should just depend on MTD being compiled and the NAND core as well, there is absolutely no logic to make it depend on CMD_NAND.

Quoted 7 lines

New green Travis CI build for the third version of this series:
https://travis-ci.org/miquelraynal/u-boot/builds/463486099
There are three Sandbox tests that are failing, they have not been break by this series. The following Travis test has been done on the commit on which has been based the series and shows the same errors:
https://travis-ci.org/miquelraynal/u-boot/builds/463593006

I would like to revive this series. With some rebasing, this series should still apply as is.

Jagan, did you get a chance to look into this series? Any comments?

Quoted 8 lines
Quoted 5 lines

Thanks for reviving the series, actually I was sure it was merged by that time as AFAIR there was no more opposition to it.

Jagan, I see it is still marked 'new' on patchwork and assigned to you, would you mind applying it?

Gentle 3-month-later ping. Jagan, please consider this series.

Quoted 6 lines

Almost two more weeks passed, I think I deserved some feedback now.

This series IMHO improves the MTD layer, it passed Travis CI and has been ready for months. It is very likely that some rebase is needed but I am not willing to spend more time on something you will just throw away for no reason.

Jagan, can you please comment? This sounds like something we should pick up in the next merge window, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190317/19ada913/attachment.sig>