Skip to content

xen: simplify suspend/resume handling

Juergen Gross xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 1 replyIn review
  2. v36 patches 6 repliesSuperseded
  3. v26 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches30 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6xen/sched: call cpu_disable_scheduler() via cpu notifierxen/arch/arm/smpboot.c xen/arch/x86/smpboot.c xen/common/schedule.c+29 -121 reply
2/6xen: add helper for calling notifier_call_chain() to common/cpu.cxen/common/cpu.c+26 -300 replies
3/6xen: add new cpu notifier action CPU_RESUME_FAILEDxen/common/cpu.c xen/include/xen/cpu.h+23 -110 replies
4/6xen: don't free percpu areas during suspendxen/arch/x86/percpu.c+2 -10 replies
5/6xen/cpupool: simplify suspend/resume handlingxen/common/cpupool.c xen/include/xen/sched-if.h+52 -800 replies
6/6xen/sched: don't disable scheduler on cpus during suspendxen/common/schedule.c+52 -1090 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDario FaggioliJan BeulichGeorge DunlapJulien Grall
1/6R-b A-b
2/6R-b A-b
3/6R-b R-b
4/6R-b A-b
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/6] xen: simplify suspend/resume handling

Especially in the scheduler area (schedule.c, cpupool.c) there is a rather complex handling involved when doing suspend and resume.

This can be simplified a lot by not performing a complete cpu down and up cycle for the non-boot cpus, but keeping the pure software related state and freeing it only in case a cpu didn't come up again during resume.

In summary not only the complexity can be reduced, but the failure tolerance will be even better with this series: With a dedicated hook for failing cpus when resuming it is now possible to survive e.g. a cpupool being left without any cpu after resume by moving its domains to cpupool0.

Juergen Gross (6):
xen/sched: call cpu_disable_scheduler() via cpu notifier
xen: add helper for calling notifier_call_chain() to common/cpu.c
xen: add new cpu notifier action CPU_RESUME_FAILED
xen: don't free percpu areas during suspend xen/cpupool: simplify suspend/resume handling xen/sched: don't disable scheduler on cpus during suspend

 xen/arch/arm/smpboot.c     |   2 -
 xen/arch/x86/percpu.c      |   3 +-
 xen/arch/x86/smpboot.c     |   3 -
 xen/common/cpu.c           |  61 +++++++-------
 xen/common/cpupool.c       | 131 ++++++++++++------------------
 xen/common/schedule.c      | 197 +++++++++++++++++++--------------------------
 xen/include/xen/cpu.h      |  29 ++++---
 xen/include/xen/sched-if.h |   1 -
 8 files changed, 184 insertions(+), 243 deletions(-)
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel