Skip to content

RFC perf/x86: Add msr probe interface

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8perf/x86: Add msr probe interfacearch/x86/events/Makefile arch/x86/events/probe.c arch/x86/events/probe.h+59 -13 replies
2/8perf/x86/msr: Use new probe functionarch/x86/events/msr.c+35 -410 replies
3/8perf/x86/cstate: Use new probe functionarch/x86/events/intel/cstate.c+46 -460 replies
4/8perf/x86/rapl: Use new msr detection interfacearch/x86/events/intel/rapl.c+149 -00 replies
5/8perf/x86/rapl: Get rapl_cntr_mask from new probe frameworkarch/x86/events/intel/rapl.c+2 -370 replies
6/8perf/x86/rapl: Get msr values from new probe frameworkarch/x86/events/intel/rapl.c+11 -420 replies
7/8perf/x86/rapl: Get attributes from new probe frameworkarch/x86/events/intel/rapl.c+1 -890 replies
8/8perf/x86/rapl: Get quirk state from new probe frameworkarch/x86/events/intel/rapl.c+3 -750 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/8] perf/x86: Add msr probe interface

hi,
following up on [1], this patchset factors out the MSR probe code and use it in msr,cstate* and rapl PMUs.

The functionality stays the same with one exception:
the event is not exported if the rdmsr return zero on event's msr.

I still need to run tests on other models and verify rapl model table properly, but I'd like to ask it something like this would be acceptable.

Also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/msr

thanks,
jirka

[1] https://lore.kernel.org/lkml/20190301114250.GA23459@krava/
---
Jiri Olsa (8):
perf/x86: Add msr probe interface
perf/x86/msr: Use new probe function perf/x86/cstate: Use new probe function perf/x86/rapl: Use new msr detection interface perf/x86/rapl: Get rapl_cntr_mask from new probe framework perf/x86/rapl: Get msr values from new probe framework perf/x86/rapl: Get attributes from new probe framework perf/x86/rapl: Get quirk state from new probe framework

 arch/x86/events/Makefile       |   2 +-
 arch/x86/events/intel/cstate.c |  92 +++++++++++++++++++++++------------------------
 arch/x86/events/intel/rapl.c   | 341 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------
 arch/x86/events/msr.c          |  76 ++++++++++++++++++---------------------
 arch/x86/events/probe.c        |  36 +++++++++++++++++++
 arch/x86/events/probe.h        |  22 ++++++++++++
 6 files changed, 272 insertions(+), 297 deletions(-)
 create mode 100644 arch/x86/events/probe.c
 create mode 100644 arch/x86/events/probe.h