Skip to content

RFC Rework V4L2 fwnode parsing; add defaults and avoid iteration

Sakari Ailus linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8v4l2-async: Use endpoint node, not device node, for fwnode matchdrivers/media/platform/am437x/am437x-vpfe.c drivers/media/platform/atmel/atmel-isc.c drivers/media/platform/atmel/atmel-isi.c +13 more+51 -432 replies
1/8v4l2-async: Use endpoint node, not device node, for fwnode matchdrivers/media/platform/am437x/am437x-vpfe.c drivers/media/platform/atmel/atmel-isc.c drivers/media/platform/atmel/atmel-isi.c +13 more+53 -421 reply
2/8v4l2-async: Add v4l2_async_notifier_add_fwnode_remote_subdevdrivers/media/v4l2-core/v4l2-async.c include/media/v4l2-async.h+47 -02 replies
2/8v4l2-async: Add v4l2_async_notifier_add_fwnode_remote_subdevdrivers/media/v4l2-core/v4l2-async.c include/media/v4l2-async.h+46 -00 replies
3/8v4l2-fwnode: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/media/v4l2-core/v4l2-fwnode.c+2 -101 reply
4/8omap3isp: Rework OF endpoint parsingdrivers/media/platform/omap3isp/isp.c+200 -1342 replies
5/8v4l2-async: Safely clean up an uninitialised notifierdrivers/media/v4l2-core/v4l2-async.c+1 -10 replies
6/8ipu3-cio2: Clean up notifier's subdev list if parsing endpoints failsdrivers/media/pci/intel/ipu3/ipu3-cio2.c+6 -20 replies
7/8ipu3-cio2: Proceed with notifier init even if there are no subdevsdrivers/media/pci/intel/ipu3/ipu3-cio2.c+5 -50 replies
8/8ipu3-cio2: Parse information from firmware without using callbacksdrivers/media/pci/intel/ipu3/ipu3-cio2.c+50 -430 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/8] Rework V4L2 fwnode parsing; add defaults and avoid iteration

Hi folks,

This patchset reworks V4L2 fwnode endpoint parsing. It enables the use of endpoint configuration defaults that is available sensors and other drivers that only use a single endpoint. Well, the functionality was available already but no driver used it likely because of two reasons:
lack of any examples in a non-trivial problem area as well as lack of a needed functionality to obtain through non-iterative means in the fwnode graph API. Also the fwnode framework did not provide the most convenient APIs to perform this for drivers.

Conversion from the iterative API is done for the omap3isp and ipu3-cio2 drivers. A downside here is that this adds code: what used to be done in the framework in a one-size-fits-all fashion is now the responsibility of the driver. The benefits (default settings and simplicity of the implementation from driver's point of view) are not really achievable without some of that.

Also baked in the set is matching devices with endpoints by endpoint node rather than the device's node. This allows finding out more information than just the device bound (i.e. the port --- or endpoint --- through which it was bound). Compatibility support is provided for existing drivers by setting the fwnode to be matched based on the available endpoints. Drivers that use the async non-notifier API and have multiple ports will likely need special care and this is right now missing from the set, hence this is RFC for now.

The set depends on a few other patches. They all can be found here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=fwnode-linear>

Sakari Ailus (8):
v4l2-async: Use endpoint node, not device node, for fwnode match
v4l2-async: Add v4l2_async_notifier_add_fwnode_remote_subdev
v4l2-fwnode: Use v4l2_async_notifier_add_fwnode_remote_subdev
omap3isp: Rework OF endpoint parsing
v4l2-async: Safely clean up an uninitialised notifier
ipu3-cio2: Clean up notifier's subdev list if parsing endpoints fails
ipu3-cio2: Proceed with notifier init even if there are no subdevs
ipu3-cio2: Parse information from firmware without using callbacks

 drivers/media/pci/intel/ipu3/ipu3-cio2.c      |  97 ++++----
 drivers/media/platform/am437x/am437x-vpfe.c   |   2 +-
 drivers/media/platform/atmel/atmel-isc.c      |   2 +-
 drivers/media/platform/atmel/atmel-isi.c      |   2 +-
 drivers/media/platform/cadence/cdns-csi2rx.c  |   2 +-
 drivers/media/platform/davinci/vpif_capture.c |  14 +-
 drivers/media/platform/exynos4-is/media-dev.c |  14 +-
 drivers/media/platform/omap3isp/isp.c         | 334 +++++++++++++++-----------
 drivers/media/platform/pxa_camera.c           |   2 +-
 drivers/media/platform/qcom/camss/camss.c     |  10 +-
 drivers/media/platform/rcar_drif.c            |   3 +-
 drivers/media/platform/renesas-ceu.c          |   2 +-
 drivers/media/platform/stm32/stm32-dcmi.c     |   2 +-
 drivers/media/platform/ti-vpe/cal.c           |   2 +-
 drivers/media/platform/xilinx/xilinx-vipp.c   |  13 +-
 drivers/media/v4l2-core/v4l2-async.c          |  33 ++-
 drivers/media/v4l2-core/v4l2-fwnode.c         |  12 +-
 drivers/staging/media/soc_camera/soc_camera.c |  14 +-
 include/media/v4l2-async.h                    |  24 ++
 19 files changed, 354 insertions(+), 230 deletions(-)
Signature · 1 line
2.11.0