Skip to content

perf: Add Icelake support

[email protected] lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest23 patches 8 repliesIn review
  2. v323 patches 9 repliesSuperseded
  3. v223 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v122 patches16 repliesSuperseded

Changes in v4 from the cover letter

- Keep the old names for GPRs. Rename PERF_REG_X86_MAX to PERF_REG_X86_XMM_MAX
- Remove unnecessary REG_RESERVED
- Add REG_NOSUPPORT for 32bit

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23perf/x86: Support outputting XMM registersarch/x86/events/core.c arch/x86/events/perf_event.h arch/x86/include/asm/perf_event.h +2 more+59 -84 replies
2/23perf/x86/intel: Extract memory code PEBS parser for reusearch/x86/events/intel/ds.c+34 -290 replies
3/23perf/x86/intel/ds: Extract code of event update in short periodarch/x86/events/intel/ds.c+21 -130 replies
4/23perf/x86/intel: Support adaptive PEBSv4arch/x86/events/intel/core.c arch/x86/events/intel/ds.c arch/x86/events/intel/lbr.c +3 more+429 -203 replies
5/23perf/x86/lbr: Avoid reading the LBRs when adaptive PEBS handles themarch/x86/events/intel/lbr.c arch/x86/events/perf_event.h+13 -10 replies
6/23perf/x86: Support constraint rangesarch/x86/events/intel/core.c arch/x86/events/intel/ds.c arch/x86/events/perf_event.h+38 -80 replies
7/23perf/x86/intel: Add Icelake supportarch/x86/events/intel/core.c arch/x86/events/intel/ds.c arch/x86/events/perf_event.h +2 more+140 -40 replies
8/23perf/x86/intel/cstate: Add Icelake supportarch/x86/events/intel/cstate.c+2 -00 replies
9/23perf/x86/intel/rapl: Add Icelake supportarch/x86/events/intel/rapl.c+2 -00 replies
10/23perf/x86/msr: Add Icelake supportarch/x86/events/msr.c+1 -00 replies
11/23perf/x86/intel/uncore: Add Intel Icelake uncore supportarch/x86/events/intel/uncore.c arch/x86/events/intel/uncore.h arch/x86/events/intel/uncore_snb.c+98 -00 replies
12/23perf/core: Support a REMOVE transactionarch/x86/events/core.c include/linux/perf_event.h kernel/events/core.c+7 -20 replies
13/23perf/x86/intel: Basic support for metrics countersarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h +3 more+83 -110 replies
14/23perf/x86/intel: Support overflows on SLOTSarch/x86/events/intel/core.c+23 -00 replies
15/23perf/x86/intel: Support hardware TopDown metricsarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h +2 more+242 -110 replies
16/23perf/x86/intel: Set correct weight for topdown subevent countersarch/x86/events/intel/core.c+9 -00 replies
17/23perf/x86/intel: Export new top down events for Icelakearch/x86/events/intel/core.c+11 -00 replies
18/23perf/x86/intel: Disable sampling read slots and topdownarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h+24 -00 replies
19/23perf/x86/intel: Support CPUID 10.ECX to disable fixed countersarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h+28 -80 replies
20/23perf, tools: Add support for recording and printing XMM registerstools/arch/x86/include/uapi/asm/perf_regs.h tools/perf/arch/x86/include/perf_regs.h tools/perf/arch/x86/util/perf_regs.c +1 more+62 -30 replies
21/23perf, tools, stat: Support new per thread TopDown metricstools/perf/Documentation/perf-stat.txt tools/perf/builtin-stat.c tools/perf/util/stat-shadow.c +2 more+132 -20 replies
22/23perf, tools: Add documentation for topdown metricstools/perf/Documentation/topdown.txt+223 -00 replies
23/23perf vendor events intel: Add JSON files for Icelaketools/perf/pmu-events/arch/x86/icelake/cache.json tools/perf/pmu-events/arch/x86/icelake/floating-point.json tools/perf/pmu-events/arch/x86/icelake/frontend.json +5 more+1881 -00 replies

Reviews trailers per patch

None of the 23 patches has a Reviewed-by or Acked-by.

PatchAndi Kleen
1/23Originally-by
2/23
3/23
4/23Originally-by
5/23
6/23Originally-by
7/23Originally-by
8/23
9/23
10/23
11/23
12/23
13/23
14/23
15/23Originally-by
16/23
17/23
18/23
19/23
20/23
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 00/23] perf: Add Icelake support

From: Kan Liang <[email protected]>

The patch series intends to add Icelake support for Linux perf.

PATCH 1-18: Kernel patches to support Icelake.
- 1-5: Support adaptive PEBS feature
- 6-7: Enable core support with some new features, e.g. 8 generic counters, new event constraints, a new fixed counter.
- 8-11: Enable cstate, rapl, msr and uncore support on Icelake
- 12-18: Support hardware Metrics counters and SLOT fixed counter for Topdown events.
- 19: Support CPUID 10.ECX to disable fixed counters

PATCH 20-23: Perf tool patches to support XMM, Topdown and event list.

Changes since V3:
- Keep the old names for GPRs. Rename PERF_REG_X86_MAX to PERF_REG_X86_XMM_MAX
- Remove unnecessary REG_RESERVED
- Add REG_NOSUPPORT for 32bit

Changes since V2:
- Make the setup_pebs_sample_data() a function pointer argument
- Use cpuc->pebs_record_size unconditionally
- Add comments for EVENT_CONSTRAINT_RANGE
- Correct the Author of "perf/x86: Support constraint ranges"

Changes since V1:
- Avoid the interface changes for perf_reg_value() and perf_output_sample_regs().
- Remove the extra_regs in struct perf_sample_data.
- Add struct x86_perf_regs
- Add has_xmm_regs to indicate the specific platform which support XMM registers collection.
- Add check in x86_pmu_hw_config() to reject invalid config of regs_user and regs_intr.
- Rename intel_hsw_weight and intel_hsw_transaction
- Add missed inline for intel_get_tsx_transaction()
- Add new patch to extract code of event update in short period
- Code rebase on top of c634dc6bdede
- Rename @d to pebs_data_cfg
- Make pebs_update_adaptive_cfg readable
- Clear pebs_data_cfg and pebs_record_size for first PEBS in add
- Don't clear ICL_EVENTSEL_ADAPTIVE. Rely on MSR_PEBS_CFG settings
- Change PEBS record parsing order (bug fix)
- Support struct x86_perf_regs
- make get_pebs_status generic
- specific intel_pmu_drain_pebs_icl()
- Use cpuc->pebs_record_size to replace format_size
- Use 'size' to replace 'range_end' for constraint ranges
- Add x86_pmu.has_xmm_regs = true;
- Add more explanation in change log of REMOVE transaction
- Make perf_regs.h consistent between kernel and user space

Andi Kleen (11):
perf/x86/intel: Extract memory code PEBS parser for reuse perf/x86/lbr: Avoid reading the LBRs when adaptive PEBS handles them perf/core: Support a REMOVE transaction
perf/x86/intel: Basic support for metrics counters perf/x86/intel: Support overflows on SLOTS perf/x86/intel: Set correct weight for topdown subevent counters perf/x86/intel: Export new top down events for Icelake perf/x86/intel: Support CPUID 10.ECX to disable fixed counters perf, tools: Add support for recording and printing XMM registers perf, tools, stat: Support new per thread TopDown metrics perf, tools: Add documentation for topdown metrics

Kan Liang (11):
perf/x86: Support outputting XMM registers perf/x86/intel/ds: Extract code of event update in short period perf/x86/intel: Support adaptive PEBSv4 perf/x86/intel: Add Icelake support perf/x86/intel/cstate: Add Icelake support perf/x86/intel/rapl: Add Icelake support perf/x86/msr: Add Icelake support perf/x86/intel/uncore: Add Intel Icelake uncore support perf/x86/intel: Support hardware TopDown metrics perf/x86/intel: Disable sampling read slots and topdown perf vendor events intel: Add JSON files for Icelake

Peter Zijlstra (1):
perf/x86: Support constraint ranges

 arch/x86/events/core.c                        |  81 +-
 arch/x86/events/intel/core.c                  | 422 ++++++++-
 arch/x86/events/intel/cstate.c                |   2 +
 arch/x86/events/intel/ds.c                    | 496 ++++++++--
 arch/x86/events/intel/lbr.c                   |  35 +-
 arch/x86/events/intel/rapl.c                  |   2 +
 arch/x86/events/intel/uncore.c                |   6 +
 arch/x86/events/intel/uncore.h                |   1 +
 arch/x86/events/intel/uncore_snb.c            |  91 ++
 arch/x86/events/msr.c                         |   1 +
 arch/x86/events/perf_event.h                  |  93 +-
 arch/x86/include/asm/intel_ds.h               |   2 +-
 arch/x86/include/asm/msr-index.h              |   4 +
 arch/x86/include/asm/perf_event.h             |  79 +-
 arch/x86/include/uapi/asm/perf_regs.h         |  23 +-
 arch/x86/kernel/perf_regs.c                   |  27 +-
 include/linux/perf_event.h                    |   7 +
 kernel/events/core.c                          |   5 +
 tools/arch/x86/include/uapi/asm/perf_regs.h   |  23 +-
 tools/perf/Documentation/perf-stat.txt        |   9 +-
 tools/perf/Documentation/topdown.txt          | 223 +++++
 tools/perf/arch/x86/include/perf_regs.h       |  25 +-
 tools/perf/arch/x86/util/perf_regs.c          |  16 +
 tools/perf/builtin-stat.c                     |  24 +
 .../pmu-events/arch/x86/icelake/cache.json    | 552 +++++++++++
 .../arch/x86/icelake/floating-point.json      |  90 ++
 .../pmu-events/arch/x86/icelake/frontend.json | 424 +++++++++
 .../pmu-events/arch/x86/icelake/memory.json   | 410 ++++++++
 .../pmu-events/arch/x86/icelake/other.json    | 133 +++
 .../pmu-events/arch/x86/icelake/pipeline.json | 892 ++++++++++++++++++
 .../arch/x86/icelake/virtual-memory.json      | 236 +++++
 tools/perf/pmu-events/arch/x86/mapfile.csv    |   1 +
 tools/perf/util/perf_regs.h                   |   1 +
 tools/perf/util/stat-shadow.c                 |  89 ++
 tools/perf/util/stat.c                        |   4 +
 tools/perf/util/stat.h                        |   8 +
 36 files changed, 4418 insertions(+), 119 deletions(-)
 create mode 100644 tools/perf/Documentation/topdown.txt
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/cache.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/floating-point.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/frontend.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/memory.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/other.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/pipeline.json
 create mode 100644 tools/perf/pmu-events/arch/x86/icelake/virtual-memory.json
Signature · 1 line
2.17.1