Skip to content

ARM: sunxi: Fix USB host init fail on v5.1-rc1

Chen-Yu Tsai linux-amlogic linux-arm-kernel linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2phy: sun4i-usb: Support set_mode to USB_HOST for non-OTG PHYsdrivers/phy/allwinner/phy-sun4i-usb.c+4 -10 replies
2/2usb: core: Try generic PHY_MODE_USB_HOST if usb_phy_roothub_set_mode failsdrivers/usb/core/hcd.c+3 -01 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime RipardNeil Armstrong
SeriesA-b
1/2
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ARM: sunxi: Fix USB host init fail on v5.1-rc1

From: Chen-Yu Tsai <[email protected]>

Hi everyone,

As previously reported [1], USB EHCI/OHCI hosts are broken on Allwinner SoCs on v5.1-rc1. This is partially triggered by commit b97a31348379 ("usb: core: comply to PHY framework"), and partially due to how the Allwinner USB PHY driver handles phy_set_mode for non-OTG PHYs.

This series fixes this in both places.

Patch 1 makes phy-sun4i-usb accept PHY_MODE_USB_HOST for non-OTG PHYs.

Patch 2 makes the usb core fall back to setting the mode PHY_MODE_USB_HOST if set_mode with PHY_MODE_USB_HOST_SS fails. If that fails then the failure path is the same as before. This should make it so existing USB 3.0 drivers are affected.

The patches don't have any dependencies on each other, and could go in through separate branches. However this affects usability of USB input devices and Ethernet dongles, I'd rather they go in sooner than later.

Regards
ChenYu

[1] https://lkml.org/lkml/2019/3/18/74

Chen-Yu Tsai (2):
phy: sun4i-usb: Support set_mode to USB_HOST for non-OTG PHYs
usb: core: Try generic PHY_MODE_USB_HOST if usb_phy_roothub_set_mode
fails

 drivers/phy/allwinner/phy-sun4i-usb.c | 5 ++++-
 drivers/usb/core/hcd.c                | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1