toolchain-external: add OpenMP support
Get series with b4
b4 am 20190327185129.10dee1f5@blake-linuxVersions newest first · linked by author and title
- v2 Latest posting 3/30 of 4 patches 0 repliesNew
- v2 posting 2/30 of 4 patches 0 repliesSuperseded
- v2 posting 1/34 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 0 replies | Superseded |
Patches in v2 posting 3/3 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Buildroot] [PATCH v2 0/4] toolchain-external: add OpenMP support
Quoted 19 lines · On Tue, 26 Mar 2019 20:22:22 +0100 Thomas Petazzoni…
Hello Ed,
Quoted 5 lines · On Tue, 26 Mar 2019 12:30:44 +0000 Ed Blake <[email protected]> wrote:
Ed Blake (4):
toolchain-external: introduceBR2_TOOLCHAIN_HAS_OPENMPpackage/gcc: selectBR2_TOOLCHAIN_HAS_OPENMPifBR2_GCC_ENABLE_OPENMP
toolchain-external: enable OpenMP for supporting toolchains
package: useBR2_TOOLCHAIN_HAS_OPENMPThanks, I've applied all four patches.
However, it would be good if you could send additional patches that:
(1) Allows a custom external toolchain to specify that it supports OpenMP. This needs to be done in toolchain/toolchain-external/toolchain-external-custom/Config.in.options
Quoted 8 lines
(2) Adds a check to the external toolchain logic to ensure that if
BR2_TOOLCHAIN_HAS_OPENMPis enabled, the toolchain really supports it. This should be done in the $(2)_CONFIGURE_CMDS variable in pkg-toolchain-external.mk. You can for example write a check similar tocheck_fortran(see helpers.mk) that tries to compile a simple OpenMP program.Do you think you could work on this ?
Sure, will do.
Ed.
Quoted 4 lines
Thanks!
Thomas