Skip to content

openvswitch: load and reference the NAT helper.

Flavio Leitner netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8netfilter: use macros to create module aliases.include/net/netfilter/nf_conntrack_helper.h net/ipv4/netfilter/nf_nat_h323.c net/ipv4/netfilter/nf_nat_pptp.c +5 more+11 -72 replies
2/8netfilter: add API to manage NAT helpers.include/net/netfilter/nf_conntrack_helper.h net/netfilter/nf_conntrack_amanda.c net/netfilter/nf_conntrack_ftp.c +5 more+147 -133 replies
3/8netfilter: nf_nat: register amanda NAT helper.net/netfilter/nf_nat_amanda.c+7 -00 replies
4/8netfilter: nf_nat: register ftp NAT helper.net/netfilter/nf_nat_ftp.c+6 -00 replies
5/8netfilter: nf_nat: register irc NAT helper.net/netfilter/nf_nat_irc.c+6 -00 replies
6/8netfilter: nf_nat: register sip NAT helper.net/netfilter/nf_nat_sip.c+5 -10 replies
7/8netfilter: nf_nat: register tftp NAT helper.net/netfilter/nf_nat_tftp.c+6 -00 replies
8/8openvswitch: load and reference the NAT helper.net/openvswitch/conntrack.c+21 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/8] openvswitch: load and reference the NAT helper.

The request_module() is quite expensive and triggers the usermode helper in userspace. Instead, load only if the module is not present and keep module references to avoid problems.

The first patch standardize the module alias which is already there, but not in a formal way.

The second patch adds an API to point to the NAT helper.

The following patches will register each NAT helper using the new API.

The last patch fixes openvswitch to use the new API to load and reference the NAT helper and also report an error if the operation fails.

Flavio Leitner (8):
netfilter: use macros to create module aliases.
netfilter: add API to manage NAT helpers.
netfilter: nf_nat: register amanda NAT helper.
netfilter: nf_nat: register ftp NAT helper.
netfilter: nf_nat: register irc NAT helper.
netfilter: nf_nat: register sip NAT helper.
netfilter: nf_nat: register tftp NAT helper.
openvswitch: load and reference the NAT helper.

 include/net/netfilter/nf_conntrack_helper.h |  23 ++++-
 net/ipv4/netfilter/nf_nat_h323.c            |   2 +-
 net/ipv4/netfilter/nf_nat_pptp.c            |   2 +-
 net/netfilter/nf_conntrack_amanda.c         |   2 +
 net/netfilter/nf_conntrack_ftp.c            |   6 +-
 net/netfilter/nf_conntrack_helper.c         | 108 +++++++++++++++++++-
 net/netfilter/nf_conntrack_irc.c            |   3 +-
 net/netfilter/nf_conntrack_sane.c           |   4 +-
 net/netfilter/nf_conntrack_sip.c            |  12 ++-
 net/netfilter/nf_conntrack_tftp.c           |   6 +-
 net/netfilter/nf_nat_amanda.c               |   9 +-
 net/netfilter/nf_nat_ftp.c                  |   8 +-
 net/netfilter/nf_nat_irc.c                  |   8 +-
 net/netfilter/nf_nat_sip.c                  |   8 +-
 net/netfilter/nf_nat_tftp.c                 |   8 +-
 net/openvswitch/conntrack.c                 |  27 +++--
 16 files changed, 209 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1