Skip to content

net: Move fib_nh and fib6_nh to a common struct

David Ahern netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 9 repliesIn review
  2. v213 patches 8 repliesSuperseded
  3. v113 patches 15 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disablednet/ipv4/fib_semantics.c+9 -60 replies
2/13ipv4: Move IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN to helperinclude/linux/inetdevice.h net/ipv4/fib_semantics.c net/ipv4/fib_trie.c+22 -270 replies
3/13ipv4: Create init helper for fib_nhinclude/net/ip_fib.h net/ipv4/fib_semantics.c+95 -891 reply
4/13ipv4: Create cleanup helper for fib_nhinclude/net/ip_fib.h net/ipv4/fib_semantics.c+18 -120 replies
5/13ipv6: Create init helper for fib6_nhinclude/net/ip6_fib.h net/ipv6/route.c+145 -1081 reply
6/13ipv6: Create cleanup helper for fib6_nhinclude/net/ip6_fib.h net/ipv6/ip6_fib.c net/ipv6/route.c+10 -41 reply
7/13ipv6: Move gateway checks to a fib6_nh settingdrivers/net/ethernet/mellanox/mlxsw/spectrum_router.c include/net/ip6_fib.h include/net/ip6_route.h +4 more+41 -301 reply
8/13ipv6: Refactor fib6_ignore_linkdowninclude/net/addrconf.h net/ipv6/route.c+11 -180 replies
9/13ipv6: Change rt6_add_nexthop and rt6_nexthop_info to take fib6_nhnet/ipv6/route.c+20 -190 replies
10/13ipv4: Rename fib_nh entriesdrivers/net/ethernet/mellanox/mlx5/core/lag_mp.c drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c drivers/net/ethernet/rocker/rocker_ofdpa.c +7 more+178 -1740 replies
11/13ipv6: Rename fib6_nh entriesdrivers/net/ethernet/mellanox/mlxsw/spectrum_router.c include/net/ip6_fib.h include/net/ip6_route.h +6 more+138 -1270 replies
12/13net: Add fib_nh_common and update fib_nh and fib6_nhinclude/net/ip6_fib.h include/net/ip_fib.h net/ipv4/fib_semantics.c +1 more+42 -191 reply
13/13net: Use common nexthop init and release helpersinclude/net/ip_fib.h net/ipv4/fib_semantics.c net/ipv6/route.c+48 -373 replies

Reviews trailers per patch

11 of 13 patches have a Reviewed-by or Acked-by.

PatchIdo SchimmelAlexei Starovoitov
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13
11/13
12/13R-b
13/13R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 00/13] net: Move fib_nh and fib6_nh to a common struct

From: David Ahern <[email protected]>

First set of three with the end goal of enabling IPv6 gateways with IPv4 routes.

This set refactors ipv4 and ipv6 code to create init and release helpers for each protocol and moving common elements to a fib_nh_common struct.

v3
- split the reject setting into 2 with helper to the checks. This avoids changing cfg->fc_flags in fib6_nh_init

v2
- addressed Ido's comments: cleanup on failure path in nh_init helpers, ordering in fib6_nh_release, and removal of RTF_GATEWAY from fib6_info uses in mlxsw

David Ahern (13):
ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled
ipv4: Move IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN to helper
ipv4: Create init helper for fib_nh
ipv4: Create cleanup helper for fib_nh
ipv6: Create init helper for fib6_nh
ipv6: Create cleanup helper for fib6_nh
ipv6: Move gateway checks to a fib6_nh setting
ipv6: Refactor fib6_ignore_linkdown
ipv6: Change rt6_add_nexthop and rt6_nexthop_info to take fib6_nh
ipv4: Rename fib_nh entries
ipv6: Rename fib6_nh entries
net: Add fib_nh_common and update fib_nh and fib6_nh
net: Use common nexthop init and release helpers

 drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c   |  12 +-
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  |  60 +--
 drivers/net/ethernet/rocker/rocker_ofdpa.c         |  10 +-
 include/linux/inetdevice.h                         |  14 +
 include/net/addrconf.h                             |   8 +
 include/net/ip6_fib.h                              |  18 +-
 include/net/ip6_route.h                            |  12 +-
 include/net/ip_fib.h                               |  58 ++-
 include/trace/events/fib.h                         |   7 +-
 include/trace/events/fib6.h                        |   6 +-
 net/core/filter.c                                  |  16 +-
 net/ipv4/fib_frontend.c                            |  10 +-
 net/ipv4/fib_semantics.c                           | 473 +++++++++++----------
 net/ipv4/fib_trie.c                                |  14 +-
 net/ipv4/route.c                                   |  18 +-
 net/ipv6/addrconf.c                                |  27 +-
 net/ipv6/ip6_fib.c                                 |  18 +-
 net/ipv6/ndisc.c                                   |   8 +-
 net/ipv6/route.c                                   | 456 +++++++++++---------
 19 files changed, 676 insertions(+), 569 deletions(-)
Signature · 1 line
2.11.0