Skip to content

btrfs-progs: Fix the nobarrier behavior of write

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: disk-io: Make super block write error more easy to readdisk-io.c+11 -62 replies
2/2btrfs-progs: disk-io: Flush to ensure super block write is FUAdisk-io.c+28 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH URGENT 0/2] btrfs-progs: Fix the nobarrier behavior of write

This urgent patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/flush_super
Which is based on v4.20.2.

Before this patch, btrfs-progs writes to the fs has no barrier at all. All metadata and superblock are just buffered write, no barrier between super blocks and metadata writes at all.

No wonder why even clear space cache can cause serious transid corruption to the originally good fs.

Please merge this fix as soon as possible as I really don't want to see btrfs-progs corrupting any fs any more.

Qu Wenruo (2):
btrfs-progs: disk-io: Make super block write error more easy to read
btrfs-progs: disk-io: Flush to ensure super block write is FUA

 disk-io.c | 45 +++++++++++++++++++++++++++++++++++++++------
 1 file changed, 39 insertions(+), 6 deletions(-)
Signature · 1 line
2.21.0