net: mvpp2: Classifier updates and cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest18 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | net: mvpp2: Don't use an int to store netdev_features_tdrivers/ | +1 | 0 replies | |
| 2/18 | net: mvpp2: cls: Add missing MAC_DA field extractiondrivers/ | +3 | 0 replies | |
| 3/18 | net: mvpp2: cls: Start cls flow entries from beginning of tabledrivers/ | +5 | 0 replies | |
| 4/18 | net: mvpp2: cls: use Lookup Type in classification enginesdrivers/ drivers/ drivers/ | +21 | 0 replies | |
| 5/18 | net: mvpp2: cls: Rename MVPP2_N_FLOWS to MVPP2_N_PRS_FLOWSdrivers/ drivers/ drivers/ +1 more | +10 | 0 replies | |
| 6/18 | net: mvpp2: cls: Make the flow definitions constdrivers/ drivers/ drivers/ | +15 | 0 replies | |
| 7/18 | net: mvpp2: debugfs: Store debugfs entries data in mvpp2 structdrivers/ drivers/ | +26 | 0 replies | |
| 8/18 | net: mvpp2: debugfs: Allow reading the flow table from debugfsdrivers/ | +63 | 0 replies | |
| 9/18 | net: mvpp2: debugfs: Allow reading the C2 engine table from debugfsdrivers/ | +59 | 0 replies | |
| 10/18 | net: mvpp2: cls: Use iterators to go through the cls_tabledrivers/ drivers/ | +25 | 0 replies | |
| 11/18 | net: mvpp2: cls: Write C2 TCAM data last when writing a C2 entrydrivers/ | +7 | 0 replies | |
| 12/18 | net: mvpp2: cls: Move C2 read/write helpers arounddrivers/ | +41 | 0 replies | |
| 13/18 | net: mvpp2: cls: Rename classifer per-port functionsdrivers/ drivers/ drivers/ | +9 | 0 replies | |
| 14/18 | net: mvpp2: cls: Don't use the sequence attribute for classificationdrivers/ drivers/ | +0 | 0 replies | |
| 15/18 | net: mvpp2: cls: Rename the flow table macrosdrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 16/18 | net: mvpp2: cls: Invalidate all C2 entries except the ones we usedrivers/ drivers/ drivers/ | +30 | 0 replies | |
| 17/18 | net: mvpp2: cls: Initialize lookup priorities for all entries in the flowdrivers/ | +24 | 0 replies | |
| 18/18 | net: mvpp2: cls: Rework C2 engine macrosdrivers/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 00/18] net: mvpp2: Classifier updates and cleanups
Hi all,
In preparation for the future addition of classification offload support, this series cleans-up the current code dealing with the classification engines.
As of today, the classification code only deals with RSS, which is a very narrow use-case when considering all of the classifier's features.
This lead to design and naming decisions that don't really stand when considering using more classification features.
This series therefore includes quite a lot a renaming of functions and macros, and tries to make the naming schemes more consistent and the code more readable.
The debugfs interface that allows reading the various Parsing and Classification engines has been cleaned-up and made more generic, allowing to read the Flow Table and C2 engine hit counters on a per-entry basis.
The Classifier itself has been made more robust by introducing the lu_type field in classification lookups, that prevents false-positive matches in the future. We also initialise the various engine in a more extensive and less error-prone way by assining default values to all entries in the C2 and Flow table.
This is a pretty big series considering it's mostly cleanup, but my goal is to make the future series that will contain new big features easier to review, focusing on the real logic.
Besides the debugfs interface, this series doesn't intend to introduce any new features or change in behaviours.
Maxime Chevallier (18):
net: mvpp2: Don't use an int to store netdev_features_t
net: mvpp2: cls: Add missing MAC_DA field extraction
net: mvpp2: cls: Start cls flow entries from beginning of table
net: mvpp2: cls: use Lookup Type in classification engines
net: mvpp2: cls: Rename MVPP2_N_FLOWS to MVPP2_N_PRS_FLOWS
net: mvpp2: cls: Make the flow definitions const
net: mvpp2: debugfs: Store debugfs entries data in mvpp2 struct
net: mvpp2: debugfs: Allow reading the flow table from debugfs
net: mvpp2: debugfs: Allow reading the C2 engine table from debugfs
net: mvpp2: cls: Use iterators to go through the cls_table
net: mvpp2: cls: Write C2 TCAM data last when writing a C2 entry
net: mvpp2: cls: Move C2 read/write helpers around
net: mvpp2: cls: Rename classifer per-port functions
net: mvpp2: cls: Don't use the sequence attribute for classification
net: mvpp2: cls: Rename the flow table macros
net: mvpp2: cls: Invalidate all C2 entries except the ones we use
net: mvpp2: cls: Initialize lookup priorities for all entries in the
flow
net: mvpp2: cls: Rework C2 engine macros
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 10 + .../net/ethernet/marvell/mvpp2/mvpp2_cls.c | 212 ++++++++------- .../net/ethernet/marvell/mvpp2/mvpp2_cls.h | 92 ++++--- .../ethernet/marvell/mvpp2/mvpp2_debugfs.c | 253 +++++++++++------- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 +- 5 files changed, 341 insertions(+), 234 deletions(-)
Signature · 1 line
2.20.1