btrfs-progs: Fix the nobarrier behavior of write
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 7 repliesIn review
Changelog from the cover letter
v1.1:
- Use one line error report other than 2 seperate lines.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs-progs: disk-io: Make super block write error easier to readdisk-io.c | +14 | 1 reply | |
| 2/2 | btrfs-progs: disk-io: Flush to ensure super block write is FUAdisk-io.c | +31 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Nikolay Borisov |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH URGENT v1.1 0/2] btrfs-progs: Fix the nobarrier behavior of write
This urgent patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/flush_super
Which is based on v4.20.2.
Before this patch, btrfs-progs writes to the fs has no barrier at all. All metadata and superblock are just buffered write, no barrier between super blocks and metadata writes at all.
No wonder why even clear space cache can cause serious transid corruption to the originally good fs.
Please merge this fix as soon as possible as I really don't want to see btrfs-progs corrupting any fs any more.
Changelog:
v1.1:
- Use one line error report other than 2 seperate lines.
Qu Wenruo (2):
btrfs-progs: disk-io: Make super block write error easier to read
btrfs-progs: disk-io: Flush to ensure super block write is FUA
disk-io.c | 56 ++++++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 45 insertions(+), 11 deletions(-)
Signature · 1 line
2.21.0