Skip to content

ACPI / utils: Replace leaky function

Andy Shevchenko alsa-devel linux-acpi 1 version Applied

Status from this message: Applied it. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest10 patches 16 repliesApplied

Since v3 from the cover letter

- convert all existing users and drop old API (Mika)
- add Hans' tag

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10ACPI / utils: Introduce acpi_dev_get_first_match_dev() helperdrivers/acpi/utils.c include/acpi/acpi_bus.h include/linux/acpi.h+31 -23 replies
2/10extcon: axp288: Convert to use acpi_dev_get_first_match_dev()drivers/extcon/extcon-axp288.c+5 -43 replies
3/10gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()drivers/gpio/gpio-merrifield.c+14 -40 replies
4/10ASoC: Intel: bytcht_da7213: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/bytcht_da7213.c+5 -40 replies
5/10ASoC: Intel: bytcht_es8316: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/bytcht_es8316.c+5 -40 replies
6/10ASoC: Intel: bytcr_rt5640: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/bytcr_rt5640.c+5 -50 replies
7/10ASoC: Intel: bytcr_rt5651: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/bytcr_rt5651.c+8 -60 replies
8/10ASoC: Intel: cht_bsw_rt5645: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/cht_bsw_rt5645.c+5 -40 replies
9/10ASoC: Intel: cht_bsw_rt5672: Convert to use acpi_dev_get_first_match_dev()sound/soc/intel/boards/cht_bsw_rt5672.c+5 -40 replies
10/10ACPI / utils: Remove deprecated function since no user leftdrivers/acpi/utils.c include/acpi/acpi_bus.h include/linux/acpi.h+0 -250 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de GoedePierre-Louis BossartMika WesterbergChanwoo ChoiMark Brown
SeriesR-b A-b R-b
1/10R-b A-b
2/10A-b
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] ACPI / utils: Replace leaky function

The acpi_dev_get_first_match_name() is missing put_device() call and thus keeping reference counting unbalanced.

In order to fix the issue introduce a new helper to convert existing users one-by-one to a better API.

Since v3:
- convert all existing users and drop old API (Mika)
- add Hans' tag

Cc MyungJoo Ham <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc Chen-Yu Tsai <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Bartosz Golaszewski <[email protected]>

Andy Shevchenko (10):
ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
extcon: axp288: Convert to use acpi_dev_get_first_match_dev()
gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()
ASoC: Intel: bytcht_da7213: Convert to use
acpi_dev_get_first_match_dev()
ASoC: Intel: bytcht_es8316: Convert to use
acpi_dev_get_first_match_dev()
ASoC: Intel: bytcr_rt5640: Convert to use
acpi_dev_get_first_match_dev()
ASoC: Intel: bytcr_rt5651: Convert to use
acpi_dev_get_first_match_dev()
ASoC: Intel: cht_bsw_rt5645: Convert to use
acpi_dev_get_first_match_dev()
ASoC: Intel: cht_bsw_rt5672: Convert to use
acpi_dev_get_first_match_dev()
ACPI / utils: Remove deprecated function since no user left

 drivers/acpi/utils.c                    | 16 ++++++++++------
 drivers/extcon/extcon-axp288.c          |  9 +++++----
 drivers/gpio/gpio-merrifield.c          | 18 ++++++++++++++----
 include/acpi/acpi_bus.h                 |  4 ++--
 include/linux/acpi.h                    |  4 ++--
 sound/soc/intel/boards/bytcht_da7213.c  |  9 +++++----
 sound/soc/intel/boards/bytcht_es8316.c  |  9 +++++----
 sound/soc/intel/boards/bytcr_rt5640.c   | 10 +++++-----
 sound/soc/intel/boards/bytcr_rt5651.c   | 14 ++++++++------
 sound/soc/intel/boards/cht_bsw_rt5645.c |  9 +++++----
 sound/soc/intel/boards/cht_bsw_rt5672.c |  9 +++++----
 11 files changed, 66 insertions(+), 45 deletions(-)
Signature · 1 line
2.20.1