Skip to content

xfs: a couple minor shutdown fixes

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: wake commit waiters on CIL abort before log item abortfs/xfs/xfs_log_cil.c+13 -82 replies
2/2xfs: shutdown after buf release in iflush cluster abort pathfs/xfs/xfs_inode.c+3 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAllison Henderson
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xfs: a couple minor shutdown fixes

Hi all,

Here are a couple of shutdown fixups that fell out of Darrick's recent report of a deadlock problem via generic/475. I've still not been able to reproduce the generic/475 deadlock, but Darrick has tested patch 1 and last I heard reported that the deadlock had not reoccurred. Patch 2 fixes up a buffer leak and reorders the shutdown in the xfs_iflush_cluster() abort codepath.

After making a higher level pass across the codebase, there are still places where we technically invoke synchronous log forces (or filesystem shutdowns, which can induce a sync log force) with various object locks held. This isn't always a problem as some are contexts where a buffer should never be pinned, etc. That said, if we want to institute a general policy of never inducing sync log forces or shutdowns from contexts with held locks then I'd suggest that's something we should evolve opportunistically over time.

Thoughts, reviews, flames appreciated.

Brian

Brian Foster (2):
xfs: wake commit waiters on CIL abort before log item abort
xfs: shutdown after buf release in iflush cluster abort path

 fs/xfs/xfs_inode.c   |  4 +++-
 fs/xfs/xfs_log_cil.c | 21 +++++++++++++--------
 2 files changed, 16 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.2