Skip to content

net: More movement to fib_nh_common

David Ahern netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 5 repliesIn review
  2. v35 patches 9 repliesSuperseded
  3. v25 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ipv4: Update fib_table_lookup tracepoint to take common nexthopinclude/trace/events/fib.h net/ipv4/fib_trie.c+27 -200 replies
2/5ipv4: Add fib_nh_common to fib_resultinclude/net/ip_fib.h net/core/filter.c net/ipv4/fib_frontend.c +4 more+99 -650 replies
3/5ipv4: Refactor nexthop attributes in fib_dump_infonet/ipv4/fib_semantics.c+107 -590 replies
4/5ipv4: Change fib_nexthop_info and fib_add_nexthop to take fib_nh_commonnet/ipv4/fib_semantics.c+32 -200 replies
5/5ipv6: Flip to fib_nexthop_infoinclude/net/ip_fib.h net/ipv4/fib_semantics.c net/ipv6/route.c+28 -760 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMartin KaFai Lau
SeriesA-b
1/5
2/5
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 net-next 0/5] net: More movement to fib_nh_common

From: David Ahern <[email protected]>

Second set of three with the end goal of enabling IPv6 gateways with IPv4 routes.

This set moves:
- the ipv4 tracepoint to take a fib_nh_common and updates it to handle a v6 gateway.
- consolidates route notifications to use the same fill functions for both ipv4 and ipv6

v4
- enhanced the commit message for patches 1 and 2

v3
- comments from Martin:
+ renamed FIB_RES_NH to FIB_RES_NHC
+ removed family check from fib_result_prefsrc
+ in fib_nexthop_info, renamed nexthop arg to nhc and dropped for_ipv4 arg

v2
- dropped patches moving cached routes and exception buckets to fib_nh_common. The goal is allowing a fib6_nh to be used with an IPv4 route. The hold up is the need for separate exception buckets - one for v6 routes and one for v4 routes. When all of the nexthop patches are in, adding a secondi exception bucket pushes IPv6 fib6_info allocations over 256 which means fib6_info allocations roll up to 512. Hence, deferring the patches until some data mining can be done to keep the allocations at 256.

David Ahern (5):
ipv4: Update fib_table_lookup tracepoint to take common nexthop
ipv4: Add fib_nh_common to fib_result
ipv4: Refactor nexthop attributes in fib_dump_info
ipv4: Change fib_nexthop_info and fib_add_nexthop to take
fib_nh_common
ipv6: Flip to fib_nexthop_info

 include/net/ip_fib.h       |  52 +++++------
 include/trace/events/fib.h |  45 ++++++----
 net/core/filter.c          |  12 +--
 net/ipv4/fib_frontend.c    |   6 +-
 net/ipv4/fib_lookup.h      |   1 +
 net/ipv4/fib_semantics.c   | 215 ++++++++++++++++++++++++++++++++-------------
 net/ipv4/fib_trie.c        |  13 +--
 net/ipv4/route.c           |  60 ++++++++-----
 net/ipv6/route.c           |  77 ++--------------
 9 files changed, 267 insertions(+), 214 deletions(-)
Signature · 1 line
2.11.0