Skip to content

blk-mq: allow to run queue if queue refcount is held

Ming Lei linux-block linux-scsi stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v15 patches 27 repliesSuperseded

Changes in v2 from the cover letter

- moving freeing hw queue resources into hctx's release handler

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3blk-mq: free hw queue's resource in hctx's release handlerblock/blk-core.c block/blk-mq-sysfs.c block/blk-mq.c +1 more+10 -80 replies
2/3block: don't drain in-progress dispatch in blk_cleanup_queue()block/blk-core.c+0 -122 replies
3/3SCSI: don't grab queue usage counter before run queuedrivers/scsi/scsi_lib.c+0 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/3] blk-mq: allow to run queue if queue refcount is held

Hi,

Since 45a9c9d909b2 ("blk-mq: Fix a use-after-free"), run queue isn't allowed during cleanup queue even though queue refcount is held.

This change has caused lots of kernel oops triggered in run queue path, turns out it isn't easy to fix them all.

So move freeing of hw queue resources into hctx's release handler, then the above issue is fixed. Meantime, this way is safe given freeing hw queue resource doesn't require tags.

V2:
- moving freeing hw queue resources into hctx's release handler

Ming Lei (3):
blk-mq: free hw queue's resource in hctx's release handler
block: don't drain in-progress dispatch in blk_cleanup_queue()
SCSI: don't grab queue usage counter before run queue

 block/blk-core.c        | 14 +-------------
 block/blk-mq-sysfs.c    |  6 ++++++
 block/blk-mq.c          |  8 ++------
 block/blk-mq.h          |  2 +-
 drivers/scsi/scsi_lib.c |  7 -------
 5 files changed, 10 insertions(+), 27 deletions(-)
Cc Dongli Zhang <[email protected]>
Cc James Smart <[email protected]>
Cc Bart Van Assche <[email protected]>
Cc Martin K . Petersen <[email protected]>,
Cc Christoph Hellwig <[email protected]>,
Cc James E . J . Bottomley <[email protected]>,
Cc jianchao wang <[email protected]>
Signature · 1 line
2.9.5