crypto: fuzz algorithms against their generic implementation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 8 repliesIn review
- v118 patches 16 repliesSuperseded
Changes in v2 from the cover letter
- Make cryptomgr use arch_initcall(), so we don't rely on the order in which the object files are linked.
- Show the expected error code when a test fails due to the wrong error code being returned.
- Generate zero-length associated data more often for AEADs (about 1/4 of the time rather than about 1/256 of the time).
- A few other minor cleanups.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | crypto: testmgr - expand ability to test for errorscrypto/ crypto/ | +104 | 0 replies | |
| 2/7 | crypto: testmgr - identify test vectors by name rather than numbercrypto/ | +96 | 0 replies | |
| 3/7 | crypto: testmgr - add helpers for fuzzing against generic implementationcrypto/ | +128 | 0 replies | |
| 4/7 | crypto: testmgr - fuzz hashes against their generic implementationcrypto/ | +170 | 0 replies | |
| 5/7 | crypto: testmgr - fuzz skciphers against their generic implementationcrypto/ crypto/ | +198 | 0 replies | |
| 6/7 | crypto: testmgr - fuzz AEADs against their generic implementationcrypto/ | +229 | 0 replies | |
| 7/7 | crypto: run initcalls for generic implementations earliercrypto/ crypto/ crypto/ +80 more | +89 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ard Biesheuvel |
|---|---|
| Series | A-b T-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation
Hello,
In the crypto API, all implementations of each algorithm are supposed to produce the same results. However, testing of this is currently limited to the list of test vectors hardcoded for each algorithm. Although after recent improvements the self-tests do much more with each test vector, hardcoded test vectors can never cover all cases.
This series improves the situation by making the self-tests automatically generate random test vectors using the corresponding generic implementation, then run them against the algorithm under test. This detects bugs where the implementations don't match.
This has already found many bugs and inconsistencies, including an integer overflow bug in the x86_64 implementation of Poly1305.
These new fuzz tests are behind CONFIG_CRYPTO_MANAGER_EXTRA_TESTS.
Patch 1-6 are the testmgr changes themselves. Patch 7 makes the generic implementations be registered earlier so that they're available when optimized implementations are being tested, when both are built-in. Note that even after this, for many algorithms it's still possible to make the generic implementation unset or modular. Thus a missing generic implementation just causes the comparison tests to be skipped with a warning; they aren't failed.
So far I've tested all generic, x86, arm, and arm64 algorithms, plus some PowerPC algorithms. I have not tested hardware drivers. I encourage people to run the tests on drivers and other architectures, as they will find more bugs.
This can also be found in git at:
URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
Branch: cryptofuzz-vs-generic
Changed since v1:
- Make cryptomgr use arch_initcall(), so we don't rely on the order in which the object files are linked.
- Show the expected error code when a test fails due to the wrong error code being returned.
- Generate zero-length associated data more often for AEADs (about 1/4 of the time rather than about 1/256 of the time).
- A few other minor cleanups.
Eric Biggers (7):
crypto: testmgr - expand ability to test for errors
crypto: testmgr - identify test vectors by name rather than number
crypto: testmgr - add helpers for fuzzing against generic
implementation
crypto: testmgr - fuzz hashes against their generic implementation
crypto: testmgr - fuzz skciphers against their generic implementation
crypto: testmgr - fuzz AEADs against their generic implementation
crypto: run initcalls for generic implementations earlier
crypto/842.c | 2 +- crypto/adiantum.c | 2 +- crypto/aegis128.c | 2 +- crypto/aegis128l.c | 2 +- crypto/aegis256.c | 2 +- crypto/aes_generic.c | 2 +- crypto/algboss.c | 8 +- crypto/ansi_cprng.c | 2 +- crypto/anubis.c | 2 +- crypto/arc4.c | 2 +- crypto/authenc.c | 2 +- crypto/authencesn.c | 2 +- crypto/blowfish_generic.c | 2 +- crypto/camellia_generic.c | 2 +- crypto/cast5_generic.c | 2 +- crypto/cast6_generic.c | 2 +- crypto/cbc.c | 2 +- crypto/ccm.c | 2 +- crypto/cfb.c | 2 +- crypto/chacha20poly1305.c | 2 +- crypto/chacha_generic.c | 2 +- crypto/cmac.c | 2 +- crypto/crc32_generic.c | 2 +- crypto/crc32c_generic.c | 2 +- crypto/crct10dif_generic.c | 2 +- crypto/crypto_null.c | 2 +- crypto/ctr.c | 2 +- crypto/cts.c | 2 +- crypto/deflate.c | 2 +- crypto/des_generic.c | 2 +- crypto/dh.c | 2 +- crypto/drbg.c | 2 +- crypto/ecb.c | 2 +- crypto/ecdh.c | 2 +- crypto/echainiv.c | 2 +- crypto/fcrypt.c | 2 +- crypto/fips.c | 2 +- crypto/gcm.c | 2 +- crypto/ghash-generic.c | 2 +- crypto/hmac.c | 2 +- crypto/jitterentropy-kcapi.c | 2 +- crypto/keywrap.c | 2 +- crypto/khazad.c | 2 +- crypto/lrw.c | 2 +- crypto/lz4.c | 2 +- crypto/lz4hc.c | 2 +- crypto/lzo-rle.c | 2 +- crypto/lzo.c | 2 +- crypto/md4.c | 2 +- crypto/md5.c | 2 +- crypto/michael_mic.c | 2 +- crypto/morus1280.c | 2 +- crypto/morus640.c | 2 +- crypto/nhpoly1305.c | 2 +- crypto/ofb.c | 2 +- crypto/pcbc.c | 2 +- crypto/pcrypt.c | 2 +- crypto/poly1305_generic.c | 2 +- crypto/rmd128.c | 2 +- crypto/rmd160.c | 2 +- crypto/rmd256.c | 2 +- crypto/rmd320.c | 2 +- crypto/rsa.c | 2 +- crypto/salsa20_generic.c | 2 +- crypto/seed.c | 2 +- crypto/seqiv.c | 2 +- crypto/serpent_generic.c | 2 +- crypto/sha1_generic.c | 2 +- crypto/sha256_generic.c | 2 +- crypto/sha3_generic.c | 2 +- crypto/sha512_generic.c | 2 +- crypto/sm3_generic.c | 2 +- crypto/sm4_generic.c | 2 +- crypto/streebog_generic.c | 2 +- crypto/tcrypt.c | 2 +- crypto/tea.c | 2 +- crypto/testmgr.c | 989 +++++++++++++++++++++++++++++++---- crypto/testmgr.h | 22 +- crypto/tgr192.c | 2 +- crypto/twofish_generic.c | 2 +- crypto/vmac.c | 2 +- crypto/wp512.c | 2 +- crypto/xcbc.c | 2 +- crypto/xts.c | 2 +- crypto/zstd.c | 2 +- 85 files changed, 986 insertions(+), 197 deletions(-)
Signature · 1 line
2.21.0