Skip to content

Fix compilation error if CONFIG_USB is disabled

Tom Rini u-boot 2 versions – New

Get series with b4
b4 am 20190425133739.GO31207@bill-the-cat

Versions newest first · linked by author and title

  1. v2 Latest0 of 2 patches 0 repliesNew
  2. v11 patch 0 repliesSuperseded

Patches in v2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/2] Fix compilation error if CONFIG_USB is disabled
Quoted 3 lines · Ajay Kaher

Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'.
But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h)

Since Matthias is the Pi custodian, I'm expecting a PR from him with the changes. Thanks!

Quoted 35 lines

- Ajay

On 11/04/19, 10:56 AM, "akaher" <[email protected]> wrote:

Fix compilation error if CONFIG_USB is disabled

[Patch v2 1/2]:
CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

[Patch v2 2/2]:
This patch is to fix the following compilation error when disabling CONFIG_USB for Rpi3:

include/config_distro_bootcmd.h:242:2: error: expected ‘}’ before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’
BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB

Changes from v1:
Split the patch.

cmd/Kconfig | 1 +
include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++-----

2 file changed, 32 insertions(+), 5 deletions(-)

--
2.14.2

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190425/8ef0a4da/attachment.sig>