Skip to content

RFC Forbid static SRCU use in modules

Paul E. McKenney amd-gfx dri-devel linux-nvdimm lkml nvdimm rcu 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 42 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dax/super: Dynamically allocate dax_srcudrivers/dax/super.c+9 -12 replies
2/4drivers/gpu/drm: Dynamically allocate drm_unplug_srcudrivers/gpu/drm/drm_drv.c+7 -11 reply
3/4drivers/gpu/drm/amd: Dynamically allocate kfd_processes_srcudrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c drivers/gpu/drm/amd/amdkfd/kfd_process.c+6 -12 replies
4/4rcu: Forbid DEFINE{,_STATIC}_SRCU() from modulesinclude/linux/srcutree.h kernel/rcu/rcuperf.c kernel/rcu/rcutorture.c+83 -240 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

Patchkbuild test robotTejun HeoDaniel VetterDan Williams
1/4R-b
2/4R-b
3/4T-b
4/4Looks-great-to-me-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH RFC tip/core/rcu 0/4] Forbid static SRCU use in modules

Hello!

This series prohibits use of DEFINE_SRCU() and DEFINE_STATIC_SRCU() by loadable modules. The reason for this prohibition is the fact that using these two macros within modules requires that the size of the reserved region be increased, which is not something we want to be doing all that often. Instead, loadable modules should define an srcu_struct and invoke init_srcu_struct() from their module_init function and cleanup_srcu_struct() from their module_exit function. Note that modules using call_srcu() will also need to invoke srcu_barrier() from their module_exit function.

This series consist of the following:

1. Dynamically allocate dax_srcu.

2. Dynamically allocate drm_unplug_srcu.

3. Dynamically allocate kfd_processes_srcu.

These build and have been subjected to 0day testing, but might also need testing by someone having the requisite hardware.

Thanx, Paul

------------------------------------------------------------------------

 drivers/dax/super.c                        |   10 +++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c |    5 +++
 drivers/gpu/drm/amd/amdkfd/kfd_process.c   |    2 -
 drivers/gpu/drm/drm_drv.c                  |    8 ++++
 include/linux/srcutree.h                   |   19 +++++++++--
 kernel/rcu/rcuperf.c                       |   40 +++++++++++++++++++-----
 kernel/rcu/rcutorture.c                    |   48 +++++++++++++++++++++--------
 7 files changed, 105 insertions(+), 27 deletions(-)