Skip to content

tests/kms_chamelium: add dp-audio test

Simon Ser igt-dev 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 posting 2/21 patch 1 replyIn review
  2. v4 posting 2/29 patches 4 repliesSuperseded
  3. v3 posting 2/29 patches 1 replySuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v7 Latest8 patches5 repliesIn review
v67 patches11 repliesSuperseded
v5 posting 1/21 patch0 repliesSuperseded
v4 posting 1/25 patches5 repliesSuperseded
v3 posting 1/24 patches1 replySuperseded
v21 patch0 repliesSuperseded
v11 patch1 replySuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tests/kms_chamelium: add dp-audio testdocs/audio.txt docs/chamelium.txt lib/igt.h +16 more+1382 -3922 replies
2/8tests/kms_chamelium: capture audio data in real-timelib/igt_alsa.c tests/kms_chamelium.c+43 -190 replies
3/8lib/igt_{alsa, audio}: improve logginglib/igt_alsa.c lib/igt_audio.c+23 -31 reply
4/8lib/igt_alsa: use variables to improve readabilitylib/igt_alsa.c+4 -11 reply
5/8tests/kms_chamelium: test we receive a signal from both audio channelslib/igt_audio.c lib/igt_audio.h tests/kms_chamelium.c+111 -720 replies
6/8tests/kms_chamelium: test audio channels are not mixed uplib/igt_chamelium.c lib/igt_chamelium.h tests/kms_chamelium.c+73 -80 replies
7/8tests/kms_chamelium: run audio test with multiple sampling rateslib/igt_chamelium.c lib/igt_chamelium.h lib/igt_chamelium_stream.c +2 more+89 -670 replies
8/8HAX: add dp-audio test to fast-feedbacktests/intel-ci/fast-feedback.testlist+1 -00 replies

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMartin Peres
SeriesR-b
1/8
2/8
3/8R-b
4/8R-b
5/8
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [igt-dev] [PATCH i-g-t v7 0/8] tests/kms_chamelium: add dp-audio test

Changes in v7: addressed Martin's comments

Thanks for the detailed review! I've tried splitting some commits, let me know if more splitting is needed.

Simon Ser (8):
tests/kms_chamelium: add dp-audio test tests/kms_chamelium: capture audio data in real-time lib/igt_{alsa,audio}: improve logging
lib/igt_alsa: use variables to improve readability tests/kms_chamelium: test we receive a signal from both audio channels tests/kms_chamelium: test audio channels are not mixed up tests/kms_chamelium: run audio test with multiple sampling rates
HAX: add dp-audio test to fast-feedback

 docs/audio.txt                        |  45 --
 docs/chamelium.txt                    |  34 +-
 lib/igt.h                             |   1 +
 lib/igt_alsa.c                        |  83 +++-
 lib/igt_alsa.h                        |   1 +
 lib/igt_audio.c                       | 428 +++++++++++++------
 lib/igt_audio.h                       |  19 +-
 lib/igt_aux.c                         |  31 ++
 lib/igt_aux.h                         |   1 +
 lib/igt_chamelium.c                   | 161 ++++++++
 lib/igt_chamelium.h                   |  17 +
 lib/igt_chamelium_stream.c            | 572 ++++++++++++++++++++++++++
 lib/igt_chamelium_stream.h            |  50 +++
 lib/meson.build                       |   5 +-
 meson.build                           |  52 +--
 meson_options.txt                     |   6 -
 tests/audio.c                         | 193 ---------
 tests/intel-ci/fast-feedback.testlist |   1 +
 tests/kms_chamelium.c                 | 355 +++++++++++++++-
 tests/meson.build                     |   9 +-
 20 files changed, 1614 insertions(+), 450 deletions(-)
 delete mode 100644 docs/audio.txt
 create mode 100644 lib/igt_chamelium_stream.c
 create mode 100644 lib/igt_chamelium_stream.h
 delete mode 100644 tests/audio.c
Signature · 6 lines
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev