Clean up use of error_printf()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest15 patches 5 repliesIn review
- v215 patches 4 repliesSuperseded
- v115 patches 32 repliesSuperseded
Changes in v3 from the cover letter
* PATCH 03: Replaced by new PATCH 14 [Paolo]
* PATCH 10: Trivial conflict with "[PATCH v7 0/2] log: Make glib logging go through QEMU" resolved.
Patches in v3 No applies recorded yet
Reviews trailers per patch
14 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Marcel Apfelbaum | Thomas Huth | Cornelia Huck | Dr. David Alan Gilbert | Eric Blake | Marc-André Lureau | Alex Williamson |
|---|---|---|---|---|---|---|---|---|
| 1/15 | R-b | |||||||
| 2/15 | R-b | |||||||
| 3/15 | R-b | |||||||
| 4/15 | R-b | |||||||
| 5/15 | R-b | |||||||
| 6/15 | ||||||||
| 7/15 | A-b | |||||||
| 8/15 | R-b | R-b | ||||||
| 9/15 | R-b | |||||||
| 10/15 | R-b | |||||||
| 11/15 | R-b | R-b | ||||||
| 12/15 | R-b T-b | |||||||
| 13/15 | R-b T-b | R-b | ||||||
| 14/15 | R-b | |||||||
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.
Cover letter [Qemu-devel] [PATCH v3 00/15] Clean up use of error_printf()
This series cleans up two kinds of error_printf() misuse:
* Errors and warnings should be reported with error_report() and warn_report().
* Help output should be go to stdout, not stderr.
This is obviously for 4.1. If nobody objects, I'll take the whole series through my tree.
Based-on: <[email protected]>
v3:
* PATCH 03: Replaced by new PATCH 14 [Paolo]
* PATCH 10: Trivial conflict with "[PATCH v7 0/2] log: Make glib logging go through QEMU" resolved.
v2:
* PATCH 02: Commit message tweaked, indentation fixed [Eric]
* PATCH 10: Indentation fixed [Marcel]
* PATCH 11: Use-after-free fixed [Patchew]
* PATCH 12: test-util-sockets.c updated along with stubs/monitor.c
* PATCH 14: Commit message typo [Eric]
Markus Armbruster (15):
qemu-img: Use error_vreport() in error_exit() block/ssh: Do not report read/write/flush errors to the user
loader-fit: Wean off error_printf()
mips/boston: Report errors with error_report(), not error_printf()
pci: Report fatal errors with error_report(), not error_printf()
hpet: Report warnings with warn_report(), not error_printf()
vfio: Report warnings with warn_report(), not error_printf() s390x/kvm: Report warnings with warn_report(), not error_printf()
vl: Make -machine $TYPE,help and -accel help print to stdout monitor error: Make printf()-like functions return a value
qemu-print: New qemu_printf(), qemu_vprintf() etc.
blockdev: Make -drive format=help print to stdout
char: Make -chardev help print to stdout
char-pty: Print "char device redirected" message to stdout
monitor: Simplify how -device/device_add print help
MAINTAINERS | 2 ++ block/ssh.c | 38 +++++++------------- block/trace-events | 3 ++ blockdev.c | 9 ++--- chardev/char-pty.c | 5 +-- chardev/char.c | 3 +- hw/core/loader-fit.c | 62 +++++++++++++++++++-------------- hw/mips/boston.c | 6 ++-- hw/pci/pci.c | 2 +- hw/timer/hpet.c | 2 +- hw/vfio/pci.c | 19 ++++++---- include/monitor/monitor.h | 7 ++-- include/qemu/error-report.h | 8 ++--- include/qemu/qemu-print.h | 19 ++++++++++ monitor.c | 69 ++++++++++++++++++------------------- qdev-monitor.c | 36 ++++++++----------- qemu-img.c | 6 ++-- stubs/error-printf.c | 13 ++++--- stubs/monitor.c | 5 +++ target/s390x/kvm.c | 2 +- tests/test-util-sockets.c | 1 + util/Makefile.objs | 1 + util/qemu-error.c | 12 ++++--- util/qemu-print.c | 42 ++++++++++++++++++++++ vl.c | 10 +++--- 25 files changed, 227 insertions(+), 155 deletions(-) create mode 100644 include/qemu/qemu-print.h create mode 100644 util/qemu-print.c
Signature · 1 line
2.17.2