Skip to content

Share TTM code among DRM framebuffer drivers

Thomas Zimmermann dri-devel virtualization 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/220 patches 3 repliesIn review
  2. v5 posting 1/20 of 20 patches 0 repliesSuperseded
  3. v4 posting 2/219 patches 24 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v4 posting 1/20 of 19 patches0 repliesSuperseded
v3 posting 2/219 patches20 repliesSuperseded
v3 posting 1/20 of 19 patches0 repliesSuperseded
v2 posting 2/217 patches9 repliesSuperseded
v2 posting 1/20 of 17 patches0 repliesSuperseded
v115 patches27 repliesSuperseded

Changes in v5 from the cover letter

* move bochs PRIME functions to GEM VRAM helpers
* always set struct file_operations.llseek to no_llseek()
* add WARN_ON_ONCE for pin-count mismatches
* only allocate 2 entries in placements array

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20drm: Add |struct drm_gem_vram_object| and helpersDocumentation/gpu/drm-mm.rst drivers/gpu/drm/Kconfig drivers/gpu/drm/Makefile +3 more+536 -00 replies
1/20drm: Add |struct drm_gem_vram_object| and helpersDocumentation/gpu/drm-mm.rst drivers/gpu/drm/Kconfig drivers/gpu/drm/Makefile +3 more+536 -00 replies
2/20drm: Add |struct drm_gem_vram_object| callbacks for |struct ttm_bo_driver|drivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+60 -00 replies
2/20drm: Add |struct drm_gem_vram_object| callbacks for |struct ttm_bo_driver|drivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+60 -00 replies
3/20drm: Add |struct drm_gem_vram_object| callbacks for |struct drm_driver|drivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+59 -00 replies
3/20drm: Add |struct drm_gem_vram_object| callbacks for |struct drm_driver|drivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+59 -00 replies
4/20drm: Add drm_gem_vram_fill_create_dumb() to create dumb buffersdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+70 -00 replies
4/20drm: Add drm_gem_vram_fill_create_dumb() to create dumb buffersdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+70 -00 replies
5/20drm: Add simple PRIME helpers for GEM VRAMdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+118 -00 replies
5/20drm: Add simple PRIME helpers for GEM VRAMdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+118 -00 replies
6/20drm: Add VRAM MM, a simple memory manager for dedicated VRAMDocumentation/gpu/drm-mm.rst drivers/gpu/drm/Makefile drivers/gpu/drm/drm_vram_mm_helper.c +1 more+293 -20 replies
6/20drm: Add VRAM MM, a simple memory manager for dedicated VRAMDocumentation/gpu/drm-mm.rst drivers/gpu/drm/Makefile drivers/gpu/drm/drm_vram_mm_helper.c +1 more+293 -20 replies
7/20drm: Add default instance for VRAM MM callback functionsdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+17 -00 replies
7/20drm: Add default instance for VRAM MM callback functionsdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+17 -00 replies
8/20drm: Integrate VRAM MM into struct drm_deviceDocumentation/gpu/drm-mm.rst drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/drm_vram_helper_common.c +4 more+266 -10 replies
8/20drm: Integrate VRAM MM into struct drm_deviceDocumentation/gpu/drm-mm.rst drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/drm_vram_helper_common.c +4 more+266 -10 replies
9/20drm/ast: Convert AST driver to |struct drm_gem_vram_object|drivers/gpu/drm/ast/Kconfig drivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_drv.h +4 more+75 -3310 replies
9/20drm/ast: Convert AST driver to |struct drm_gem_vram_object|drivers/gpu/drm/ast/Kconfig drivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_drv.h +4 more+75 -3310 replies
10/20drm/ast: Convert AST driver to VRAM MMdrivers/gpu/drm/ast/Kconfig drivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_drv.h +2 more+13 -1670 replies
10/20drm/ast: Convert AST driver to VRAM MMdrivers/gpu/drm/ast/Kconfig drivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_drv.h +2 more+13 -1670 replies
11/20drm/ast: Replace mapping code with drm_gem_vram_{kmap/kunmap}()drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_fb.c drivers/gpu/drm/ast/ast_mode.c+53 -250 replies
11/20drm/ast: Replace mapping code with drm_gem_vram_{kmap/kunmap}()drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_fb.c drivers/gpu/drm/ast/ast_mode.c+53 -250 replies
12/20drm/bochs: Convert bochs driver to |struct drm_gem_vram_object|drivers/gpu/drm/bochs/Kconfig drivers/gpu/drm/bochs/bochs.h drivers/gpu/drm/bochs/bochs_drv.c +2 more+21 -3420 replies
12/20drm/bochs: Convert bochs driver to |struct drm_gem_vram_object|drivers/gpu/drm/bochs/Kconfig drivers/gpu/drm/bochs/bochs.h drivers/gpu/drm/bochs/bochs_drv.c +2 more+21 -3420 replies
13/20drm/bochs: Convert bochs driver to VRAM MMdrivers/gpu/drm/bochs/Kconfig drivers/gpu/drm/bochs/bochs.h drivers/gpu/drm/bochs/bochs_drv.c +1 more+11 -1660 replies
13/20drm/bochs: Convert bochs driver to VRAM MMdrivers/gpu/drm/bochs/Kconfig drivers/gpu/drm/bochs/bochs.h drivers/gpu/drm/bochs/bochs_drv.c +1 more+11 -1660 replies
14/20drm/mgag200: Convert mgag200 driver to |struct drm_gem_vram_object|drivers/gpu/drm/mgag200/Kconfig drivers/gpu/drm/mgag200/mgag200_cursor.c drivers/gpu/drm/mgag200/mgag200_drv.c +5 more+107 -3480 replies
14/20drm/mgag200: Convert mgag200 driver to |struct drm_gem_vram_object|drivers/gpu/drm/mgag200/Kconfig drivers/gpu/drm/mgag200/mgag200_cursor.c drivers/gpu/drm/mgag200/mgag200_drv.c +5 more+107 -3480 replies
15/20drm/mgag200: Convert mgag200 driver to VRAM MMdrivers/gpu/drm/mgag200/Kconfig drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h +2 more+15 -1610 replies
15/20drm/mgag200: Convert mgag200 driver to VRAM MMdrivers/gpu/drm/mgag200/Kconfig drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h +2 more+15 -1610 replies
16/20drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}()drivers/gpu/drm/mgag200/mgag200_cursor.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_fb.c +1 more+37 -320 replies
16/20drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}()drivers/gpu/drm/mgag200/mgag200_cursor.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_fb.c +1 more+37 -320 replies
17/20drm/vboxvideo: Convert vboxvideo driver to |struct drm_gem_vram_object|drivers/gpu/drm/vboxvideo/Kconfig drivers/gpu/drm/vboxvideo/vbox_drv.c drivers/gpu/drm/vboxvideo/vbox_drv.h +4 more+45 -3720 replies
17/20drm/vboxvideo: Convert vboxvideo driver to |struct drm_gem_vram_object|drivers/gpu/drm/vboxvideo/Kconfig drivers/gpu/drm/vboxvideo/vbox_drv.c drivers/gpu/drm/vboxvideo/vbox_drv.h +4 more+45 -3720 replies
18/20drm/vboxvideo: Convert vboxvideo driver to VRAM MMdrivers/gpu/drm/vboxvideo/Kconfig drivers/gpu/drm/vboxvideo/vbox_drv.c drivers/gpu/drm/vboxvideo/vbox_drv.h +2 more+13 -1650 replies
18/20drm/vboxvideo: Convert vboxvideo driver to VRAM MMdrivers/gpu/drm/vboxvideo/Kconfig drivers/gpu/drm/vboxvideo/vbox_drv.c drivers/gpu/drm/vboxvideo/vbox_drv.h +2 more+13 -1650 replies
19/20drm/hisilicon: Convert hibmc-drm driver to |struct drm_gem_vram_object|drivers/gpu/drm/hisilicon/hibmc/Kconfig drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +3 more+44 -2480 replies
19/20drm/hisilicon: Convert hibmc-drm driver to |struct drm_gem_vram_object|drivers/gpu/drm/hisilicon/hibmc/Kconfig drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +3 more+44 -2480 replies
20/20drm/hisilicon: Convert hibmc-drm driver to VRAM MMdrivers/gpu/drm/hisilicon/hibmc/Kconfig drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h +1 more+12 -1450 replies
20/20drm/hisilicon: Convert hibmc-drm driver to VRAM MMdrivers/gpu/drm/hisilicon/hibmc/Kconfig drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h +1 more+12 -1450 replies

Reviews trailers per patch

4 of 40 patches have a Reviewed-by or Acked-by.

PatchHans de Goede
1/20
1/20
2/20
2/20
3/20
3/20
4/20
4/20
5/20
5/20
6/20
6/20
7/20
7/20
8/20
8/20
9/20
9/20
10/20
10/20
11/20
11/20
12/20
12/20
13/20
13/20
14/20
14/20
15/20
15/20
16/20
16/20
17/20R-b R-b
17/20R-b R-b
18/20R-b R-b
18/20R-b R-b
19/20
19/20
20/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/20] Share TTM code among DRM framebuffer drivers

Several simple framebuffer drivers copy most of the TTM code from each other. The implementation is always the same; except for the name of some data structures.

As recently discussed, this patch set provides generic memory-management code for simple framebuffers with dedicated video memory. It further converts the respective drivers to the generic code. The shared code is basically the same implementation as the one copied among individual drivers.

The patch set contains two major changes: first, it introduces |struct drm_gem_vram_object| and helpers (GEM VRAM). It's a GEM object that is backed by VRAM. The type's purpose is somewhat similar to |struct drm_gem_{cma, shmem}_object|: it provides an commom implementation that handles all the basic cases. Second, the patch set introduces |struct drm_vram_mm| and helpers (VRAM MM). It's an implementation of a basic memory manager for VRAM.

Both, GEM VRAM and VRAM MM, support buffer placement in VRAM and system memory. Both can be used independedly from each other if desired by the DRM driver.

Currently ast, bochs, mgag200, vboxvideo and hisilicon/hibmc can use these helpers.

Future directions: with these changes, the respective drivers can also share some of their mode-setting or fbdev code. GEM VRAM's PRIME helpers allow for using the generic fbcon emulation.

The patch set is against a recent drm-tip.

v5:
* move bochs PRIME functions to GEM VRAM helpers
* always set struct file_operations.llseek to no_llseek()
* add WARN_ON_ONCE for pin-count mismatches
* only allocate 2 entries in placements array
v4:
* cleanups from checkpatch.pl
* add more documentation for VRAM helpers
* remove several fixed-size types from interfaces
* don't make drivers depend on DRM_TTM; auto-selected if necessary
* use single config optiom DRM_VRAM_HELPER
v3:
* share VRAM MM callback structure among drivers
* move VRAM MM instances to drm_device and share rsp. code
v2:
* rename |struct drm_gem_ttm_object| to |struct drm_gem_vram_object|
* rename |struct drm_simple_ttm| to |struct drm_vram_mm|
* make drm_is_gem_ttm() an internal helper
* add drm_gem_vram_kmap_at()
* return is_iomem from kmap functions
* redefine TTM placement flags for public interface
* add drm_vram_mm_mmap() helper
* replace almost all of driver's TTM code with these helpers
* documentation fixes

Thomas Zimmermann (20):

  drm: Add |struct drm_gem_vram_object| and helpers
  drm: Add |struct drm_gem_vram_object| callbacks for |struct

ttm_bo_driver|
drm: Add |struct drm_gem_vram_object| callbacks for |struct
drm_driver|
drm: Add drm_gem_vram_fill_create_dumb() to create dumb buffers
drm: Add simple PRIME helpers for GEM VRAM
drm: Add VRAM MM, a simple memory manager for dedicated VRAM
drm: Add default instance for VRAM MM callback functions
drm: Integrate VRAM MM into struct drm_device
drm/ast: Convert AST driver to |struct drm_gem_vram_object| drm/ast: Convert AST driver to VRAM MM
drm/ast: Replace mapping code with drm_gem_vram_{kmap/kunmap}() drm/bochs: Convert bochs driver to |struct drm_gem_vram_object| drm/bochs: Convert bochs driver to VRAM MM
drm/mgag200: Convert mgag200 driver to |struct drm_gem_vram_object| drm/mgag200: Convert mgag200 driver to VRAM MM drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}() drm/vboxvideo: Convert vboxvideo driver to |struct
drm_gem_vram_object|
drm/vboxvideo: Convert vboxvideo driver to VRAM MM drm/hisilicon: Convert hibmc-drm driver to |struct
drm_gem_vram_object|
drm/hisilicon: Convert hibmc-drm driver to VRAM MM

 Documentation/gpu/drm-mm.rst                  |  34 +-
 drivers/gpu/drm/Kconfig                       |   7 +
 drivers/gpu/drm/Makefile                      |   5 +
 drivers/gpu/drm/ast/Kconfig                   |   3 +-
 drivers/gpu/drm/ast/ast_drv.c                 |  13 +-
 drivers/gpu/drm/ast/ast_drv.h                 |  71 +-
 drivers/gpu/drm/ast/ast_fb.c                  |  34 +-
 drivers/gpu/drm/ast/ast_main.c                |  77 +-
 drivers/gpu/drm/ast/ast_mode.c                | 124 +--
 drivers/gpu/drm/ast/ast_ttm.c                 | 302 +-------
 drivers/gpu/drm/bochs/Kconfig                 |   2 +-
 drivers/gpu/drm/bochs/bochs.h                 |  54 +-
 drivers/gpu/drm/bochs/bochs_drv.c             |  22 +-
 drivers/gpu/drm/bochs/bochs_kms.c             |  18 +-
 drivers/gpu/drm/bochs/bochs_mm.c              | 426 +----------
 drivers/gpu/drm/drm_gem_vram_helper.c         | 713 ++++++++++++++++++
 drivers/gpu/drm/drm_vram_helper_common.c      |  98 +++
 drivers/gpu/drm/drm_vram_mm_helper.c          | 295 ++++++++
 drivers/gpu/drm/hisilicon/hibmc/Kconfig       |   2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c    |  21 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |  14 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |  33 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c |  30 +-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c   | 341 +--------
 drivers/gpu/drm/mgag200/Kconfig               |   2 +-
 drivers/gpu/drm/mgag200/mgag200_cursor.c      |  88 ++-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |  13 +-
 drivers/gpu/drm/mgag200/mgag200_drv.h         |  74 +-
 drivers/gpu/drm/mgag200/mgag200_fb.c          |  34 +-
 drivers/gpu/drm/mgag200/mgag200_main.c        |  87 +--
 drivers/gpu/drm/mgag200/mgag200_mode.c        |  53 +-
 drivers/gpu/drm/mgag200/mgag200_ttm.c         | 301 +-------
 drivers/gpu/drm/vboxvideo/Kconfig             |   2 +-
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |  12 +-
 drivers/gpu/drm/vboxvideo/vbox_drv.h          |  75 +-
 drivers/gpu/drm/vboxvideo/vbox_fb.c           |  22 +-
 drivers/gpu/drm/vboxvideo/vbox_main.c         |  75 +-
 drivers/gpu/drm/vboxvideo/vbox_mode.c         |  36 +-
 drivers/gpu/drm/vboxvideo/vbox_ttm.c          | 355 +--------
 include/drm/drm_device.h                      |   4 +
 include/drm/drm_gem_vram_helper.h             | 160 ++++
 include/drm/drm_vram_mm_helper.h              | 102 +++
 42 files changed, 1797 insertions(+), 2437 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_gem_vram_helper.c
 create mode 100644 drivers/gpu/drm/drm_vram_helper_common.c
 create mode 100644 drivers/gpu/drm/drm_vram_mm_helper.c
 create mode 100644 include/drm/drm_gem_vram_helper.h
 create mode 100644 include/drm/drm_vram_mm_helper.h

--
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel