Skip to content

avoid lseek on block_status

Vladimir Sementsov-Ogievskiy qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 9 repliesApplied

Changes in v2 from the cover letter

01: new
02: [mostly by Kevin's comments]
- rewritten to go through new flag BDRV_BLOCK_RECURSE
- never retry detection if failed for first time
- rewrite detection to do less iterations and to be more simple

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2tests/perf: Test lseek influence on qcow2 block-statustests/perf/block/qcow2/convert-blockstatus+71 -00 replies
2/2block: avoid recursive block_status call if possibleblock/io.c block/qcow2-refcount.c block/qcow2.c +6 more+67 -64 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 for 4.1 0/2] avoid lseek on block_status

Hi!

It's a continuation for
"[PATCH] qcow2: avoid lseek on block_status if possible"
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06598.html

performance results for block-status on tmpfs [tests originally by Kevin, now they are in 01]:

./tests/perf/block/qcow2/convert-blockstatus /ramdisk/x

after 01:

plain: 81.77
forward: 82.61
prealloc: 0.01

after 02:

plain: 0.12
forward: 0.12
prealloc: 0.01

v2:
01: new
02: [mostly by Kevin's comments]
- rewritten to go through new flag BDRV_BLOCK_RECURSE
- never retry detection if failed for first time
- rewrite detection to do less iterations and to be more simple

iotests 102 behavior changed [and not sure about other two ones in comparison with v1, but it seems it doesn't matter]

also, patch subject changed, as now it's a generic change for block layer

Vladimir Sementsov-Ogievskiy (2):
tests/perf: Test lseek influence on qcow2 block-status
block: avoid recursive block_status call if possible

 block/qcow2.h                              |  4 ++
 include/block/block.h                      |  8 ++-
 block/io.c                                 |  9 ++-
 block/qcow2-refcount.c                     | 32 ++++++++++
 block/qcow2.c                              | 11 ++++
 tests/perf/block/qcow2/convert-blockstatus | 71 ++++++++++++++++++++++
 tests/qemu-iotests/102                     |  2 +-
 tests/qemu-iotests/102.out                 |  3 +-
 tests/qemu-iotests/141.out                 |  2 +-
 tests/qemu-iotests/144.out                 |  2 +-
 10 files changed, 138 insertions(+), 6 deletions(-)
 create mode 100755 tests/perf/block/qcow2/convert-blockstatus
Signature · 1 line
2.18.0