Skip to content

prepare to make lcore_config not visible in ABI

Stephen Hemminger dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyIn review
  2. v25 patches 7 repliesSuperseded
  3. v15 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- rte_lcore_index should not be experimental
- eal map should chain from 18.11
- more fixes in bond example

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5eal: use unsigned int in rte_lcore.h functionslib/librte_eal/common/include/rte_lcore.h+6 -60 replies
2/5eal: add accessor functions for lcore_configdoc/guides/rel_notes/release_19_05.rst lib/librte_eal/common/eal_common_lcore.c lib/librte_eal/common/include/rte_lcore.h +1 more+91 -140 replies
3/5bus: use lcore accessor functionsdrivers/bus/dpaa/dpaa_bus.c drivers/bus/fslmc/portal/dpaa2_hw_dpio.c+7 -30 replies
4/5examples/bond: use lcore accessorexamples/bond/main.c+7 -60 replies
5/5app/test: use lcore accessor functionsapp/test/test_cryptodev.c app/test/test_hash_readwrite_lf.c app/test/test_ring_perf.c +1 more+30 -280 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchDavid Marchand
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI

This set of patches makes the lcore_config structure less visible as part of the ABI. This version does not break the ABI (yet) follow on patch moves lcore_config into eal_private.h

Changes for v3 (based on David's feedback):
- rte_lcore_index should not be experimental
- eal map should chain from 18.11
- more fixes in bond example

Stephen Hemminger (5):
eal: use unsigned int in rte_lcore.h functions
eal: add accessor functions for lcore_config
bus: use lcore accessor functions
examples/bond: use lcore accessor
app/test: use lcore accessor functions

 app/test/test_cryptodev.c                 |  2 +-
 app/test/test_hash_readwrite_lf.c         | 14 +++---
 app/test/test_ring_perf.c                 | 22 +++++----
 app/test/test_stack_perf.c                | 20 ++++----
 doc/guides/rel_notes/release_19_05.rst    |  6 +++
 drivers/bus/dpaa/dpaa_bus.c               |  6 ++-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
 examples/bond/main.c                      | 13 +++---
 lib/librte_eal/common/eal_common_lcore.c  | 39 ++++++++++++++++
 lib/librte_eal/common/include/rte_lcore.h | 57 ++++++++++++++++-------
 lib/librte_eal/rte_eal_version.map        | 11 +++++
 11 files changed, 139 insertions(+), 55 deletions(-)
Signature · 1 line
2.20.1