Skip to content

First batch of global_qtest-removement patches for QEMU 4.1

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tests/tco: Make test independent of global_qtesttests/tco-test.c+32 -310 replies
2/5tests/megasas: Make test independent of global_qtesttests/megasas-test.c+1 -10 replies
3/5tests/qmp-cmd-test: Use qtest_init() instead of qtest_start()tests/qmp-cmd-test.c+9 -60 replies
4/5tests/test-hmp: Use qtest_init() instead of qtest_start()tests/test-hmp.c+10 -91 reply
5/5tests/ide-test: Make test independent of global_qtesttests/ide-test.c+159 -1250 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/5
2/5
3/5
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH for-4.1 0/5] First batch of global_qtest-removement patches for QEMU 4.1

While global_qtest and its wrapper functions work fine for tests that only run one instance of QEMU, using the global_qtest variable in our qtests is very problematic for tests that use multiple test states (e.g. migration tests). Thus tests that still use global_qtest make it hard to share code (either by copy-n-pasting or by calling common functions) with tests that try to track multiple test states, so we should try to completely get rid of the global_qtest variable and its wrapper function in the long run.

Here's another set of patches that cleans up the usage of global_qtest in a couple of tests.

Thomas Huth (5):
tests/tco: Make test independent of global_qtest tests/megasas: Make test independent of global_qtest tests/qmp-cmd-test: Use qtest_init() instead of qtest_start() tests/test-hmp: Use qtest_init() instead of qtest_start() tests/ide-test: Make test independent of global_qtest

 tests/ide-test.c     | 284 ++++++++++++++++++++++++-------------------
 tests/megasas-test.c |   2 +-
 tests/qmp-cmd-test.c |  15 ++-
 tests/tco-test.c     |  63 +++++-----
 tests/test-hmp.c     |  19 +--
 5 files changed, 211 insertions(+), 172 deletions(-)
Signature · 1 line
2.21.0