Merge m25p80 into spi-nor
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 6 repliesIn review
- v43 patches 8 repliesSuperseded
- v33 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 9 replies | Superseded | |
| v1 | 2 patches | 3 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mtd: spi-nor: always use bounce buffer for register read/writesdrivers/ include/ | +49 | 0 replies | |
| 2/3 | mtd: spi-nor: Move m25p80 code in spi-nor.cdrivers/ drivers/ drivers/ +3 more | +605 | 3 replies | |
| 3/3 | mtd: spi-nor: Rework hwcaps selection for the spi-mem casedrivers/ include/ | +162 | 1 reply |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Boris Brezillon |
|---|---|
| 1/3 | R-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/3] Merge m25p80 into spi-nor
This is repost of patch 6 and 7 split from from Boris Brezillon's X-X-X mode support series[1]
Background from cover letter for RFC[1]:
m25p80 is just a simple SPI NOR controller driver (a wrapper around the SPI mem API). Not only it shouldn't be named after a specific SPI NOR chip, but it also doesn't deserve a specific driver IMO, especially if the end goal is to get rid of SPI NOR controller drivers found in drivers/mtd/spi-nor/ and replace them by SPI mem drivers (which would be placed in drivers/spi/). With this solution, we declare the SPI NOR driver as a spi_mem_driver, just like the SPI NAND layer is declared as a spi_mem driver (patch 1/2).
This solution also allows us to check at a fined-grain level (thanks to the spi_mem_supports_op() function) which operations are supported and which ones are not, while the original m25p80 logic was basing this decision on the SPI_{RX,TX}_{DUAL,QUAD,OCTO} flags only (patch 2/2).
[1] https://patchwork.ozlabs.org/cover/982926/
Tested on TI' DRA7xx EVM with TI QSPI controller (a spi-mem driver) with DMA (s25fl256 and mx66l51235l) flash. I don't see any performance regression due to bounce buffer copy introduced by this series Also tested with cadence-quadspi (a spi-nor driver) driver
Boris Brezillon (2):
mtd: spi-nor: Move m25p80 code in spi-nor.c
mtd: spi-nor: Rework hwcaps selection for the spi-mem case
Vignesh Raghavendra (1):
mtd: spi-nor: always use bounce buffer for register read/writes
drivers/mtd/devices/Kconfig | 18 - drivers/mtd/devices/Makefile | 1 - drivers/mtd/devices/m25p80.c | 347 --------------- drivers/mtd/spi-nor/Kconfig | 2 + drivers/mtd/spi-nor/spi-nor.c | 814 +++++++++++++++++++++++++++++++--- include/linux/mtd/spi-nor.h | 24 +- 6 files changed, 777 insertions(+), 429 deletions(-) delete mode 100644 drivers/mtd/devices/m25p80.c
Signature · 1 line
2.22.0