Skip to content

libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv

Anthony PERARD xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 1 replyIn review
  2. v29 patches 6 repliesSuperseded
  3. v19 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- renamed libxl__ev_lock to libxl__ev_devlock
- rebased
- 1 patch not acked "libxl_internal: Introduce libxl__ev_devlock for devices hotplug via QMP"
- other patches have been updated for the new ev_devlock name and for the rebased

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9libxl_internal: Remove lost commenttools/libxl/libxl_internal.h+0 -70 replies
2/9libxl: Pointer on usage of libxl__domain_userdata_locktools/libxl/libxl_internal.h+6 -00 replies
3/9libxl_internal: Introduce libxl__ev_devlock for devices hotplug via QMPtools/libxl/libxl_internal.c tools/libxl/libxl_internal.h+235 -41 reply
4/9libxl: Add optimisation to ev_locktools/libxl/Makefile tools/libxl/libxl_internal.c+22 -00 replies
5/9libxl_disk: Reorganise libxl_cdrom_inserttools/libxl/libxl_disk.c+32 -260 replies
6/9libxl_disk: Cut libxl_cdrom_insert into steps ..tools/libxl/libxl_disk.c+155 -410 replies
7/9libxl_disk: Implement missing timeout for libxl_cdrom_inserttools/libxl/libxl_disk.c+21 -00 replies
8/9libxl: Move qmp_parameters_* prototypes to libxl_internal.htools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+51 -390 replies
9/9libxl_disk: Use ev_qmp in libxl_cdrom_inserttools/libxl/libxl_disk.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+100 -450 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchIan JacksonWei Liu
1/9A-b A-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Xen-devel] [PATCH v3 0/9] libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv

Hi,

Changes in v3:
- renamed libxl__ev_lock to libxl__ev_devlock
- rebased
- 1 patch not acked "libxl_internal: Introduce libxl__ev_devlock for devices hotplug via QMP"
- other patches have been updated for the new ev_devlock name and for the rebased

Changes in v2:
- New libxl__ev_lock, which actually respect lock hierarchy (it's outside of CTX_LOCK).
- some smaller changes detailed in patch notes.

This patch series fix libxl_cdrom_insert to work with a depriviledge QEMU. For that, we need to use libxl__ev_qmp. For that, we need a new lock because userdata_lock can't be used anymore.

FYI: I don't think that enough yet to migrate a depriviledged QEMU. We may need to open disks/cdrom in libxl before starting QEMU, similar to what this patch series do when inserting a new cdrom.

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-slow-lock-v3

Anthony PERARD (9):
libxl_internal: Remove lost comment
libxl: Pointer on usage of libxl__domain_userdata_lock
libxl_internal: Introduce libxl__ev_devlock for devices hotplug via
QMP
libxl: Add optimisation to ev_lock
libxl_disk: Reorganise libxl_cdrom_insert
libxl_disk: Cut libxl_cdrom_insert into steps ..
libxl_disk: Implement missing timeout for libxl_cdrom_insert
libxl: Move qmp_parameters_* prototypes to libxl_internal.h
libxl_disk: Use ev_qmp in libxl_cdrom_insert

 tools/libxl/Makefile         |   3 +
 tools/libxl/libxl_disk.c     | 341 ++++++++++++++++++++++++++++-------
 tools/libxl/libxl_internal.c | 182 +++++++++++++++++++
 tools/libxl/libxl_internal.h | 105 +++++++++--
 tools/libxl/libxl_qmp.c      |  89 ++++-----
 5 files changed, 590 insertions(+), 130 deletions(-)
Signature · 7 lines
Anthony PERARD


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel