Skip to content

fix big endian build

Thomas Monjalon dpdk-dev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mbuf: fix big endian buildlib/librte_mbuf/rte_mbuf.h+1 -12 replies
2/2net/enetc: fix big endian builddrivers/net/enetc/enetc_rxtx.c+3 -20 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKonstantin Ananyev
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/2] fix big endian build

There are at least 4 issues when compiling with a big endian toolchain. 2 of them are fixed in this patchset.
The remaining ones are in ice and bnxt PMDs.

About ice, the error is:
drivers/net/ice/base/ice_flex_pipe.c:302:8: error:
‘state.entry_idx’ may be used uninitialized in this function
It is not obvious to fix, there may be few places where a struct should be initialized. Please fix it soon.

About bnxt, the issue looks like a mistake reproduced several times:

    drivers/net/bnxt/bnxt_ethdev.c:2652:19: error:
    invalid use of void expression
    rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off));

The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times. The result of the endian conversion is never used. Please fix it soon.

Thomas Monjalon (2):
mbuf: fix big endian build
net/enetc: fix big endian build

v2 for checkpatch

 drivers/net/enetc/enetc_rxtx.c | 5 +++--
 lib/librte_mbuf/rte_mbuf.h     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.21.0