Enable SEV VM to boot with assigned PCI device
Status from this message: NACKed-by: Gary R Hook <[email protected]>
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | memory: Fix the memory region type assignment ordermemory.c | +8 | 1 reply | |
| 2/2 | target/i386: sev: Do not pin the ram device memory regiontarget/ | +11 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Alex Williamson | Eduardo Habkost | Paolo Bonzini | Gary R Hook |
|---|---|---|---|---|
| Series | A-b | |||
| 1/2 | R-b | A-b | ||
| 2/2 | A-b | NACKed-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [Qemu-devel] [RHEL-8.1 virt 0/2] Enable SEV VM to boot with assigned PCI device
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
On an AMD SEV enabled host with an SEV enabled guest, attaching an assigned device to the VM results in a failure to start the VM:
qemu-kvm: -device vfio-pci,host=01:00.0,id=hostdev0,bus=pci.2,addr=0x0: sev_ram_block_added: failed to register region (0x7fd96e6bb000+0x20000) error 'Cannot allocate memory'
In this example the assigned device is a simple Intel 82574L NIC:
01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection
Subsystem: Intel Corporation Gigabit CT Desktop Adapter Flags: bus master, fast devsel, latency 0, IRQ 89, NUMA node 0 Memory at fb9c0000 (32-bit, non-prefetchable) [size=128K] Memory at fb900000 (32-bit, non-prefetchable) [size=512K]
Note that the error indicates the region as (base+size) where a size of 0x20000 is 128K, which matches that of BAR0 for the device. dmesg on the host also reports:
SVM: SEV: Failure locking 32 pages.
SEV guests make use of the RAMBlock notifier in QEMU to add page pinnings for SEV; the kernel side of the call only knows how to pin pages with get_user_pages(), and this currently faults on non-page backed mappings (e.g. the mmap of an MMIO BAR).
To resolve this failure, change the order of the memory region type assignment and avoid pinning device memory regions.
Danilo C. L. de Paula (2):
redhat: branching qemu-kvm to rhel-8.1.0
redhat: renaming branch to rhel-8.1.0
Gary R Hook (2):
Subject: memory: Fix the memory region type assignment order
Subject: target/i386: sev: Do not pin the ram device memory region
.gitpublish | 6 +++--- memory.c | 9 ++++++++- target/i386/sev.c | 11 +++++++++++ 3 files changed, 22 insertions(+), 4 deletions(-)
Signature · 1 line
2.18.1