Skip to content

Statistics counter support

Leon Romanovsky linux-rdma netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest17 patches 6 repliesIn review
  2. v417 patches 5 repliesSuperseded
  3. v217 patches 22 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches0 repliesSuperseded

Changes in v5 from the cover letter

* Patch #6 and #14 - consolidated many counter release functions, removed mutex lock protection from dealloc_counter() call and simplified kref_put/kref_get operations.
* Added Saeed's ACK tags.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17net/mlx5: Add rts2rts_qp_counters_set_id field in hca capinclude/linux/mlx5/mlx5_ifc.h+3 -10 replies
2/17RDMA/restrack: Introduce statistic counterdrivers/infiniband/core/restrack.c include/rdma/rdma_counter.h include/rdma/restrack.h+39 -50 replies
3/17RDMA/restrack: Add an API to attach a task to a resourcedrivers/infiniband/core/restrack.c drivers/infiniband/core/restrack.h+16 -00 replies
4/17RDMA/restrack: Make is_visible_in_pid_ns() as an APIdrivers/infiniband/core/nldev.c drivers/infiniband/core/restrack.c drivers/infiniband/core/restrack.h+16 -130 replies
5/17RDMA/counter: Add set/clear per-port auto mode supportdrivers/infiniband/core/Makefile drivers/infiniband/core/counters.c drivers/infiniband/core/device.c +3 more+132 -10 replies
6/17RDMA/counter: Add "auto" configuration mode supportdrivers/infiniband/core/counters.c drivers/infiniband/core/device.c drivers/infiniband/core/verbs.c +2 more+259 -01 reply
7/17IB/mlx5: Support set qp counterdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/qp.c include/linux/mlx5/qp.h+81 -20 replies
8/17IB/mlx5: Add counter set id as a parameter for mlx5_ib_query_q_counters()drivers/infiniband/hw/mlx5/main.c+5 -50 replies
9/17IB/mlx5: Support statistic q counter configurationdrivers/infiniband/hw/mlx5/main.c+44 -00 replies
10/17RDMA/nldev: Allow counter auto mode configration through RDMA netlinkdrivers/infiniband/core/nldev.c include/uapi/rdma/rdma_netlink.h+86 -00 replies
11/17RDMA/netlink: Implement counter dumpit calbackdrivers/infiniband/core/counters.c drivers/infiniband/core/device.c drivers/infiniband/core/nldev.c +3 more+262 -22 replies
12/17IB/mlx5: Add counter_alloc_stats() and counter_update_stats() supportdrivers/infiniband/hw/mlx5/main.c+23 -00 replies
13/17RDMA/core: Get sum value of all counters when perform a sysfs stat readdrivers/infiniband/core/counters.c drivers/infiniband/core/sysfs.c include/rdma/rdma_counter.h+98 -30 replies
14/17RDMA/counter: Allow manual mode configuration supportdrivers/infiniband/core/counters.c include/rdma/rdma_counter.h include/uapi/rdma/rdma_netlink.h+229 -30 replies
15/17RDMA/nldev: Allow counter manual mode configration through RDMA netlinkdrivers/infiniband/core/nldev.c include/rdma/rdma_counter.h include/uapi/rdma/rdma_netlink.h+103 -130 replies
16/17RDMA/nldev: Allow get counter mode through RDMA netlinkdrivers/infiniband/core/counters.c drivers/infiniband/core/nldev.c+78 -10 replies
17/17RDMA/nldev: Allow get default counter statistics through RDMA netlinkdrivers/infiniband/core/nldev.c drivers/infiniband/core/sysfs.c include/rdma/ib_verbs.h+104 -10 replies

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchMajd DibbinySaeed Mahameed
1/17R-b A-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b A-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH rdma-next v5 00/17] Statistics counter support

From: Leon Romanovsky <[email protected]>

Changelog:
v4 -> v5:
* Patch #6 and #14 - consolidated many counter release functions, removed mutex lock protection from dealloc_counter() call and simplified kref_put/kref_get operations.
* Added Saeed's ACK tags.
v3 -> v4:
* Add counter_dealloc() callback function
* Moved to kref implementation
* Fixed lock during spinlock
v2 -> v3:
* We didn't change use of atomics over kref for management of unbind counter from QP. The reason to it that bind and unbind are non-symmetric in regards of put and get, so we need to count differently memory release flows of HW objects (restrack) and SW bind operations.
* Everything else was addressed.
v1 -> v2:
* Rebased to latest rdma-next
v0 -> v1:
* Changed wording of counter comment
* Removed unneeded assignments
* Added extra patch to present global counters

----------------------------------------------------

Hi,

This series from Mark provides dynamic statistics infrastructure. He uses netlink interface to configure and retrieve those counters.

This infrastructure allows to users monitor various objects by binding to them counters. As the beginning, we used QP object as target for those counters, but future patches will include ODP MR information too.

Two binding modes are supported:
- Auto: This allows a user to build automatic set of objects to a counter according to common criteria. For example in a per-type scheme, where in one process all QPs with same QP type are bound automatically to a single counter.
- Manual: This allows a user to manually bind objects on a counter.

Those two modes are mutual-exclusive with separation between processes, objects created by different processes cannot be bound to a same counter.

For objects which don't support counter binding, we will return pre-allocated counters.

$ rdma statistic qp set link mlx5_2/1 auto type on
$ rdma statistic qp set link mlx5_2/1 auto off
$ rdma statistic qp bind link mlx5_2/1 lqpn 178
$ rdma statistic qp unbind link mlx5_2/1 cntn 4 lqpn 178
$ rdma statistic show
$ rdma statistic qp mode

Thanks

Mark Zhang (17):
net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap RDMA/restrack: Introduce statistic counter RDMA/restrack: Add an API to attach a task to a resource RDMA/restrack: Make is_visible_in_pid_ns() as an API RDMA/counter: Add set/clear per-port auto mode support RDMA/counter: Add "auto" configuration mode support IB/mlx5: Support set qp counter
IB/mlx5: Add counter set id as a parameter for

    mlx5_ib_query_q_counters()

IB/mlx5: Support statistic q counter configuration RDMA/nldev: Allow counter auto mode configration through RDMA netlink RDMA/netlink: Implement counter dumpit calback
IB/mlx5: Add counter_alloc_stats() and counter_update_stats() support RDMA/core: Get sum value of all counters when perform a sysfs stat
read
RDMA/counter: Allow manual mode configuration support RDMA/nldev: Allow counter manual mode configration through RDMA
netlink
RDMA/nldev: Allow get counter mode through RDMA netlink RDMA/nldev: Allow get default counter statistics through RDMA netlink

 drivers/infiniband/core/Makefile     |   2 +-
 drivers/infiniband/core/counters.c   | 634 +++++++++++++++++++++++++++
 drivers/infiniband/core/device.c     |  10 +
 drivers/infiniband/core/nldev.c      | 551 ++++++++++++++++++++++-
 drivers/infiniband/core/restrack.c   |  49 ++-
 drivers/infiniband/core/restrack.h   |   3 +
 drivers/infiniband/core/sysfs.c      |  16 +-
 drivers/infiniband/core/verbs.c      |   9 +
 drivers/infiniband/hw/mlx5/main.c    |  77 +++-
 drivers/infiniband/hw/mlx5/mlx5_ib.h |   6 +
 drivers/infiniband/hw/mlx5/qp.c      |  76 +++-
 include/linux/mlx5/mlx5_ifc.h        |   4 +-
 include/linux/mlx5/qp.h              |   1 +
 include/rdma/ib_verbs.h              |  31 ++
 include/rdma/rdma_counter.h          |  65 +++
 include/rdma/restrack.h              |   4 +
 include/uapi/rdma/rdma_netlink.h     |  52 ++-
 17 files changed, 1559 insertions(+), 31 deletions(-)
 create mode 100644 drivers/infiniband/core/counters.c
 create mode 100644 include/rdma/rdma_counter.h